consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
6,458 Commits 1 Branch 0 Tags
dec7d2d2b5edfeedf98fb25ff87cc08cd50ff17c
Commit Graph

6458 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Senén Rodero Rodríguez
dec7d2d2b5 Add followable specific notices to follows controller actions and render notice on AJAX JS response. 2017-07-19 19:43:05 +02:00
Senén Rodero Rodríguez
3b1335062f Remove uneeded initialization after ajax refresh. 2017-07-19 17:58:51 +02:00
Senén Rodero Rodríguez
119a6b3397 Remove where clause from followable button partial and rename followable_button partial to follow_button. 2017-07-19 17:51:51 +02:00
Senén Rodero Rodríguez
c9a6630c94 Remove popup on follow buttons and remove uneeded code. 2017-07-19 17:51:45 +02:00
Senén Rodero Rodríguez
cba497b32e Create new followables helper to have some methods previously on follows helper. Rename entity to followable. 2017-07-19 17:50:46 +02:00
Senén Rodero
3be893b0ba Merge pull request #12 from consul/follows-refactoring 
Minor refactoring for follows
 2017-07-19 15:46:51 +02:00
rgarcia
b7ef755b16 minor refactoring for follows 2017-07-19 13:52:38 +02:00
Senén Rodero Rodríguez
57c8887077 Add method to follows helper to get followable partial name and arguments automatically. 2017-07-18 19:35:47 +02:00
Senén Rodero Rodríguez
16987e7eb8 Easier conditional usage. 2017-07-18 19:21:17 +02:00
Senén Rodero Rodríguez
249641fe23 Simpler code to get followable object icon. 2017-07-18 19:16:48 +02:00
Senén Rodero Rodríguez
36f9836e68 Use inflector methods instead of manual replacements. 2017-07-18 19:12:24 +02:00
taitus
cef67c50a8 Increased test coverage to Following user public page. 2017-07-13 20:33:58 +02:00
taitus
b0c571e658 Do not display send notification button when proposal is from another author. 2017-07-13 20:33:57 +02:00
Alessandro Cuoghi
556e2598c3 Remove margin bottom in the table inside accordion. Divided into groups of 10 interests. Inserted interests in columns. 2017-07-13 20:29:36 +02:00
taitus
7e2e94d709 Add following tab to user public page. 2017-07-13 20:29:34 +02:00
Alessandro Cuoghi
52e195d837 Add tab. Add accordion. Add style. Pass test scss-lint. 2017-07-13 20:14:55 +02:00
BertoCQ
8d7a467397 Merge pull request #1746 from consul/rubocop/rails_fixes 
Rubocop fixes 🤖: Rails edition 💎🛤
 2017-07-11 22:28:55 +02:00
Bertocq
dd54be111d Fix follower notifications flaky spec 2017-07-11 18:08:58 +02:00
BertoCQ
9c4eb4cef3 Merge pull request #1727 from rockandror/followable 
Followable
 2017-07-11 13:19:42 +02:00
Bertocq
fafec293e8 Remove duplicated ability for everyone 2017-07-11 12:51:39 +02:00
BertoCQ
204ea13c85 Merge branch 'master' into followable 2017-07-11 11:30:49 +02:00
Senén Rodero Rodríguez
b0ee52556c Remove comment 2017-07-11 10:36:07 +02:00
Senén Rodero Rodríguez
503e079909 Move followable button to sidebar after social share buttons 2017-07-11 10:30:07 +02:00
Senén Rodero Rodríguez
58b1ee57cf Set button style to followable button 2017-07-11 10:29:23 +02:00
Bertocq
5a358bce17 Fix all Rails/FilePath rubocop issues 2017-07-10 23:08:02 +02:00
Bertocq
3a54713ed0 Fix all Rails/DynamicFindBy rubocop issues 2017-07-10 23:04:27 +02:00
Bertocq
023825b4c9 Fix Rails/Present rubocop issue 2017-07-10 23:03:05 +02:00
Bertocq
beb4bc119c Fix Rails/Delegate rubocop issue 2017-07-10 23:02:27 +02:00
Bertocq
4e0d88739d Fix Rails/Blank rubocop issue 2017-07-10 23:02:27 +02:00
BertoCQ
6285ad3b68 Merge pull request #1738 from consul/feature/improve_budget_results 
Improve budget results
 2017-07-10 22:57:30 +02:00
Bertocq
11a793d63f Hide incompatible and non-winner investments by default 2017-07-10 19:43:55 +02:00
Bertocq
49f48ddf4b Highlight current heading on results list 2017-07-10 17:48:04 +02:00
Bertocq
741a342bb0 Restrict compatilibility edit on admin investment form 
Why:

* A non-winner but compatible investment shouldn't be marked as incompatible

How:

* Show incompatilibility checkbox only if investment is winner or incompatible
 2017-07-10 17:34:05 +02:00
Bertocq
2fba9de33b Don't display incompatible investment's table if empty 2017-07-10 17:12:28 +02:00
Bertocq
3a94fe4cc2 Fix indentation on if-else assignement 2017-07-10 16:03:31 +02:00
Bertocq
efacd0def3 Make calculate_winners explicitly delayed 
Why:

* As seen on preproduction and production environments on Madrid's fork. Budget::Result#calculate_winners is very costly when done to all headings for a given budget (as requested on Admin::BudgetsController#calculate_winners) but its not when done individually for only a heading (as requested on Budget::Investment#recalculate_heading_winners)

How:

* Removing `handle_asynchronously :calculate_winners` from bellow Budget::Result#calculate_winners definition, to avoid making any call delayed. And explicitly calling `.delay` only when needed (on Admin::BudgetsController#calculate_winners)
 2017-07-10 15:12:14 +02:00
Bertocq
2b85deabec Recalculate heading winners on incompatibility change 
Why:

* We should recalculate winners also when an incompatible investment is flagged as compatible again

How:

* Removing the condition to recalculate that was checking only for a winner investment flagged as incompatible
* Extending the Budget::Result model spec to cover that new scenario
 2017-07-10 14:24:55 +02:00
Raimond Garcia
08bc32defb Merge pull request #1728 from consul/rubocop/metrics_line_lenght 
Rubocop 🤖  The LineLength Truncation ⚡️
 2017-07-10 14:21:27 +02:00
Raimond Garcia
885d5edc3d Merge pull request #1730 from consul/chore/gemfile_cleanup 
Gemfile cleanup
 2017-07-10 14:21:16 +02:00
Bertocq
69f4e1c683 Fix all rubocop Metrics/LineLength issues (140+) 2017-07-10 13:22:49 +02:00
Bertocq
8f97bd86b7 Specify version for all gems 2017-07-10 12:52:04 +02:00
Senén Rodero Rodríguez
95630d6546 Add comment to temporary bugfix. 2017-07-10 12:46:31 +02:00
Bertocq
3f9d95f6a3 Sort all gems in Gemfile 2017-07-10 12:18:49 +02:00
Bertocq
862a30b493 Remove unnecesary comments on gemfile 2017-07-10 12:05:34 +02:00
Bertocq
100926162e Remove therubyracer gem, never used 2017-07-10 12:05:34 +02:00
Bertocq
efa2e7c774 Remove bcrypt gem, never used 2017-07-10 12:05:34 +02:00
Bertocq
5763ee03f4 Sort gem names alphabetically for dev and test groups 2017-07-10 12:05:34 +02:00
Bertocq
4e4f316f94 Reorganize development and test gems 2017-07-10 12:05:34 +02:00
Raimond Garcia
6fc5b1e8c9 Merge pull request #1735 from consul/chore/upgrade_initialjs-rails 
Upgrade initialjs-rails gem
 2017-07-10 12:03:21 +02:00
Raimond Garcia
81ac2581fb Merge pull request #1734 from consul/fix/localize_date 
Fix date localization
 2017-07-10 12:02:07 +02:00