Commit Graph

6458 Commits

Author SHA1 Message Date
Raimond Garcia
debb12f026 Merge pull request #1733 from consul/chore/update_code_of_conduct
Update Code of Conduct
2017-07-10 12:01:09 +02:00
Raimond Garcia
cd91608922 Merge pull request #1729 from consul/chore/remove_tolk
Remove Tolk, Crowdin in use
2017-07-10 11:51:59 +02:00
Bertocq
74e2c406d4 Upgrade initialjs-rails gem version
In order to avoid some html validations a PR was opened https://github.com/dgilperez/initialjs-rails/pull/6 and later on merged with some extra specs coverage https://github.com/dgilperez/initialjs-rails/pull/7 Thanks @dgilperez and @decabeza!!
2017-07-10 01:01:32 +02:00
Bertocq
51a22e8733 Fix english translation string for figcaption 2017-07-09 17:07:56 +02:00
Bertocq
824a672292 Fix spectations for localized milestone date 2017-07-09 16:44:34 +02:00
Bertocq
b1caefdf9a Use i18n to localize date on view 2017-07-09 13:44:31 +02:00
Bertocq
0b967dac89 Fix english translation for budget investment share 2017-07-09 13:37:15 +02:00
Bertocq
dd8ff5284f Update Code of Conduct to contributor covenant 1.4 2017-07-09 13:06:44 +02:00
Bertocq
3dd459f18a Fix valuation english translation to English 2017-07-09 11:59:51 +02:00
Bertocq
8b2b21c6d7 Remove Tolk, Crowdin substituted it
Why:

* Crowdin now hosts all consul translations publicly so anyone can contribute https://crowdin.com/project/consul/invite
* Crowdin makes easy for non-tech people to contribute, once we have a demo site we'll be able to offer "on site" translation
* If you still use Tolk, we recommend removing this commit (but adding tolk gem to ./Gemfile_custom file to avoid future merge conflicts)

How:

* Reverting changes introduced with 9610a6a933
2017-07-09 00:56:14 +02:00
Bertocq
dbc3af917a Update rubocop_todo list with rubocop --auto-gen-config 2017-07-07 21:24:45 +02:00
Senén Rodero Rodríguez
112e0649bf Add missing proposal model specs to check new users_to_notify method. 2017-07-07 15:18:37 +02:00
Senén Rodero Rodríguez
4b2310c135 Move and refactor method from follow to user model to get user interests. Add specification to check the discard of duplicate interests. 2017-07-07 15:18:34 +02:00
Senén Rodero Rodríguez
a7aef0a9fb Initialize App js modules after followable update. 2017-07-07 13:38:53 +02:00
taitus
60e812c2e5 New texts and titles for followable buttons. 2017-07-07 13:38:53 +02:00
taitus
e54e33f296 Use display in followable shared specs names when referring to DOM elements renderization. Add whitespace to proposal page. 2017-07-07 13:38:53 +02:00
taitus
5fe894aa6b New proposal method to get users_to_notify. 2017-07-07 13:38:52 +02:00
taitus
0c2be6a0d4 Refactor js followable response. 2017-07-07 13:38:52 +02:00
taitus
b60748c552 Remove unneeded return from Follow model. Add whitespaces to enhance reading. 2017-07-07 13:38:52 +02:00
taitus
97ee107157 Do not show flaggable and followable buttons on budgets_investment and proposals pages when user is not logged. 2017-07-07 13:38:52 +02:00
taitus
0ffa213a65 Fix scss-lint 2017-07-07 13:38:49 +02:00
taitus
b29bf62f56 Send proposals notifications to followers. 2017-07-07 13:37:55 +02:00
taitus
35f7f11177 Add dependent destroy to followable. 2017-07-07 13:37:55 +02:00
taitus
14ec4f5315 Add styles and translations for users interests. 2017-07-07 13:37:53 +02:00
Senén Rodero Rodríguez
313b78978d Add followable JS module. Refactor follow_helper and follow buttons partial. 2017-07-07 13:34:54 +02:00
Senén Rodero Rodríguez
1f22286e29 Create rspec shared examples to test followable features on any followable entity. 2017-07-07 13:34:54 +02:00
taitus
19820e4432 Add public interests validation and show interests on user profile 2017-07-07 13:34:43 +02:00
taitus
bce28afe36 Add followable to budget investment model. 2017-07-07 12:07:25 +02:00
Senén Rodero Rodríguez
84dbef16a4 Create followable concern, follow model. Add followable to proposal model. 2017-07-07 12:02:00 +02:00
Bertocq
a9c928505d Fix indentation on annotator overrides scss file 2017-07-06 15:56:51 +02:00
Bertocq
631f396e75 Fix dev_seeds to comply with budget related uniqueness names 2017-07-06 11:16:53 +02:00
BertoCQ
e8e6eff679 Merge pull request #1718 from consul/migrate_locales
Migrate localization files & Prepare Crowdin
2017-07-05 14:29:45 +02:00
Bertocq
f58f033e1d Move existing translations into new folder structure with help of rake task 2017-07-05 13:31:50 +02:00
Bertocq
0740c3bc26 Add rake task to help migrate existing locale files to new structure 2017-07-05 13:30:05 +02:00
Bertocq
6f01db0245 Update customization guides to reflect new localization files structure 2017-07-05 13:30:05 +02:00
Bertocq
8fc2692f69 Add crowding config 2017-07-05 13:30:05 +02:00
Bertocq
355d65b998 Correct i18n tasks config file with new folder pattern, remove Spanish from i18n-task specs 2017-07-05 13:30:05 +02:00
Bertocq
552661f0e4 Add to i18n load path files in nested folders 2017-07-05 13:30:05 +02:00
BertoCQ
e990568895 Merge pull request #1721 from consul/feature/add_slugs_to_budget_related
Add slugs to budget related
2017-07-05 13:16:24 +02:00
BertoCQ
c439454ec7 Merge pull request #1722 from consul/chore/rubocop_cleaning
Rubocop cleaning
2017-07-05 13:12:09 +02:00
BertoCQ
48cc2f03a2 Merge pull request #1724 from consul/feature/add_investment_selected_checbox
Add investment selected checbox & improve view
2017-07-05 13:11:48 +02:00
Bertocq
512059e021 Increase Budget, Heading and Group model specs to cover slug uniqueness
Why:

* Slug must be unique among:
 1. Budget slug: among other budgets
 2. Group slug: among other groups from its budget
 3. Heading slug: among other headings from all the groups from its budget

How:

* Adding checks for all possible scenarios on each model specs
2017-07-05 12:33:17 +02:00
Bertocq
4068e50b33 Create rake task to generate slug for objects that use Sluggable concern
Why:

* Once slug presence validation and usage is merged on to a code base, existing objects without it will become invalid and unusable

How:

* Running `bundle exec slugs:gnerate` will look for all models that include the concern, and generate a slug for each object
2017-07-05 12:33:17 +02:00
Bertocq
e3d89261a6 Add Sluggable concern and unique validation to Budget, Group and Heading
* What: We need to generate slug on Budget, Group and Heading classes, validating its unique for its scope

* How: Adding a presence and unique validation using Budget always as scope.
2017-07-05 12:33:16 +02:00
Bertocq
4a5a164925 Ignore Style/SymbolProc rubocop cop, no strong preferences for it 2017-07-05 11:56:44 +02:00
Bertocq
2888c20489 Fix all Style/RedundantSelf rubocop issues 2017-07-05 11:55:52 +02:00
Bertocq
97d7a21791 Fix all Style/RedundantReturn rubocop issues 2017-07-05 11:55:52 +02:00
Bertocq
29b58298db Fix Style/NegatedIf rubocop issue 2017-07-05 11:55:52 +02:00
Bertocq
343da2d58e Improve admin investment view with selection/compatibility/winner flags on top 2017-07-05 11:26:59 +02:00
Bertocq
16f295ea0b Fix english translation for Heading, typo from Spanish 2017-07-04 23:54:04 +02:00