Bertocq
679cf3943e
Update Deprecated section of Unreleased at Changelog file
2018-01-31 01:11:18 +01:00
Bertocq
09aa5a17cf
Add rake task to migrate investment's internal comments to thread
2018-01-31 01:11:15 +01:00
Bertocq
767fd04bdf
Add valuation comments relation at Budget Investment
...
Why:
Budget Investments already has an existing `comments` relation that is
on use. We need to keep that relation unaltered after adding the
internal valuation comments, that means scoping the relation to only
public comments (non valuation ones) so existing code using it will
remain working as expected.
A new second relation will be needed to explicitly ask for valuation
comments only where needed, again scoping to valuation comments.
How:
Adding a second `valuations` relationship and filtering on both
with the new `valuation` flag from Comment model.
2018-01-30 19:22:27 +01:00
Bertocq
56fc5c9583
Filter internal valuation comments from public api
...
Why:
Internal valuation comments are only for admins and valuators,
not for the public view.
How:
Adding a `not_valuations` scope and use it at the `public_for_api` one
2018-01-30 19:22:27 +01:00
Bertocq
c84b2f0704
Add valuation boolean flag to Comment model
...
Why:
Budget Investment's valuators need to be able to comment on investments
without making those comments public. We need a way to clearly make a
distinction to avoid "leaking" internal valuation comments.
How:
Adding a boolean `valuation` attribute defaulted to false to the Comments
table, and index on it with concurrent algorithm as explained at
https://robots.thoughtbot.com/how-to-create-postgres-indexes-concurrently-in
The name `valuation` was chosen instead of `internal` because of the more
specific meaning as well as avoiding a collision with existing internal_comments
attribute on Budget::Investment model (soon to be deprecated & removed)
2018-01-30 19:22:27 +01:00
BertoCQ
e0e67c959b
Merge pull request #2397 from consul/hide_order_selector_if_only_one_order
...
Hide order selectors when only one order available
2018-01-30 19:20:28 +01:00
decabeza
42d0f471ee
Updates i18n keys and images folder
2018-01-30 19:10:48 +01:00
decabeza
fc89c899cc
Updates help url example on seeds
2018-01-30 18:28:05 +01:00
decabeza
f92664331d
Changes .more-information class to .help
2018-01-30 18:27:43 +01:00
decabeza
286371c9d9
Changes more_info folder and path to help
2018-01-30 18:26:30 +01:00
decabeza
a958a75bb1
Updates text of polls section of more info page
2018-01-30 18:13:24 +01:00
decabeza
037a3af5a6
Updates text of budgets section of more info page
2018-01-30 18:12:48 +01:00
decabeza
fffc769c90
Updates text of proposals section of more info page
2018-01-30 18:12:21 +01:00
decabeza
59a02301c2
Updates text of debates section of more info page
2018-01-30 18:11:50 +01:00
decabeza
735630cff0
Updates text of intro section of more info page
2018-01-30 18:11:13 +01:00
decabeza
213152349b
Changes more info link to help
2018-01-30 18:10:42 +01:00
Bertocq
e5ce55b1cd
Hide order selectors when only one order available
2018-01-30 17:03:17 +01:00
Raimond Garcia
e1b7c7aa32
Merge pull request #2398 from wairbut-m2c/aperez-fix-investments-table
...
Fix: Admin investments table not showing up properly
2018-01-30 12:18:47 +01:00
Bertocq
345d513342
Remove unnecesary feature flag setting at spec
2018-01-30 12:13:01 +01:00
Bertocq
b3e7f8a78f
Remove no longer neccesary feature flags from valuation feature spec
2018-01-30 12:10:15 +01:00
Bertocq
ffe7d4baad
Fix rubocop issues at dev seeds
2018-01-30 03:31:41 +01:00
Bertocq
a4fb568654
Improve dev seeds comments adding them to investments
2018-01-30 03:29:20 +01:00
Bertocq
093b191f16
Small rubocop autocorrections
2018-01-30 03:07:52 +01:00
Bertocq
04d5a83031
Improve Budget's index feature spec scenarios
2018-01-30 03:01:44 +01:00
BertoCQ
dab1562132
Merge pull request #2369 from consul/fix_finished_budgets_list
...
Correctly show finished budgets at budget index
2018-01-30 02:25:06 +01:00
Angel Perez
2cee29d883
Fix: Admin investments table not showing up properly
2018-01-29 18:34:15 -04:00
Bertocq
d280c254c8
Remove usage of Investment's internal_comments attr
2018-01-29 21:15:28 +01:00
Raimond Garcia
b5cb5e2563
Merge pull request #2387 from wairbut-m2c/show_only_current_budget_tags_in_admin_budget
...
Show only current budget tags in admin budget
2018-01-29 20:14:10 +01:00
Raimond Garcia
626b9972d1
Merge pull request #2378 from wairbut-m2c/aperez-investments-search
...
Add search & sorting options to Admin::BudgetInvestments
2018-01-29 20:06:43 +01:00
decabeza
e1e80c3cc9
adds specs
2018-01-29 17:21:42 +01:00
Sergio Castellano Herrera
2905b24ee7
Error to access hide comments
2018-01-29 16:48:48 +01:00
Sergio Castellano Herrera
54753fece4
Error to access hide comments
2018-01-29 16:48:40 +01:00
Alberto García
1207b5ce51
Merge pull request #2279 from wairbut-m2c/aperez-missing-i18n-keys
...
I18n maintenance
2018-01-29 14:02:15 +01:00
BertoCQ
afb1c5da4b
Merge pull request #2393 from consul/paperclip_upgrade
...
Upgrade Paperclip to 5.2.1 for security reasons
2018-01-29 12:04:17 +01:00
Bertocq
4874090799
Update Security section of unreleased at Changelog.md
2018-01-29 11:36:22 +01:00
Bertocq
75a68e8439
Upgrade Paperclip to 5.2.1 for security reasons
2018-01-29 11:08:46 +01:00
Angel Perez
665a5b57ab
Empty instances of MapLocation won't result in a new DB record ( #2220 )
2018-01-26 09:26:48 -04:00
Angel Perez
88a5e8b1d2
Spec: Admins/users can destroy only their authored documentables/imageables ( #2375 )
2018-01-26 09:10:58 -04:00
Bertocq
6d3359dbbc
Fix bad line break
2018-01-26 12:01:22 +01:00
Vicente Mendoza
45a86d0db8
Added test to verify that the search of the tags is only from the current budget
2018-01-26 11:31:14 +01:00
Vicente Mendoza
ff5112f96b
Changed the budgets helper so just search for the current budget
2018-01-26 11:30:02 +01:00
Bertocq
5e583d2015
Increase notifiable access security on add notification method
2018-01-26 11:24:13 +01:00
Bertocq
f4ad0b2979
Improve add_notification logic to add notificable author
2018-01-26 00:33:07 +01:00
Bertocq
070c94494e
Fix linelenght over 100 on multiple files
2018-01-26 00:27:03 +01:00
Bertocq
34b2a27357
Cleanup indentation and line lenght aat order select partial
2018-01-25 18:06:36 +01:00
Bertocq
9b2aebc8c2
Remove closing </li>'s without opening <li>
2018-01-25 17:54:15 +01:00
iagirre
b3dec1897e
Feature spec to test that the budget_investment is not been deleted if the user dismisses the confirm dialog
2018-01-25 16:54:26 +01:00
iagirre
f2927c8eb2
Add alert to the delete button of 'My activity' section so that users don't delete their investmentes accidentally
2018-01-25 16:54:26 +01:00
Alberto García
6918bd699c
Merge pull request #2384 from consul/fix-texts
...
Fix i18n texts
2018-01-25 16:09:36 +01:00
decabeza
f06ef1ac91
updates spanish translations of budgets
2018-01-25 14:41:16 +01:00
