Don't define controller actions in helpers

2019-11-02 00:54:22 +01:00
parent 6f4dc11dc4
commit 3f3fe9a3d3
2 changed files with 5 additions and 7 deletions
--- a/app/controllers/admin/budget_investments_controller.rb
+++ b/app/controllers/admin/budget_investments_controller.rb
@@ -2,7 +2,6 @@ class Admin::BudgetInvestmentsController < Admin::BaseController
  include FeatureFlags
  include CommentableActions
  include DownloadSettingsHelper
-  include ChangeLogHelper
  include Translatable

  feature_flag :budgets
@@ -62,6 +61,11 @@ class Admin::BudgetInvestmentsController < Admin::BaseController
    load_investments
  end

+  def show_investment_log
+    @log = Budget::Investment::ChangeLog.find_by(id: params[:id])
+    render "admin/change_logs/show"
+  end
+
  private

    def load_comments
--- a/app/helpers/change_log_helper.rb
+++ b/app/helpers/change_log_helper.rb
@@ -1,6 +0,0 @@
-module ChangeLogHelper
-  def show_investment_log
-    @log = Budget::Investment::ChangeLog.find_by(id: params[:id])
-    render "admin/change_logs/show"
-  end
-end