From 3f3fe9a3d3532f9b2fe7d0f4d1907220c2bd5243 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Sat, 2 Nov 2019 00:54:22 +0100
Subject: [PATCH] Don't define controller actions in helpers

---
 app/controllers/admin/budget_investments_controller.rb | 6 +++++-
 app/helpers/change_log_helper.rb                       | 6 ------
 2 files changed, 5 insertions(+), 7 deletions(-)
 delete mode 100644 app/helpers/change_log_helper.rb

diff --git a/app/controllers/admin/budget_investments_controller.rb b/app/controllers/admin/budget_investments_controller.rb
index 78fcfc806..a9639ccb1 100644
--- a/app/controllers/admin/budget_investments_controller.rb
+++ b/app/controllers/admin/budget_investments_controller.rb
@@ -2,7 +2,6 @@ class Admin::BudgetInvestmentsController < Admin::BaseController
   include FeatureFlags
   include CommentableActions
   include DownloadSettingsHelper
-  include ChangeLogHelper
   include Translatable
 
   feature_flag :budgets
@@ -62,6 +61,11 @@ class Admin::BudgetInvestmentsController < Admin::BaseController
     load_investments
   end
 
+  def show_investment_log
+    @log = Budget::Investment::ChangeLog.find_by(id: params[:id])
+    render "admin/change_logs/show"
+  end
+
   private
 
     def load_comments
diff --git a/app/helpers/change_log_helper.rb b/app/helpers/change_log_helper.rb
deleted file mode 100644
index f6bea8c3f..000000000
--- a/app/helpers/change_log_helper.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-module ChangeLogHelper
-  def show_investment_log
-    @log = Budget::Investment::ChangeLog.find_by(id: params[:id])
-    render "admin/change_logs/show"
-  end
-end