consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify navigation in custom images tests

Browse Source 
IMHO testing the navigation once is enough. In the rest of the tests we
can access the page directly and make the tests faster by reducing the
number of requests.
This commit is contained in:
Javi Martín
2021-03-27 14:59:19 +01:00
parent 0fcb97a78f
commit 2965e45b64
1 changed files with 4 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
spec/system/admin/site_customization/images_spec.rb
View File

@@ -18,11 +18,7 @@ describe "Admin custom images", :admin do
end
scenario "Upload valid jpg image" do
visit admin_root_path
within("#side_menu") do
click_link "Custom images"
end
visit admin_site_customization_images_path
within("tr#image_map") do
attach_file "site_customization_image_image", "spec/fixtures/files/custom_map.jpg"
@@ -36,11 +32,8 @@ describe "Admin custom images", :admin do
scenario "Image is replaced on front views" do
budget = create(:budget)
group = create(:budget_group, budget: budget)
visit admin_root_path
within("#side_menu") do
click_link "Custom images"
end
visit admin_site_customization_images_path
within("tr#image_map") do
attach_file "site_customization_image_image", "spec/fixtures/files/custom_map.jpg"
@@ -84,11 +77,7 @@ describe "Admin custom images", :admin do
end
scenario "Upload invalid image" do
visit admin_root_path
within("#side_menu") do
click_link "Custom images"
end
visit admin_site_customization_images_path
within("tr#image_social_media_icon") do
attach_file "site_customization_image_image", "spec/fixtures/files/logo_header.png"
@@ -100,11 +89,7 @@ describe "Admin custom images", :admin do
end
scenario "Delete image" do
visit admin_root_path
within("#side_menu") do
click_link "Custom images"
end
visit admin_site_customization_images_path
within("tr#image_social_media_icon") do
attach_file "site_customization_image_image", "spec/fixtures/files/social_media_icon.png"