From 2965e45b64ea2e8a98187f4be5dd1edf5338c603 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Sat, 27 Mar 2021 14:59:19 +0100
Subject: [PATCH] Simplify navigation in custom images tests

IMHO testing the navigation once is enough. In the rest of the tests we
can access the page directly and make the tests faster by reducing the
number of requests.
---
 .../admin/site_customization/images_spec.rb   | 23 ++++---------------
 1 file changed, 4 insertions(+), 19 deletions(-)

diff --git a/spec/system/admin/site_customization/images_spec.rb b/spec/system/admin/site_customization/images_spec.rb
index f98b3680f..389cb5f9d 100644
--- a/spec/system/admin/site_customization/images_spec.rb
+++ b/spec/system/admin/site_customization/images_spec.rb
@@ -18,11 +18,7 @@ describe "Admin custom images", :admin do
   end
 
   scenario "Upload valid jpg image" do
-    visit admin_root_path
-
-    within("#side_menu") do
-      click_link "Custom images"
-    end
+    visit admin_site_customization_images_path
 
     within("tr#image_map") do
       attach_file "site_customization_image_image", "spec/fixtures/files/custom_map.jpg"
@@ -36,11 +32,8 @@ describe "Admin custom images", :admin do
   scenario "Image is replaced on front views" do
     budget = create(:budget)
     group = create(:budget_group, budget: budget)
-    visit admin_root_path
 
-    within("#side_menu") do
-      click_link "Custom images"
-    end
+    visit admin_site_customization_images_path
 
     within("tr#image_map") do
       attach_file "site_customization_image_image", "spec/fixtures/files/custom_map.jpg"
@@ -84,11 +77,7 @@ describe "Admin custom images", :admin do
   end
 
   scenario "Upload invalid image" do
-    visit admin_root_path
-
-    within("#side_menu") do
-      click_link "Custom images"
-    end
+    visit admin_site_customization_images_path
 
     within("tr#image_social_media_icon") do
       attach_file "site_customization_image_image", "spec/fixtures/files/logo_header.png"
@@ -100,11 +89,7 @@ describe "Admin custom images", :admin do
   end
 
   scenario "Delete image" do
-    visit admin_root_path
-
-    within("#side_menu") do
-      click_link "Custom images"
-    end
+    visit admin_site_customization_images_path
 
     within("tr#image_social_media_icon") do
       attach_file "site_customization_image_image", "spec/fixtures/files/social_media_icon.png"