consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
5c81a70fa7080cc4d55b7c2525f0fc80f0bb6e7c
nairobi/spec/features
History
Javi Martín 5c81a70fa7 Use factory bot blocks to create complex data 
Having two questions, each of them with two comments, made the code hard
to follow.

Grouping the comments inside the block creating the questions makes it
easier to know which comment belongs to which question, even if the code
is still not 100% readable.

We also remove instance variables, which by the way used the same
variable name for two different things.
2019-09-30 16:43:10 +02:00
..
admin
Remove instance variables in RSpec
2019-09-30 16:43:10 +02:00
budget_polls
Remove isolated useless assignments
2019-09-25 12:43:44 +02:00
budgets
Declare local variables outside a block
2019-09-30 16:43:10 +02:00
comments
Remove instance variables in RSpec
2019-09-30 16:43:10 +02:00
dashboard
Remove unused variables following their parent
2019-09-30 15:47:13 +02:00
legislation
Use factory bot blocks to create complex data
2019-09-30 16:43:10 +02:00
management
Simplify creating ballot lines in specs
2019-09-30 14:10:44 +02:00
moderation
Remove instance variables in RSpec
2019-09-30 16:43:10 +02:00
officing
Remove instance variables in RSpec
2019-09-30 16:43:10 +02:00
polls
Split tests checking permissions to vote in a poll
2019-09-30 15:30:40 +02:00
site_customization
Remove isolated useless assignments
2019-09-25 12:43:44 +02:00
tags
Remove rest of unused variables
2019-09-30 15:47:13 +02:00
tracking
Remove instance variables in RSpec
2019-09-30 16:43:10 +02:00
valuation
Remove instance variables in RSpec
2019-09-30 16:43:10 +02:00
verification
Apply IndentationWidth rubocop rule
2019-09-10 20:02:15 +02:00
account_spec.rb
Remove instance variables in RSpec
2019-09-30 16:43:10 +02:00
admin_spec.rb
Simplify login for officer user in tests
2019-09-25 12:43:44 +02:00
banners_spec.rb
Use describe on feature tests
2019-05-28 16:36:54 +02:00
campaigns_spec.rb
Remove instance variables in RSpec
2019-09-30 16:43:10 +02:00
ckeditor_spec.rb
Fix debate specs
2019-06-27 09:19:36 +02:00
communities_spec.rb
Remove isolated useless assignments
2019-09-30 15:47:13 +02:00
debates_spec.rb
Remove isolated useless assignments
2019-09-30 15:47:13 +02:00
direct_messages_spec.rb
Remove unnecessary code
2019-09-24 18:49:40 +02:00
emails_spec.rb
Directly assign valuators in specs
2019-09-30 15:08:27 +02:00
help_page_spec.rb
Use describe on feature tests
2019-05-28 16:36:54 +02:00
home_spec.rb
Simplify creating follows in specs
2019-09-30 13:34:31 +02:00
localization_spec.rb
Let Globalize use I18n locale
2019-09-23 18:01:44 +02:00
management_spec.rb
Use describe on feature tests
2019-05-28 16:36:54 +02:00
moderation_spec.rb
Remove redundant setting resets in after blocks
2019-09-23 13:47:45 +02:00
notifications_spec.rb
Remove unused variables following their parent
2019-09-30 15:47:13 +02:00
official_positions_spec.rb
Remove instance variables in RSpec
2019-09-30 16:43:10 +02:00
officing_spec.rb
Remove isolated useless assignments
2019-09-25 12:43:44 +02:00
organizations_spec.rb
Use describe on feature tests
2019-05-28 16:36:54 +02:00
proposal_ballots_spec.rb
Apply rule to end files with a newline character
2019-09-10 20:02:15 +02:00
proposal_notifications_spec.rb
Simplify creating follows in specs
2019-09-30 13:34:31 +02:00
proposals_spec.rb
Check texts from the user's point of view
2019-09-30 14:29:15 +02:00
registration_form_spec.rb
Use describe on feature tests
2019-05-28 16:36:54 +02:00
remote_translations_spec.rb
Remove redundant I18n resets in after blocks
2019-09-23 13:47:45 +02:00
sessions_spec.rb
Apply rule to end files with a newline character
2019-09-10 20:02:15 +02:00
social_media_meta_tags_spec.rb
Remove redundant setting resets in after blocks
2019-09-23 13:47:45 +02:00
stats_spec.rb
Simplify creating voters in specs
2019-09-30 00:36:40 +02:00
tags_spec.rb
Remove isolated useless assignments
2019-09-25 12:43:44 +02:00
topics_spec.rb
Simplify creating a topic with a community
2019-09-30 14:10:46 +02:00
tracks_spec.rb
Apply IndentationWidth rubocop rule
2019-09-10 20:02:15 +02:00
translatable_spec.rb
Simplify translatable tests in the public area
2019-09-23 18:01:44 +02:00
user_invites_spec.rb
Apply rule to end files with a newline character
2019-09-10 20:02:15 +02:00
users_auth_spec.rb
Add rubocop spacing rules
2019-09-10 21:04:56 +02:00
users_spec.rb
Remove instance variables in RSpec
2019-09-30 16:43:10 +02:00
valuation_spec.rb
Use describe on feature tests
2019-05-28 16:36:54 +02:00
votes_spec.rb
Remove instance variables in RSpec
2019-09-30 16:43:10 +02:00
welcome_spec.rb
Remove redundant setting resets in after blocks
2019-09-23 13:47:45 +02:00