Javi Martín 5c81a70fa7 Use factory bot blocks to create complex data ...

Having two questions, each of them with two comments, made the code hard
to follow.

Grouping the comments inside the block creating the questions makes it
easier to know which comment belongs to which question, even if the code
is still not 100% readable.

We also remove instance variables, which by the way used the same
variable name for two different things.

2019-09-30 16:43:10 +02:00

..

controllers

Remove instance variables in RSpec

2019-09-30 16:43:10 +02:00

factories

Rename unfinished trait to open

2019-09-30 15:30:40 +02:00

features

Use factory bot blocks to create complex data

2019-09-30 16:43:10 +02:00

fixtures/files

Add local_census_records importation model

2019-07-29 13:07:24 +02:00

helpers

Simplify testing arrays exact contents

2019-09-29 23:24:53 +02:00

lib

Remove instance variables in RSpec

2019-09-30 16:43:10 +02:00

mailers

Apply explict RSpec/DescribedClass rubocop rule

2019-09-23 16:51:00 +02:00

models

Avoid unused variables in notification spec

2019-09-30 15:47:13 +02:00

requests/dashboard

Remove unused variables

2019-09-29 22:31:13 +02:00

shared

Simplify creating follows in specs

2019-09-30 13:34:31 +02:00

support

Use title in specs add_to_ballot method

2019-09-30 14:29:15 +02:00

views/welcome

Add rubocop spacing rules

2019-09-10 21:04:56 +02:00

customization_engine_spec.rb

Change single quotes to double quotes

2019-02-15 11:40:39 +01:00

i18n_spec.rb

Add rubocop spacing rules

2019-09-10 21:04:56 +02:00

rails_helper.rb

Merge pull request #3537 from PierreMesure/set-locales-in-test-environment

2019-09-11 18:43:03 +02:00

sessions_helper.rb

use Capybara.using_session method for multiple browsers specs

2018-12-02 18:12:30 +01:00

spec_helper.rb

Let Globalize use I18n locale

2019-09-23 18:01:44 +02:00