45851c74bd
For reasons that might or might not affect production installations, the test checking simultaneous requests to create poll voters in the officing voters controller wasn't behaving as expected. The expected behavior, since commit9a8bfac5b, is that the second request reaching the `with_lock` part of the code waits for the first request to finish and so this second request raises an `ActiveRecord::RecordInvalid` exception when trying to save a voter with the same poll and the same user as the first one. However, 95% of the time that wasn't the case. Instead, when entering the `@user.with_lock` block, the second request would replace its `@voter` object with the `@voter` object saved in the same request, so the second call to `save!` would succeed as it would simply update the existing record. This is a behavior that we could accept if it were consistent and happened 100% of the time, but that isn't the case. 5% of the time, we do get the `ActiveRecord::RecordInvalid` exception. So 5% of the time we got a failure in the test: ``` 1) Officing::VotersController POST create does not create two records with two simultaneous requests Failure/Error: @user.with_lock { @voter.save! } ActiveRecord::RecordInvalid: Validation failed: User User has already voted # ./app/controllers/officing/voters_controller.rb:25:in `block in create' # ./app/controllers/officing/voters_controller.rb:25:in `create' # ./app/controllers/application_controller.rb:50:in `switch_locale' # ./spec/controllers/officing/voters_controller_spec.rb:15:in `block (5 levels) in <top (required)>' ``` So we're changing the `with_lock` block so it includes the initialization of the object. This way, we get the `ActiveRecord::RecordInvalid` exception 100% of the time. Note that in commit9a8bfac5bwe also rescued the `ActionDispatch::IllegalStateError` exceptions. I'm not why we were getting those exceptions when running the tests, and I'm not sure whether we keep getting after these changes, but it doesn't really matter. The reason is that in Consul Democracy 2.3.0 we're going to add a unique index to the `poll_voters` table, which (according to the tests done in the past) will make both the `@user.lock` block and rescuing the `ActionDispatch::IllegalStateError` unnecessary. So, in other words, these changes will never make it to production because this part of the code will be changed again before releasing version 2.3.0.
CONSUL DEMOCRACY
Citizen Participation and Open Government Application
This is the opensource code repository of the eParticipation website CONSUL DEMOCRACY, originally developed for the Madrid City government eParticipation website, and currently maintained by the open source software community in collaboration with the CONSUL DEMOCRACY Foundation.
Documentation
Check the ongoing documentation to learn more about how to start your own CONSUL DEMOCRACY fork, install it, customize it and learn to use it as an administrator/maintainer.
CONSUL DEMOCRACY Foundation and project website
You can access the main website of the project at http://consuldemocracy.org where you can find information about the use of the platform, the CONSUL DEMOCRACY Foundation, the global community of users and local partners, news, and ways to get more support or get in touch.
Configuration for development and test environments
NOTE: For more detailed instructions, check the local installation docs.
Prerequisites: install git, Ruby 3.2.5, CMake, pkg-config, Node.js 18.20.3, ImageMagick and PostgreSQL (>=9.5).
Note: The bin/setup command below might fail if you've configured a username and password for PostgreSQL. If that's the case, edit the lines containing username: and password: (adding your credentials) in the config/database.yml file and run bin/setup again.
git clone https://github.com/consuldemocracy/consuldemocracy.git
cd consuldemocracy
bin/setup
bin/rake db:dev_seed
Run the app locally:
bin/rails s
You can run the tests with:
bin/rspec
Note: running the whole test suite on your machine might take more than an hour, so it's strongly recommended that you setup a Continuous Integration system in order to run them using parallel jobs every time you open or modify a pull request (if you use GitHub Actions or GitLab CI, this is already configured in .github/workflows/tests.yml and .gitlab-ci.yml) and only run tests related to your current task while developing on your machine. When you configure the application for the first time, it's recommended that you run at least one test in spec/models/ and one test in spec/system/ to check your machine is properly configured to run the tests.
You can use the default admin user from the seeds file:
user: admin@consul.dev pass: 12345678
But for some actions like voting, you will need a verified user, the seeds file also includes one:
user: verified@consul.dev pass: 12345678
Configuration for production environments
See installer
Current state
Development started on 2015 July 15th. Code was deployed to production on 2015 september 7th to decide.madrid.es. Since then new features are added often. You can take a look at the current features at the project's website and future features at the Roadmap and open issues list.
License
Code published under AFFERO GPL v3 (see LICENSE-AGPLv3.txt)
Contributions
See CONTRIBUTING.md