consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
3b11f8b567040be9af9e2a07632e7370c5e21bb6
nairobi/spec/models
History
Javi Martín 3b11f8b567 Avoid duplicate records in current_or_recounting 
Joining two scopes with `+` does not remove duplicate records. Luckily
now that we've upgraded to Rails 5, we can join scopes using `.or`.

The test was testing for the presence of elements, bud didn't test for
duplicate records. Testing the exact contents of the array revealed this
behaviour.
2019-09-26 19:58:02 +02:00
..
abilities
Use budget phase traits
2019-09-24 21:34:06 +02:00
ahoy
Apply explict RSpec/DescribedClass rubocop rule
2019-09-23 16:51:00 +02:00
budget
Add a test for an edge case calculating winners
2019-09-25 15:24:59 +02:00
concerns
Add globalizable tests for all translatable models
2019-09-23 18:01:44 +02:00
custom
Simplify testing array contents
2019-09-24 21:32:52 +02:00
dashboard
Apply explict RSpec/DescribedClass rubocop rule
2019-09-23 16:51:00 +02:00
legislation
Remove isolated useless assignments
2019-09-25 12:43:44 +02:00
local_census_records
Add local_census_records importation model
2019-07-29 13:07:24 +02:00
milestone
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
officing
Check arrays are empty instead of size 0
2019-09-24 21:32:28 +02:00
poll
Avoid duplicate records in current_or_recounting
2019-09-26 19:58:02 +02:00
site_customization
Add globalizable tests for all translatable models
2019-09-23 18:01:44 +02:00
verification
Check arrays are empty instead of size 0
2019-09-24 21:32:28 +02:00
widget
Add globalizable tests for all translatable models
2019-09-23 18:01:44 +02:00
activity_spec.rb
Simplify testing array contents
2019-09-24 21:32:52 +02:00
admin_notification_spec.rb
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
administrator_spec.rb
Add rubocop spacing rules
2019-09-10 21:04:56 +02:00
banner_spec.rb
Add globalizable tests for all translatable models
2019-09-23 18:01:44 +02:00
budget_spec.rb
Use budget phase traits
2019-09-24 21:34:06 +02:00
comment_spec.rb
Simplify testing array contents
2019-09-24 21:32:52 +02:00
community_spec.rb
Simplify testing array contents
2019-09-24 21:32:52 +02:00
debate_spec.rb
Remove isolated data creation useless assignments
2019-09-25 12:43:44 +02:00
direct_message_spec.rb
Remove isolated useless assignments
2019-09-25 12:43:44 +02:00
direct_upload_spec.rb
Apply rule to end files with a newline character
2019-09-10 20:02:15 +02:00
document_spec.rb
Simplify testing array contents
2019-09-24 21:32:52 +02:00
flag_spec.rb
Apply explict RSpec/DescribedClass rubocop rule
2019-09-23 16:51:00 +02:00
follow_spec.rb
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
geozone_spec.rb
Delete spending proposals
2019-05-31 18:22:59 +02:00
i18n_content_spec.rb
Remove useless assignment in i18n content spec
2019-09-25 12:43:44 +02:00
identity_spec.rb
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
image_spec.rb
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
link_spec.rb
Fix more hound warnings
2019-03-27 15:22:14 +01:00
local_census_record_spec.rb
Add uniqueness validation to document_number and document_type pair
2019-07-29 13:07:24 +02:00
lock_spec.rb
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
map_location_spec.rb
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
milestone_spec.rb
Add globalizable tests for all translatable models
2019-09-23 18:01:44 +02:00
newsletter_spec.rb
Simplify tests checking for invalid email
2019-09-25 12:43:44 +02:00
notification_spec.rb
Simplify testing array contents
2019-09-24 21:32:52 +02:00
organization_spec.rb
Simplify testing array contents
2019-09-24 21:32:52 +02:00
progress_bar_spec.rb
Add globalizable tests for all translatable models
2019-09-23 18:01:44 +02:00
proposal_notification_spec.rb
Remove isolated useless assignments
2019-09-25 12:43:44 +02:00
proposal_spec.rb
Simplify testing array contents
2019-09-24 21:32:52 +02:00
related_content_spec.rb
Simplify testing array contents
2019-09-24 21:32:52 +02:00
remote_translation_spec.rb
Simplify tests using delayed_job
2019-09-23 13:47:45 +02:00
setting_spec.rb
Apply explict RSpec/DescribedClass rubocop rule
2019-09-23 16:51:00 +02:00
signature_sheet_spec.rb
Remove redundant setting resets in after blocks
2019-09-23 13:47:45 +02:00
signature_spec.rb
Remove unnecessary code
2019-09-24 18:49:40 +02:00
statisticable_spec.rb
Include no geozone in no demographic data
2019-05-21 13:50:18 +02:00
stats_version_spec.rb
Add table to store stats versions
2019-05-21 13:50:19 +02:00
tag_cloud_spec.rb
Apply explict RSpec/DescribedClass rubocop rule
2019-09-23 16:51:00 +02:00
tag_spec.rb
Fix tests for uppercase tags
2019-09-07 16:43:41 +02:00
topic_spec.rb
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
user_spec.rb
Simplify testing array contents
2019-09-24 21:32:52 +02:00
valuator_group_spec.rb
Apply RSpec/ExampleWording rubocop rule
2019-09-10 21:43:39 +02:00
valuator_spec.rb
Fix extra nil added to assigned investment IDs
2019-09-26 19:58:02 +02:00
vote_spec.rb
Apply explict RSpec/DescribedClass rubocop rule
2019-09-23 16:51:00 +02:00