consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify tests checking for invalid email

Browse Source 
We also remove useless assignments, and use a neutral email address in
the sample data.
This commit is contained in:
Javi Martín
2019-09-23 23:44:36 +02:00
parent ee0031ccb3
commit 5fa155ceda
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/models/newsletter_spec.rb
View File

@@ -127,17 +127,13 @@ describe Newsletter do
it "skips invalid emails" do
Proposal.destroy_all
valid_email = "john@gmail.com"
invalid_email = "john@gmail..com"
valid_email_user = create(:user, :with_proposal, email: valid_email)
invalid_email_user = create(:user, :with_proposal, email: invalid_email)
create(:user, :with_proposal, email: "valid@consul.dev")
create(:user, :with_proposal, email: "invalid@consul..dev")
newsletter.deliver
expect(Activity.count).to eq(1)
expect(Activity.first.user_id).to eq(valid_email_user.id)
expect(Activity.first.user.email).to eq("valid@consul.dev")
expect(Activity.first.action).to eq("email")
expect(Activity.first.actionable).to eq(newsletter)
end