consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,448 Commits 1 Branch 0 Tags
f722caac242e20c62fbaaece9af632f39feae13c
Commit Graph

8448 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bertocq
3509bfe3e4 Remove spending proposals from sitemap and its test, deprecated model 2018-01-07 15:38:44 +01:00
Bertocq
cdbf0a77e1 Improve consul.json request spec, to avoid maintaining the setting features list up with seeds.rb content 2018-01-07 15:24:46 +01:00
Bertocq
ea34aa4c4b Thank depfu free service for multiple gem ver updates on changelog 2018-01-07 13:26:26 +01:00
Bertocq
7249eb27e3 Update changelog release list 2018-01-07 13:20:12 +01:00
BertoCQ
6e4fcfb469 Merge pull request #2271 from consul/depfu/update/bullet-5.7.1 
Update bullet: 5.7.0 → 5.7.1 (patch)
 2018-01-07 12:58:38 +01:00
Bertocq
0ecfbfe55c Fix capistrano version lock on deploy.rb script to same on Gemfile 2018-01-07 12:51:42 +01:00
BertoCQ
c0708592c9 Merge pull request #2266 from consul/depfu/upgrade/cancancan-2.1.2 
Upgrade cancancan: 1.16.0 → 2.1.2 (major)
 2018-01-07 12:34:49 +01:00
BertoCQ
6f9323e5c8 Merge pull request #2265 from consul/depfu/upgrade/acts-as-taggable-on-5.0.0 
Upgrade acts-as-taggable-on: 4.0.0 → 5.0.0 (major)
 2018-01-07 12:18:29 +01:00
depfu[bot]
2847bca32d Update bullet to version 5.7.1 2018-01-07 11:05:23 +00:00
depfu[bot]
f87f8b6857 Upgrade cancancan to version 2.1.2 2018-01-07 11:53:16 +01:00
Bertocq
e3aa1131a1 Update changelog unreleased section with rubocop changes 2018-01-07 11:30:39 +01:00
BertoCQ
abfa203f5c Merge pull request #2249 from wairbut-m2c/aperez-sitemap-specs 
Specs for valid sitemap generation
 2018-01-07 11:24:43 +01:00
BertoCQ
5b0315c1e2 Merge pull request #2263 from consul/depfu/upgrade/ancestry-3.0.1 
Upgrade ancestry: 2.2.2 → 3.0.1 (major)
 2018-01-07 11:09:21 +01:00
BertoCQ
6e7631d229 Merge pull request #2267 from consul/depfu/upgrade/sitemap_generator-6.0.0 
Upgrade sitemap_generator: 5.3.1 → 6.0.0 (major)
 2018-01-07 11:07:24 +01:00
depfu[bot]
1754bfa9af Upgrade sitemap_generator to version 6.0.0 2018-01-07 10:05:51 +00:00
BertoCQ
d6b47234ec Merge pull request #2269 from consul/depfu/upgrade/social-share-button-1.1.0 
Upgrade social-share-button: 0.10.0 → 1.1.0 (major)
 2018-01-07 11:04:07 +01:00
depfu[bot]
ca266dda91 Upgrade social-share-button to version 1.1.0 2018-01-07 02:05:24 +00:00
Bertocq
3e5b13ae4d Enable RSpec/LetBeforeExamples cop & fix issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetBeforeExamples
 2018-01-07 02:28:06 +01:00
Bertocq
4bb75c3a11 Enable RSpec/LeadingSubject cop without issues 2018-01-07 02:26:40 +01:00
Bertocq
eaf66e3ec1 Enable RSpec/IteratedExpectation cop and fix issues 
Suggested refactor is only available for `.to` and not for `.not_to` :(

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IteratedExpectation
 2018-01-07 02:24:24 +01:00
Bertocq
77e6e33d35 Enable RSpec/ItBehavesLike cop without issues 2018-01-07 02:20:34 +01:00
Bertocq
54cd57de9b Enable RSpec/InvalidPredicateMatcher without issues 2018-01-07 02:19:23 +01:00
Bertocq
473e3d6466 Disable RSpec/InstanceVariable as we have 868 offenses for it 2018-01-07 02:15:43 +01:00
Bertocq
bf75b50b2f Enable RSpec/InstanceSpy cop without issues 2018-01-07 02:14:04 +01:00
Bertocq
ae04a76221 Enable RSpec/ImplicitExpect cop with convention 
Used `EnforcedStyle: should` config as there is no `is_expected.to` usage on the codebase.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ImplicitExpect
 2018-01-07 02:11:51 +01:00
Bertocq
1441de5107 Enable RSpec/HookArgument cop and fix issues 
To be consistent about before/after arguments, as `:each` or `:example`
 are same and default scopes, best not to send an argument in those
 scenarios.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
 2018-01-07 02:07:19 +01:00
Bertocq
39b01b6342 Enable RSpec/Focus cop without issues 2018-01-07 02:07:02 +01:00
Bertocq
95733f52f2 Enable RSpec/FilePath cop and fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FilePath
 2018-01-07 02:05:10 +01:00
Bertocq
0f37239ac3 Enable Expect In Hook and Output rubocop rspec cops 2018-01-07 02:04:43 +01:00
Bertocq
97c5490995 Fix unnecesary spacing 2018-01-07 01:58:45 +01:00
Bertocq
f6aed3f9f1 Enable RSpec/ExpectActual cop and fix all issues 
Always use a variable and not a literal as `expect` argument

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectActual
 2018-01-07 01:55:38 +01:00
Bertocq
0698043340 Fix indentations 2018-01-07 01:06:07 +01:00
Bertocq
ed16a78f42 Enables RSpec/ExampleWording and fixes all issues 
Both avoiding 'should' and repiting 'it' on the tests description
improves reading them and also makes all descriptions consistent.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
 2018-01-07 01:03:45 +01:00
Bertocq
971f2e308a Disables example length rubocop rspec cop, metrics always hard to meet 2018-01-07 00:53:08 +01:00
Bertocq
2253155a51 Enables RSpec/EmptyLineAfterSubject & fixes all issues 
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterSubject
 2018-01-07 00:50:50 +01:00
Bertocq
fa017b664f Enables RSpec/EmptyLineAfterFinalLet cop & fixes all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterFinalLet
 2018-01-07 00:49:37 +01:00
Bertocq
265d4d0967 Enables RSpec/DescribedClass cop & fixes all issues 
Autocorrection for existing issues, and stashing at .rubocop_todo.yml
the false positives

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribedClass
 2018-01-07 00:38:19 +01:00
depfu[bot]
53f854307a Upgrade acts-as-taggable-on to version 5.0.0 2018-01-06 23:20:58 +00:00
Bertocq
0c3dc56650 Enable both DescribeMethod and DescribeSymbol cops, without issues 2018-01-07 00:20:55 +01:00
Bertocq
6ec6f64675 Enable RSpec/DescribeClass rubocop rspec cop & fix issues 
Manually fixes all issues & "stashed" false positives at .rubocop_todo.yml

Read about the cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribeClass
 2018-01-07 00:20:55 +01:00
Bertocq
61be1015dd Explicitly disable rubocop-rspec cops until we can debate about it 2018-01-07 00:20:55 +01:00
BertoCQ
bb6209136c Merge pull request #2259 from consul/depfu/upgrade/whenever-0.10.0 
Upgrade whenever: 0.9.7 → 0.10.0 (minor)
 2018-01-07 00:00:28 +01:00
depfu[bot]
95eae89206 Upgrade ancestry to version 3.0.1 2018-01-06 22:55:27 +00:00
Bertocq
7f14544f71 Enable Capybara/CurrentPathExpectation cop & fix issues 
Read cop description http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation to better understand reasons behind enforcing this rule

On some cases the `only_path: true` was needed as argument of `have_current_path` matcher to avoid comparing the url parameters and just checking the path.
 2018-01-06 23:31:41 +01:00
depfu[bot]
9cae0eadda Upgrade whenever to version 0.10.0 2018-01-06 21:35:31 +00:00
BertoCQ
48c2df2463 Merge pull request #2260 from consul/depfu/update/rspec-rails-3.7.2 
Update rspec-rails: 3.6.1 → 3.7.2 (minor)
 2018-01-06 22:32:21 +01:00
BertoCQ
8256fc2641 Merge pull request #2258 from consul/depfu/upgrade/unicorn-5.4.0 
Upgrade unicorn: 5.3.0 → 5.4.0 (minor)
 2018-01-06 22:27:16 +01:00
depfu[bot]
242d028205 Update rspec-rails to version 3.7.2 2018-01-06 21:10:24 +00:00
Bertocq
4c7b2fcaa0 Update rubocop config with some rspec cops rules without issues 2018-01-06 21:19:03 +01:00
Bertocq
de2816a6a5 Enable RSpec/BeforeAfterAll rule and fix all issues 
This cop tries to avoid state leaking between examples. The fixes done on the code don't follow the suggested path, since the usage of `before(:all)` was not really useful. By using RSpec's `let` method we achieve same goals but with much better and readable tests.

Check Cop description at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeforeAfterAll
 2018-01-06 21:16:00 +01:00