consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,448 Commits 1 Branch 0 Tags
f722caac242e20c62fbaaece9af632f39feae13c
Commit Graph

8448 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
María Checa
385db76a24 Changed location attribute label text 2018-01-08 23:23:02 +01:00
María Checa
5161988844 Removed external_url input 2018-01-08 23:22:46 +01:00
Bertocq
4916f9a3c3 Avoid listing non-published Budgets to the public 
Why:

Non-admins shouldn't be aware of non-published Budgets

How:

Using the budget_published? helper method
 2018-01-08 23:02:18 +01:00
Bertocq
76e05d58b1 Return 404 status for non-published Budget access 
Why:

Non-admin users shouldn't be able to access, or know of the existence
of a non-published Budget.

How:

Raising an ActionController::RoutingError (404 error) to simulate the
same behaviour as accesing a non-existing Budget.

We could have used CanCanCan abilities for this but then an user could
be aware of existing but not published Budgets by trying different urls
 2018-01-08 22:59:20 +01:00
Bertocq
03f4fce2dd Add budget_published? helper method to BudgetHelper 
We need to check if the budget is in drafting phase to avoid showing
it to the users, unless the current user is an administrator.
 2018-01-08 22:56:47 +01:00
Bertocq
f9803ce9ca Add drafting phase to budget model & translations 2018-01-08 22:56:11 +01:00
Bertocq
d0937d7022 Add description_drafting column to budgets table 2018-01-08 22:55:37 +01:00
Bertocq
9739576e4e Add drafting phase trait to budget factory 2018-01-08 22:54:10 +01:00
Bertocq
1f0eb49ddc Increase budget model spec for drafting phase 2018-01-08 22:53:14 +01:00
Bertocq
63694b5bae Increase admin budget feature spec for drafting phase 2018-01-08 22:52:56 +01:00
Bertocq
2026f537e6 Add drafting phase scenario to budget feature spec for list & show checks 2018-01-08 22:51:01 +01:00
Bertocq
506293fc80 Move level two user creation to a shared let on budget feature 2018-01-08 19:59:14 +01:00
Bertocq
377a514128 Refactor commmon budget creation to a shared one at budget feature spec 2018-01-08 19:40:27 +01:00
Bertocq
4ca0a48df6 Reduce rubocop's Metrics/LineLength max to 100 chars by common agreement 2018-01-08 19:11:04 +01:00
Bertocq
03e1481fb1 Redirect admin to budget lists after editing a budget 2018-01-08 18:47:09 +01:00
Bertocq
53842ba919 Add Update scenario to admin budget feature spec 2018-01-08 18:46:50 +01:00
Raimond Garcia
05031dffa1 Merge pull request #2202 from wairbut-m2c/aperez-social-metatags 
Use 'image_url' properties to improve SEO for proposals & investments
 2018-01-08 18:33:07 +01:00
Bertocq
b1d685c4dc Add budget destroy texts for admin section 2018-01-08 18:21:46 +01:00
Bertocq
799b96cc40 Add destroy action to admin budget controller 2018-01-08 18:21:45 +01:00
Bertocq
dd3a0add2a Add destroy budget button to admin budget edit view 2018-01-08 17:48:46 +01:00
Bertocq
51e3d75c62 Add destroy scenario to budget section of admin panel 2018-01-08 17:48:06 +01:00
Raimond Garcia
bce0729a61 Merge pull request #1899 from xarlybovi/legislation-process-html-fixes 
Legislation process minor html fixes
 2018-01-08 16:00:26 +01:00
BertoCQ
c641aee605 Merge pull request #2273 from consul/depfu/update/uglifier-4.1.3 
Update uglifier: 4.1.2 → 4.1.3 (patch)
 2018-01-08 10:49:34 +01:00
depfu[bot]
205fd242d2 Update uglifier to version 4.1.3 2018-01-08 00:44:52 +01:00
Bertocq
581a6eb3ef Upgrade from factory_girl_rails to factory_bot_rails 
Guide at https://github.com/thoughtbot/factory_bot/blob/v4.9.0/UPGRADE_FROM_FACTORY_GIRL.md
 2018-01-07 23:32:37 +01:00
BertoCQ
fc1b4f4134 Merge pull request #2270 from consul/depfu/upgrade/uglifier-4.1.2 
Upgrade uglifier: 3.2.0 → 4.1.2 (major)
 2018-01-07 18:58:53 +01:00
Bertocq
4fc03fe395 Enable RSpec/VoidExpect cop without issues 2018-01-07 18:48:59 +01:00
Bertocq
830bb37189 Enable RSpec/VerifiedDoubles cop, fix issues & stash one 
Can't figureout solution for offense at spec/models/verification/management/email_spec.rb
 so its stashed at .rubocop_todo.yml

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/VerifiedDoubles
 2018-01-07 18:47:19 +01:00
Bertocq
95e86eafbb Enable RSpec/SubjectStub cop without issues 2018-01-07 18:46:58 +01:00
Bertocq
425404b890 Enable RSpec/SingleArgumentMessageChain cop without issues 2018-01-07 18:46:58 +01:00
Bertocq
dc1deee15a Enable RSpec/SharedContext cop without issues 2018-01-07 18:46:58 +01:00
Bertocq
3762fd347e Enable RSpec/ScatteredSetup & fix issue 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredSetup
 2018-01-07 18:46:58 +01:00
Bertocq
f8fb32db76 Enable RSpec/ScatteredLet cop & fix issue 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredLet
 2018-01-07 18:46:58 +01:00
Bertocq
33365479c9 Enable RSpec/ReturnFromStub cop without issues 2018-01-07 18:46:58 +01:00
Bertocq
16eae689f9 Enable RSpec/RepeatedExample cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedExample
 2018-01-07 18:46:32 +01:00
depfu[bot]
eed0582fae Upgrade uglifier to version 4.1.2 2018-01-07 18:12:19 +01:00
Bertocq
4f6597b200 Enable RSpec/RepeatedDescription cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedDescription
 2018-01-07 17:45:34 +01:00
Bertocq
e89d081a47 Enable RSpec/PredicateMatcher cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PredicateMatcher
 2018-01-07 17:42:59 +01:00
Bertocq
c6cac965dd Enable RSpec/OverwritingSetup cop without issues 2018-01-07 17:40:59 +01:00
Bertocq
34bb9d65b1 Enable RSpec/NotToNot cop and fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
 2018-01-07 17:39:48 +01:00
Bertocq
79a3b97c64 Enable RSpec/NestedGroups cop with a reasonable max value of 4 2018-01-07 17:38:55 +01:00
Bertocq
4c48027228 Explicitly disable RSpec/NamedSubject cop until debate is held 2018-01-07 17:36:46 +01:00
Bertocq
317247103e Enable RSpec/MultipleSubjects without issues 2018-01-07 17:07:34 +01:00
Bertocq
ce395217f8 Disable RSpec/MultipleExpectations cop with 1339 possible offenses, need to stablish a max amount after a debate 2018-01-07 17:06:43 +01:00
Bertocq
18d14dfe17 Enable RSpec/MultipleDescribes cop without issues 2018-01-07 17:04:38 +01:00
Bertocq
eb822c4a5e Enable RSpec/MessageSpies cop without issues 
EnforcedStyle: receive configuration was added to follow codebase conventions

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MessageSpies
 2018-01-07 16:51:11 +01:00
Bertocq
c4aa2d7093 Enable RSpec/MessageExpectation cop & fix issues 
There was 34 `allow` occurences and 17 `expect` occurences, so to be consistent `allow` form was chosen.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MessageExpectation
 2018-01-07 16:36:18 +01:00
Bertocq
987b31d618 Enable RSpec/MessageChain cop without issues 2018-01-07 16:28:37 +01:00
Bertocq
2d355ce938 Enable RSpec/LetSetup cop & fix issues 
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetSetup
 2018-01-07 16:23:49 +01:00
Bertocq
8be2df09b8 Update unreleased section of changelog 2018-01-07 15:38:45 +01:00