Bertocq
49f48ddf4b
Highlight current heading on results list
2017-07-10 17:48:04 +02:00
Bertocq
741a342bb0
Restrict compatilibility edit on admin investment form
...
Why:
* A non-winner but compatible investment shouldn't be marked as incompatible
How:
* Show incompatilibility checkbox only if investment is winner or incompatible
2017-07-10 17:34:05 +02:00
Bertocq
2fba9de33b
Don't display incompatible investment's table if empty
2017-07-10 17:12:28 +02:00
Bertocq
3a94fe4cc2
Fix indentation on if-else assignement
2017-07-10 16:03:31 +02:00
Bertocq
efacd0def3
Make calculate_winners explicitly delayed
...
Why:
* As seen on preproduction and production environments on Madrid's fork. Budget::Result#calculate_winners is very costly when done to all headings for a given budget (as requested on Admin::BudgetsController#calculate_winners) but its not when done individually for only a heading (as requested on Budget::Investment#recalculate_heading_winners)
How:
* Removing `handle_asynchronously :calculate_winners` from bellow Budget::Result#calculate_winners definition, to avoid making any call delayed. And explicitly calling `.delay` only when needed (on Admin::BudgetsController#calculate_winners)
2017-07-10 15:12:14 +02:00
Bertocq
2b85deabec
Recalculate heading winners on incompatibility change
...
Why:
* We should recalculate winners also when an incompatible investment is flagged as compatible again
How:
* Removing the condition to recalculate that was checking only for a winner investment flagged as incompatible
* Extending the Budget::Result model spec to cover that new scenario
2017-07-10 14:24:55 +02:00
Bertocq
69f4e1c683
Fix all rubocop Metrics/LineLength issues (140+)
2017-07-10 13:22:49 +02:00
Senén Rodero Rodríguez
95630d6546
Add comment to temporary bugfix.
2017-07-10 12:46:31 +02:00
María Checa
089c690b49
Created new entry point CensusCaller
...
Here's a better alternative than the first one. Added a new abstraction level from which are performed both types of census calls, while the logic of those is managed in their own library.
2017-07-10 12:22:30 +02:00
Bertocq
b1caefdf9a
Use i18n to localize date on view
2017-07-09 13:44:31 +02:00
María Checa
7e701db608
Added new census data source to Verification::Residence
...
Adapted model to perform a query to find a `LocalCensusRecord` record in case the census API is not available or returns invalid data.
2017-07-08 20:39:05 +02:00
María Checa
feff9fff0f
LocalCensus model created
2017-07-08 19:56:10 +02:00
Senén Rodero Rodríguez
4b2310c135
Move and refactor method from follow to user model to get user interests. Add specification to check the discard of duplicate interests.
2017-07-07 15:18:34 +02:00
Senén Rodero Rodríguez
a7aef0a9fb
Initialize App js modules after followable update.
2017-07-07 13:38:53 +02:00
taitus
60e812c2e5
New texts and titles for followable buttons.
2017-07-07 13:38:53 +02:00
taitus
5fe894aa6b
New proposal method to get users_to_notify.
2017-07-07 13:38:52 +02:00
taitus
0c2be6a0d4
Refactor js followable response.
2017-07-07 13:38:52 +02:00
taitus
b60748c552
Remove unneeded return from Follow model. Add whitespaces to enhance reading.
2017-07-07 13:38:52 +02:00
taitus
97ee107157
Do not show flaggable and followable buttons on budgets_investment and proposals pages when user is not logged.
2017-07-07 13:38:52 +02:00
taitus
0ffa213a65
Fix scss-lint
2017-07-07 13:38:49 +02:00
taitus
b29bf62f56
Send proposals notifications to followers.
2017-07-07 13:37:55 +02:00
taitus
35f7f11177
Add dependent destroy to followable.
2017-07-07 13:37:55 +02:00
taitus
14ec4f5315
Add styles and translations for users interests.
2017-07-07 13:37:53 +02:00
Senén Rodero Rodríguez
313b78978d
Add followable JS module. Refactor follow_helper and follow buttons partial.
2017-07-07 13:34:54 +02:00
Senén Rodero Rodríguez
1f22286e29
Create rspec shared examples to test followable features on any followable entity.
2017-07-07 13:34:54 +02:00
taitus
19820e4432
Add public interests validation and show interests on user profile
2017-07-07 13:34:43 +02:00
taitus
bce28afe36
Add followable to budget investment model.
2017-07-07 12:07:25 +02:00
Senén Rodero Rodríguez
84dbef16a4
Create followable concern, follow model. Add followable to proposal model.
2017-07-07 12:02:00 +02:00
Bertocq
a9c928505d
Fix indentation on annotator overrides scss file
2017-07-06 15:56:51 +02:00
BertoCQ
e990568895
Merge pull request #1721 from consul/feature/add_slugs_to_budget_related
...
Add slugs to budget related
2017-07-05 13:16:24 +02:00
BertoCQ
c439454ec7
Merge pull request #1722 from consul/chore/rubocop_cleaning
...
Rubocop cleaning
2017-07-05 13:12:09 +02:00
Bertocq
e3d89261a6
Add Sluggable concern and unique validation to Budget, Group and Heading
...
* What: We need to generate slug on Budget, Group and Heading classes, validating its unique for its scope
* How: Adding a presence and unique validation using Budget always as scope.
2017-07-05 12:33:16 +02:00
Bertocq
2888c20489
Fix all Style/RedundantSelf rubocop issues
2017-07-05 11:55:52 +02:00
Bertocq
97d7a21791
Fix all Style/RedundantReturn rubocop issues
2017-07-05 11:55:52 +02:00
Bertocq
343da2d58e
Improve admin investment view with selection/compatibility/winner flags on top
2017-07-05 11:26:59 +02:00
Bertocq
e35817f240
Add selected checkbox on admin investment form
2017-07-04 23:48:18 +02:00
Bertocq
28970c6701
Fix all Style/UnneededInterpolation rubocop issues and remove from rubocop_tod
2017-07-04 22:44:08 +02:00
Bertocq
4535fc9345
Create Sluggable concern, generates slug using name attribute before validation
...
Why:
* We need a way to generate a slug for a object given his name attribute value
How:
* A concern that generates the slug before validation
2017-07-04 18:40:54 +02:00
Bertocq
9f38192e13
Remove unnecesary frozen_string_literal comment
2017-07-04 17:25:15 +02:00
Raimond Garcia
e7e5b3c4a3
Merge branch 'master' into 1647-locale_site_customization
2017-07-04 12:11:07 +02:00
Bertocq
10c299d19f
Add to public Budget Results page winners, discarded and incompatible listing
2017-07-04 01:34:25 +02:00
Bertocq
e87073301d
Fix form js coffe data toggle-link helper function for toogle buttons
2017-07-04 01:34:25 +02:00
Bertocq
339597483e
Add incompatible scope to Budget Investment model
2017-07-04 01:34:25 +02:00
Bertocq
688ec05ea2
Replace winner column for incompatible on admin investment list filter by selected
2017-07-04 01:34:24 +02:00
Bertocq
646b3657ee
Add investment status on admin budget investment detail show page
2017-07-04 01:34:24 +02:00
Bertocq
afc77f68fb
Add incompatible checkbox on admin investment edit form
2017-07-04 01:34:24 +02:00
Bertocq
99052485fb
Recalculate heading winner investments when a winner is flagged as incompatible
2017-07-04 01:34:24 +02:00
Bertocq
640e0e1c2a
Use compatible filter when calculating budget heading winners
2017-07-04 01:34:24 +02:00
Bertocq
ed016d7afd
Add compatible scope to Budget Investment and use it on the winners scope
...
Why:
* Only compatible investments can be winners
How:
* Using the new column incompatible to filter compatible investments
2017-07-04 01:34:24 +02:00
María Checa
ecaf7192c5
Merge branch '1647-locale_site_customization' of https://github.com/MariaCheca/consul into 1647-locale_site_customization
2017-07-03 12:59:09 +02:00
