consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
13,907 Commits 1 Branch 0 Tags
f6beff91be8fcffdfdee8294e771bd613d7aeecc
Commit Graph

7225 Commits

Author SHA1 Message Date
Javi Martín
fb72fc48fd Simplify milestones styles for small devices 
The selector `nth-child(even)` didn't need specific rules, and it's
easier to understand the code for the selector `nth-child(odd)` if all
breakpoints are grouped together.
 2019-01-18 14:26:17 +01:00
Javi Martín
46296b702e Group milestone content CSS rules together 2019-01-18 14:26:11 +01:00
Javi Martín
39c8d431f8 Group milestones timeline li CSS rules together 2019-01-18 14:26:08 +01:00
Javi Martín
cb92d29ddc Simplify nth-child selectors 
Using `nth-child(odd), nth-child(even)` is the same as selecting all
the elements.
 2019-01-18 14:26:05 +01:00
Javi Martín
51a4ca98ad Move milestone styles to their own sheet 2019-01-18 14:26:02 +01:00
Javi Martín
789476e6ab Synchronize percentage for new progress bars 
According to the HTML specification:

> The default value is the minimum plus half the difference between the
> minimum and the maximum, unless the maximum is less than the minimum,
> in which case the default value is the minimum.

So for new progress bars, we had a numeric value of `nil` and a range
value of `50`, meaning the input fields weren't in sync.

Manually triggering the event on the progress, while not an ideal
solution (ideally we would be able to define `0` as default), sets the
value of the numeric field.
 2019-01-18 14:17:53 +01:00
Javi Martín
fff5673ec0 Simplify hiding/showing progress bar type field 
With a parent element for just input and label, there aren't conflicts
with the globalize tabs code anymore.
 2019-01-18 14:17:48 +01:00
Javi Martín
96454a41f0 Use I18n keys instead of human_attribute_name 
Even if it means duplicating the translations in many cases, it's
consistent with the rest of the application.
 2019-01-18 14:17:45 +01:00
decabeza
7c0fb96b02 Adds styles to admin progress bars views 2019-01-18 14:17:40 +01:00
Javi Martín
dfdf0b0636 Hide title field for primary progress bars 
These bars don't have a title.
 2019-01-18 14:17:37 +01:00
Javi Martín
c5d32c5ab9 Manage progress bars in the admin area 2019-01-18 14:17:33 +01:00
Javi Martín
4f25581636 Add progress bar polymorphic views 2019-01-18 14:17:29 +01:00
Javi Martín
eaea95ccfb Add progress bar model 2019-01-18 14:17:12 +01:00
Julian Nicolas Herrero
db404429fc Merge pull request #3190 from consul/release_0.18.1 
Release 0.18.1
 2019-01-18 10:43:43 +01:00
Javi Martín
f2210bc5b5 Update changelog for release 0.18.1 2019-01-17 13:17:38 +01:00
decabeza
9dfbeed140 Moves draft and final result publication dates from tabs to sidebar 2019-01-15 16:13:41 +01:00
decabeza
73637de0d0 Adds homepage phase and tab to legislation processes show 2019-01-15 16:13:38 +01:00
rogelio-o
f1bb1ff8de Moves attributes to a concern. 2019-01-14 20:26:47 +01:00
Julian Herrero
d77183ee09 Improvement - CRUD budgets and content blocks 2019-01-14 12:59:48 +01:00
rogelio-o
ea76179002 Solves #3153. It refactors images attributes. 2019-01-12 17:42:55 +01:00
Javi Martín
f8e9566699 Simplify return statement 
Just the way is usually done in the rest of the code.
 2019-01-10 16:11:51 +01:00
Javi Martín
d5d800f75c Simplify SORTING_OPTIONS usage 
Using a hash instead of an array of hashes makes accessing its keys and
values much easier.
 2019-01-10 16:11:51 +01:00
Javi Martín
68fb295db5 Use if blocks instead of two ternary operators 
Using a simple ternary operator is usually fine; however, code combining
two ternary operator is a bit hard to follow.
 2019-01-10 16:11:51 +01:00
Javi Martín
eb6bba52e3 Simplify code 
The string inside `params[:direction]` should already use lowercase
characters.
 2019-01-10 16:11:51 +01:00
Javi Martín
814579d58f Simplify interpolation 
It's OK ot use single quotes inside a string with double quotes in order
to avoid escape characters.
 2019-01-10 16:11:51 +01:00
Javi Martín
ee2f970e03 Fix sorting links for non-English languages 
We were assuming the translation and the column name were related.
 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
3fd7b3d216 Extract setting icon and direction to methods 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
0fe9ea08c3 Fix the direction assignment 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
e88acb8905 Make params handling case insensitive 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
e264490bca Styling and refactor sorting methods and helpers 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
3ab70ff0d8 Move validating params to model 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
37b2226432 Make the link_to helper more readable 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
cb761c56c2 Fix issue with app crashing when sort_by param was incorrect 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
101292d303 Rename allowed sort option variable 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
747b8295b1 Refactor link_to_investments_sorted method 2019-01-10 15:35:54 +01:00
Anna Anks Nowak
35cebe0eef Use symbols in sorting and set direction properly 2019-01-10 15:35:54 +01:00
Anna Anks Nowak
12484ed4fd Change SORTING_OPTIONS to has 2019-01-10 15:35:54 +01:00
Anna Anks Nowak
2523775d9f Make the conditional more readable temporarily 2019-01-10 15:35:54 +01:00
Anna Anks Nowak
9786b0bf7d Rewrite sorting to support direction param [#2931] 2019-01-10 15:34:33 +01:00
Anna Anks Nowak
2877229904 Move the link styling to th [#2931] 2019-01-10 15:28:55 +01:00
Anna Anks Nowak
5dd468092a Rewrite the method to not use budget_investments_sorting_options [#2931] 2019-01-10 15:28:55 +01:00
Anna Anks Nowak
22059379f5 Refactor by creating a helper method for generating sorting links [#2931] 2019-01-10 15:28:55 +01:00
Anna Anks Nowak
ea3319ae6f Add sorting links to table headers with proper styling [#2931] 2019-01-10 15:28:55 +01:00
Julian Nicolas Herrero
cc288fcedd Merge pull request #3167 from consul/backport-1793-cleanup_lines_controller 
[Backport] Remove before action not used
 2019-01-10 09:38:07 +01:00
Julian Nicolas Herrero
cd59f1b803 Merge pull request #3133 from consul/backport-1775-bug_management_create_investment_without_location 
[Backport] Bug Management Cannot create Budget Investment without a map location
 2019-01-09 18:02:53 +01:00
Julian Nicolas Herrero
702dc2bef5 Merge pull request #3154 from consul/backport-check_for_deleted_proposals 
[Backport] checks for deleted proposals
 2019-01-09 17:57:01 +01:00
Julian Herrero
0858f4c6f4 cleanup (remove unused code) 2019-01-09 17:49:46 +01:00
Julian Nicolas Herrero
7ccab504f0 Merge pull request #3160 from consul/backport-1784-consistency_remove_semicolon_from_controllers 
[Backport] Remove semicolons from controllers
 2019-01-09 17:46:32 +01:00
Julian Nicolas Herrero
08a692341a Merge pull request #3150 from consul/backport-1769-crud_budget_and_usa 
[Backport] new CRUD budgets, content blocks and heading map
 2019-01-09 17:35:46 +01:00
Javier Martín
90a66239a5 Merge pull request #3151 from consul/backport-fix_admin_investments_default_order 
Add default order for admin budget investments list
 2019-01-09 15:46:52 +01:00