Use symbols in sorting and set direction properly

This commit is contained in:
Anna Anks Nowak
2019-01-01 18:19:06 +01:00
committed by Javi Martín
parent 12484ed4fd
commit 35cebe0eef

View File

@@ -140,10 +140,11 @@ class Budget
end
def self.order_filter(sorting_param, direction)
sorting_key = sorting_param.to_sym
sorting_key = sorting_param.to_sym if sorting_param
available_option = SORTING_OPTIONS.select { |sp| sp[sorting_key]}.reduce
if sorting_param.present? && available_option.present? then
%w[asc desc].include?(direction) ? direction : "desc"
direction = %w[asc desc].include?(direction) ? direction : "asc"
order("#{available_option[sorting_key]} #{direction}")
else
order(cached_votes_up: :desc).order(id: :desc)