consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
18,812 Commits 1 Branch 0 Tags
e24ebf9406bfeb97c15ab1db1393aa80907c7b76
Commit Graph

18812 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Javi Martín
e24ebf9406 Merge pull request #5446 from consuldemocracy/use_npm_to_install_foundation 
Use node packages to install Foundation
 2024-04-02 16:07:26 +02:00
Javi Martín
2fa713c644 Use node packages to install Foundation 
Since Foundation hasn't released a new gem for years, we haven't been
able to upgrade Foundation to its most recent version.

Thanks to this change, we'll be able to do so.

Note we're using motion-ui version 2.0.3 because version 2.0.5 (the
latest at the moment) requires Dart Sass.
 2024-04-02 14:41:42 +02:00
Javi Martín
338cb76127 Merge pull request #5423 from consuldemocracy/npm_instead_of_rails-assets.org 
Replace rails-assets.org with Node.js packages
 2024-04-02 14:36:02 +02:00
Javi Martín
93f5597736 Merge pull request #5457 from consuldemocracy/fix_rubocop_offense 
Fix RSpec/LetBeforeExamples rubocop offense
 2024-04-02 14:33:54 +02:00
Javi Martín
f46558b4dd Replace rails-assets.org with Node.js packages 
Now that we use NPM, we don't need the wrapper provided by rails-assets
anymore.
 2024-03-30 05:10:13 +01:00
Javi Martín
c8c1b18bc1 Fix RSpec/LetBeforeExamples rubocop offense 
This was accidentally introduced in commit 64aa1ffe0. Pronto didn't
detect it because the line itself was fine; the problem lied in its
place within the file.
 2024-03-30 02:08:49 +01:00
Javi Martín
d1f9d5b9bf Merge pull request #5455 from coslajohn/fix_submit_ballot 
Change the English translation of check ballot to avoid confusion
 2024-03-30 00:04:21 +01:00
CoslaJohn
237bfb4fad Change the english translation of check ballot to avoid confusion 2024-03-29 23:41:05 +01:00
Javi Martín
94f37a0f16 Merge pull request #5452 from consuldemocracy/dependabot/bundler/ahoy_matey-5.0.2 
Bump ahoy_matey from 4.2.1 to 5.0.2
 2024-03-27 17:51:27 +01:00
dependabot[bot]
2ef88459cb Bump ahoy_matey from 4.2.1 to 5.0.2 
Bumps [ahoy_matey](https://github.com/ankane/ahoy) from 4.2.1 to 5.0.2.
- [Changelog](https://github.com/ankane/ahoy/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/ahoy/compare/v4.2.1...v5.0.2)

---
updated-dependencies:
- dependency-name: ahoy_matey
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-27 17:36:37 +01:00
Javi Martín
90202c6d59 Merge pull request #5402 from consuldemocracy/dependabot/bundler/dalli-3.2.8 
Bump dalli from 3.2.6 to 3.2.8
 2024-03-27 17:21:21 +01:00
dependabot[bot]
6ac8455e8b Bump dalli from 3.2.6 to 3.2.8 
Bumps [dalli](https://github.com/petergoldstein/dalli) from 3.2.6 to 3.2.8.
- [Changelog](https://github.com/petergoldstein/dalli/blob/main/CHANGELOG.md)
- [Commits](https://github.com/petergoldstein/dalli/compare/v3.2.6...v3.2.8)

---
updated-dependencies:
- dependency-name: dalli
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-27 17:04:27 +01:00
Javi Martín
ed765af6c2 Merge pull request #5382 from consuldemocracy/dependabot/bundler/audited-5.4.3 
Bump audited from 5.4.0 to 5.4.3
 2024-03-27 17:04:19 +01:00
Javi Martín
ec686a8d1a Ignore touch audited callbacks globally 
This is possible since audited 5.4.3, and IMHO it's useful because
audited has added a callback on touch, which could result in strange
behavior since we might use the `touch` method to expire the cache
without doing any changes.

While this doesn't affect our application because we're using the `on:`
option of the `audited` method in the budget investment model, it'll
make it easier to enable audited for other classes in custom
installations without having to worry about the (usually undesired)
touch callbacks.
 2024-03-27 16:51:29 +01:00
dependabot[bot]
137d079869 Bump audited from 5.4.0 to 5.4.3 
Bumps [audited](https://github.com/collectiveidea/audited) from 5.4.0 to 5.4.3.
- [Changelog](https://github.com/collectiveidea/audited/blob/main/CHANGELOG.md)
- [Commits](https://github.com/collectiveidea/audited/compare/v5.4.0...v5.4.3)

---
updated-dependencies:
- dependency-name: audited
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-27 16:51:29 +01:00
Javi Martín
5fd0039cca Merge pull request #5410 from consuldemocracy/dependabot/bundler/caxlsx-4.1.0 
Bump caxlsx from 3.4.1 to 4.1.0
 2024-03-27 16:51:11 +01:00
dependabot[bot]
d1b6d58a1f Bump caxlsx from 3.4.1 to 4.1.0 
Bumps [caxlsx](https://github.com/caxlsx/caxlsx) from 3.4.1 to 4.1.0.
- [Changelog](https://github.com/caxlsx/caxlsx/blob/master/CHANGELOG.md)
- [Commits](https://github.com/caxlsx/caxlsx/compare/v3.4.1...v4.1.0)

---
updated-dependencies:
- dependency-name: caxlsx
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-27 15:33:33 +00:00
Javi Martín
829c9b896f Merge pull request #5414 from consuldemocracy/dependabot/bundler/savon-2.15.0 
Bump savon from 2.14.0 to 2.15.0
 2024-03-27 16:32:26 +01:00
Javi Martín
37049aeadc Merge pull request #5435 from consuldemocracy/dependabot/bundler/invisible_captcha-2.3.0 
Bump invisible_captcha from 2.1.0 to 2.3.0
 2024-03-27 16:31:40 +01:00
Javi Martín
d0f6e4396f Add missing options to invisible captcha initializer 
These options had been added in the gem's initializer by version 2.0,
but we forgot to add them to our initializer file. So we're doing it
now.
 2024-03-27 16:12:11 +01:00
dependabot[bot]
b25d4ea7e2 Bump invisible_captcha from 2.1.0 to 2.3.0 
Bumps [invisible_captcha](https://github.com/markets/invisible_captcha) from 2.1.0 to 2.3.0.
- [Changelog](https://github.com/markets/invisible_captcha/blob/master/CHANGELOG.md)
- [Commits](https://github.com/markets/invisible_captcha/compare/v2.1.0...v2.3.0)

---
updated-dependencies:
- dependency-name: invisible_captcha
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-27 16:12:11 +01:00
dependabot[bot]
ecaf66541a Bump savon from 2.14.0 to 2.15.0 
Bumps [savon](https://github.com/savonrb/savon) from 2.14.0 to 2.15.0.
- [Release notes](https://github.com/savonrb/savon/releases)
- [Changelog](https://github.com/savonrb/savon/blob/main/CHANGELOG.md)
- [Commits](https://github.com/savonrb/savon/compare/v2.14.0...v2.15.0)

---
updated-dependencies:
- dependency-name: savon
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-27 15:10:19 +00:00
Javi Martín
9beb3e6e20 Merge pull request #5433 from consuldemocracy/dependabot/bundler/capistrano-3.18.1 
Bump capistrano from 3.17.3 to 3.18.1
 2024-03-27 16:08:49 +01:00
dependabot[bot]
20bc2cef53 Bump capistrano from 3.17.3 to 3.18.1 
Bumps [capistrano](https://github.com/capistrano/capistrano) from 3.17.3 to 3.18.1.
- [Release notes](https://github.com/capistrano/capistrano/releases)
- [Commits](https://github.com/capistrano/capistrano/compare/v3.17.3...v3.18.1)

---
updated-dependencies:
- dependency-name: capistrano
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-03-27 15:48:29 +01:00
Javi Martín
c585eb0e26 Merge pull request #5418 from consuldemocracy/dependabot/bundler/wicked_pdf-2.8.0 
Bump wicked_pdf from 2.7.0 to 2.8.0
 2024-03-27 15:39:43 +01:00
Javi Martín
af2feee887 Merge pull request #5359 from consuldemocracy/dependabot/bundler/omniauth-2.1.2 
Bump omniauth from 2.1.1 to 2.1.2
 2024-03-27 15:35:56 +01:00
Javi Martín
e874c08025 Merge pull request #5343 from consuldemocracy/dependabot/bundler/airbrake-13.0.4 
Bump airbrake from 13.0.3 to 13.0.4
 2024-03-27 15:31:20 +01:00
Javi Martín
ea2916df6d Merge pull request #5300 from consuldemocracy/dependabot/bundler/delayed_job_active_record-4.1.8 
Bump delayed_job_active_record from 4.1.7 to 4.1.8
 2024-03-27 15:09:28 +01:00
Sebastia
d76f95459e Merge pull request #5369 from consuldemocracy/refactor_comments_specs 
Make comments specs faster
 2024-03-25 15:04:04 +01:00
taitus
6987c2e7df Remove unnecessary specs 
All these types of tests have already been grouped together in the
comments_specs file which contains different factories including
budget_investments.

I don't think it is necessary to maintain these tests.
 2024-03-25 07:59:42 +01:00
taitus
64aa1ffe06 Move notifiable in app shared example to questions specs 2024-03-25 07:59:42 +01:00
taitus
ad04ea76f5 Remove unused spec file 2024-03-25 07:59:42 +01:00
taitus
64de5eb81c Improve describe text 2024-03-25 07:59:42 +01:00
taitus
793eaf4429 Remove unnecessary specs 
The test "display administrator id on public views" is not correct. The valuation comments
are not display never on public views. If we reload this admin page we can see that the
description is render instead of administrator_id as we can see at the upper test:

```
scenario "display administrator description on admin views"
```

The deleted test was passed because there is an error at the moment to render the comments.
As we can see in the file ´app/views/comments/create.js.erb:10´ we try render comment
without valuation value:

```
App.Comments.add_comment(parent_id, "<li><%= j(render @comment) %></li>");
```
That it is necessary to render correctly the description or the id.

By other hand the test "public users not see admin description"  is already being checked
 in the 'system/comments_specs'. However, we are going to add a new expectation to
make sure that the admin description does not appear on the public pages.
 2024-03-25 07:59:42 +01:00
taitus
3f1561e408 Unify flaggable specs 2024-03-25 07:59:42 +01:00
taitus
f328d53f41 Unify submit button comments specs 2024-03-25 07:59:42 +01:00
taitus
e3ce8a85fa Unify show comments specs 2024-03-25 07:59:42 +01:00
taitus
886aee72fc Unify reply to reply comments specs 2024-03-25 07:59:42 +01:00
taitus
8da4c60c2a Unify hide comments specs 2024-03-25 07:59:42 +01:00
taitus
8ba16c2330 Unify collapse comments specs 2024-03-25 07:59:42 +01:00
taitus
093ad07a14 Unify voting comments allow undoing votes specs 2024-03-25 07:59:42 +01:00
taitus
992a8182ff Unify voting comments update specs 2024-03-25 07:59:42 +01:00
taitus
35bc03f640 Unify voting comments create specs 2024-03-25 07:59:42 +01:00
taitus
dbd419e75d Unify voting comments show specs 2024-03-25 07:59:42 +01:00
taitus
57805747a2 Simplify administrators comments tests 2024-03-25 07:59:42 +01:00
taitus
79d00e7b92 Unify can not comment as a moderator specs 2024-03-25 07:59:42 +01:00
taitus
ac740f3657 Unify reply as an administrator 
Note that the click_link "Reply" is now inside a "within".

This is due to the case of "legislation_annotation" before in the original test
no comment was created as it simply took the one created by default when creating
a "legislation_annotation".

```
  annotation = create(:legislation_annotation, author: citizen)
  comment = annotation.comments.first
```

Now to try to unify this test, we always create a comment, and in this case as we
also created the "legislation_annotation" we have 2 comments, so it is necessary
to add the "click_link" inside the "within".
 2024-03-25 07:59:42 +01:00
taitus
f9349a4b0d Unify comment as administrator specs 2024-03-25 07:59:42 +01:00
taitus
8a2e0c8e1f Simplify moderator comments tests 2024-03-25 07:59:42 +01:00
taitus
adae022f77 Unify can not comment as an administrator specs 2024-03-25 07:59:42 +01:00