Commit Graph

6458 Commits

Author SHA1 Message Date
Bertocq
f03e2ec236 Use shared social_share partial on every view that was using duplicated code 2017-05-30 12:39:36 +02:00
Bertocq
f42cec4c41 Create shared partial for Social Share block 2017-05-30 12:25:10 +02:00
Juanjo Bazán
2382dc56b5 fixes wording 2017-05-30 10:46:34 +02:00
Juanjo Bazán
1ae55a59f6 Merge pull request #1560 from bertocq/feature/admin_administrators_management
Administrators management in admin area
2017-05-30 10:44:50 +02:00
Juanjo Bazán
6fd50d96c0 Merge pull request #1566 from bertocq/fix/recount_spec_flaky_test
Avoid creating objects, on poll recount spec, with fixed id numbers
2017-05-30 10:42:52 +02:00
Juanjo Bazán
235a240136 Merge pull request #1569 from bertocq/chore/fix_rubocop_todo
Fix rubocop_todo error because of renamed cop
2017-05-30 10:41:01 +02:00
Juanjo Bazán
c4ca66fafc Merge pull request #1571 from bertocq/fix/poll_factory_name_generation
Fix Poll factory name generation to guarantee uniqueness
2017-05-30 10:39:43 +02:00
Raimond Garcia
291dcf2dfc Merge pull request #1576 from consul/budgets-back
polish budgets investment show back link
2017-05-29 18:46:09 +02:00
decabeza
0622ad1f24 polish budgets investment show back link 2017-05-29 18:01:22 +02:00
Raimond Garcia
9f11e49d79 Merge pull request #1573 from consul/budgets-back-link
adds heading_id on investment show back link
2017-05-29 15:20:05 +02:00
decabeza
599ef6e9da removes redundant spec 2017-05-29 14:35:57 +02:00
Raimond Garcia
aa6a6cdc88 Merge pull request #1574 from consul/accesibility-colors
Accesibility colors
2017-05-29 14:21:28 +02:00
decabeza
e78b675cdf fixes color contrast on close button alerts 2017-05-29 13:22:40 +02:00
decabeza
9663582124 fixes color contrast on officials levels labels 2017-05-29 13:19:28 +02:00
decabeza
7e0be26ad6 adds specs 2017-05-29 12:56:34 +02:00
decabeza
9607346e57 adds heading_id on investment show back link 2017-05-29 12:13:24 +02:00
Bertocq
1254f684fd Fix Poll factory name generation to guarantee uniqueness with SecureRandom.hex 2017-05-29 11:23:02 +02:00
Juanjo Bazán
7f703cdcb1 Merge pull request #1570 from bertocq/fix/missing_data-equalizer-watch
Fix Missing data-equalizer-watch attribute (and all failing JS tests with it)
2017-05-29 10:50:05 +02:00
Bertocq
41fb640f92 Add missing data-equalizer-watch attribute
Why:

* There is a data-equalizer attribute on the parent div, and a data-equalizer-watch on a sibiling div, and that breakes both the purpose of those values (Resize child elements of data-equalizer to have the same height. Ref: http://foundation.zurb.com/sites/docs/equalizer.html)

* That lack of attribute was breaking many specs consistently on localhost with phantomjs 2.1.1 on macos sierra (and ubuntu as reported by @amaia)

How:

* Just adding the missing 'data-equalizer-watch' attribute on the div child of the one using 'data-equalizer'
2017-05-29 09:58:37 +02:00
Alberto Miedes Garcés
18db68a430 Force pagination, limit query depth and complexity 2017-05-29 09:47:39 +02:00
Bertocq
db68353937 Merge remote-tracking branch 'consul/master' 2017-05-29 01:43:47 +02:00
Bertocq
ca94176837 Rename rubocop cop name in excluding rubocop_todo list to avoid it from failing 2017-05-28 11:22:30 +02:00
Juanjo Bazán
8196d07cd6 Merge pull request #1567 from bertocq/fix/officing_recount_spec_flaky_test
Use a random word on the Poll factory name attribute
2017-05-26 17:46:19 +02:00
Juanjo Bazán
667bb3b2d0 Merge pull request #1568 from consul/budgets-message
Budgets message
2017-05-26 17:45:53 +02:00
decabeza
75841a71be updates texts on specs 2017-05-26 17:28:04 +02:00
decabeza
0e581896c0 improves message when not enough money 2017-05-26 17:12:21 +02:00
decabeza
a49b206b42 adds help message to how change ballot 2017-05-26 14:55:27 +02:00
decabeza
e31a1ea39e fixes height of participation not allowed message 2017-05-26 14:40:25 +02:00
Bertocq
6cda0d52d5 Use a random word on the Poll factory name attribute to avoid flaky tests 2017-05-25 12:28:53 +02:00
Bertocq
3dde935051 Avoid creating objects, on poll recount spec, with fixed id numbers
This was generating a flaky test that sometimes generated a unique key value constraint violation
2017-05-25 11:58:18 +02:00
Juanjo Bazán
04c9aeedac Merge pull request #1564 from consul/admin-geozones
fixes admin geozones tables
2017-05-25 11:52:59 +02:00
Bertocq
fe5ddd019b Add logic to prevent the current user from removing himself from the administrator list, and a flash error notice for that scenario 2017-05-25 11:29:39 +02:00
Bertocq
e9ea72113b Add spec scenario for current user trying to remove himself from administrators list 2017-05-25 11:28:36 +02:00
decabeza
9dca1940ab fixes admin geozones tables 2017-05-25 11:12:09 +02:00
decabeza
02055bd09a hides legislation empty tables, improves table styles 2017-05-24 13:34:37 +02:00
decabeza
5aa8017aa8 fixes admin menu active classes 2017-05-24 13:16:12 +02:00
Juanjo Bazán
26b186a740 Merge pull request #1557 from bertocq/feature/newsletter_users_emails_zip
Allow admins to download Newsletter's users emails list in zip
2017-05-24 13:13:34 +02:00
decabeza
664ef9895d adds callout styles on empty content messages 2017-05-24 13:05:27 +02:00
decabeza
9b66dc09ae adds missing i18n 2017-05-24 13:04:32 +02:00
decabeza
5364ec106a fixes headings structure on legislation admin 2017-05-24 13:04:19 +02:00
decabeza
d5d5402ece improves color contrast 2017-05-24 13:03:34 +02:00
decabeza
28e17b870c unifies styles and html code 2017-05-24 13:03:25 +02:00
Bertocq
4ab92731b6 Add expectations for newsletter users and non-newsletter users on email zip download scenario 2017-05-24 12:56:03 +02:00
Bertocq
9ba29fef8c Add feature scenario for Newsletter admin section, including email zip download 2017-05-24 12:23:05 +02:00
Juanjo Bazán
0209875516 fixes flaky specs in admin stats 2017-05-24 12:08:29 +02:00
Juanjo Bazán
cf8d973384 Merge pull request #1561 from bertocq/chore/update_dev_test_setup_doc
Update Dev Test Setup Doc
2017-05-24 10:27:44 +02:00
Juanjo Bazán
0aff980a73 Merge pull request #1562 from bertocq/fix/time_always_with_zone
Always use Time with zone
2017-05-24 10:25:35 +02:00
Bertocq
9e74249b02 Always use Time.current (aliases internally to Time.zone.now)
Some specs where breaking close to midnight because 30.years.ago uses zone.now and Time.now.utc.to_date doesn't.
Also this will make all codebase consistent in the way time is deal with
2017-05-24 07:54:57 +02:00
Bertocq
7cc1745a29 Add missing Admin menu administrator translation 2017-05-24 00:00:44 +02:00
Bertocq
115feb20ae Fix admin translations for administrators management panel actions 2017-05-23 23:33:50 +02:00