Javi Martín
db7e8e79b7
Fix voters on booth not being created in dev seeds
...
There were validation errors because they didn't have officer nor booth
assignments.
2019-03-28 15:50:34 +01:00
Javi Martín
e2fa2ecf0d
Avoid outer variable shadowing warning
...
There were two variables named "title", one for the question and one for
the answer.
2019-03-28 15:50:34 +01:00
Javi Martín
f7f9fc15a5
Move todays_booths_for_officer to the model
...
This way we can easily add a test which will fail if by accident we
change the method to use `Date.today`. Until now using `Date.today`
would only fail if we ran specs in a time zone with a different date.
2019-03-28 15:49:17 +01:00
iagirre
a9d1fd3539
Fix for issues 1202, 1203 and 1204. Stub the Date and Time functions in the booth_spec test so that it won't give errors when running tests at midnight.
2019-03-28 15:49:17 +01:00
Bertocq
71bd6e41c6
Replace time.zone.today for date.current
2019-03-28 15:49:17 +01:00
Bertocq
9c7962c3a6
Check poll recount values for booth votes on admin panel
2019-03-28 15:49:17 +01:00
Bertocq
31428a5847
Add booth and officing assigments presence validation for booth votes, unskip specs
2019-03-28 15:47:52 +01:00
Bertocq
94c37eb588
Fix store officer and booth info spec
2019-03-28 15:47:52 +01:00
Bertocq
4e4057573d
Fix store officer and booth info spec
2019-03-28 15:47:52 +01:00
Bertocq
69bcd8ec9a
Set booth and officer assignments to Poll Voter on officing panel
2019-03-28 15:47:52 +01:00
Bertocq
8e61075659
Make clearer the set officing booth usage for secondary booth
2019-03-28 15:47:52 +01:00
Bertocq
49ffcfac06
Move set officing booth helper method calls to background block
2019-03-28 15:47:52 +01:00
Bertocq
d2e8f84759
Create missing shift and choose booth for the officer
2019-03-28 15:47:52 +01:00
Bertocq
80a9ba8aa7
Enable and fix booth selection back
2019-03-28 15:47:52 +01:00
Bertocq
77930d3275
Enable officing panel booth selection back
2019-03-28 15:47:52 +01:00
rgarcia
88c801d6c5
fixes specs
2019-03-28 15:47:52 +01:00
rgarcia
0acec655e2
fixes specs
2019-03-28 15:47:52 +01:00
rgarcia
4761ac91bd
Displays officing booth in layout
2019-03-28 15:47:52 +01:00
rgarcia
9c59c8b68e
displays booth location instead of booth name
2019-03-28 15:47:52 +01:00
rgarcia
0286ca4c59
displays single booth for any number of polls
2019-03-28 15:47:52 +01:00
rgarcia
5dea0e039e
updates notice
2019-03-28 15:47:52 +01:00
rgarcia
74706027cb
fixes specs
2019-03-28 15:47:52 +01:00
rgarcia
b4499321d3
stores officer booth on sign in
2019-03-28 15:47:52 +01:00
rgarcia
5835d12694
stores the officer that allowed a voter to vote in a physical booth
2019-03-28 15:47:52 +01:00
kikito
34dfeee9c9
Denormalizes booth_assignmen on the models where it is needed
2019-03-28 15:47:52 +01:00
kikito
10283c32ee
Adds scopes to officer_assignment
2019-03-28 15:47:52 +01:00
rgarcia
cc4eed3500
fixes specs
2019-03-28 15:47:52 +01:00
Javier Martín
ac58b87036
Merge pull request #3404 from consul/double_quotes
...
Add missing double quotes
2019-03-27 15:53:51 +01:00
Javi Martín
3e4e65ead7
Use double quotes inside ERB
...
We were using single quotes inside ERB code when that code was inside
HTML double quotes.
2019-03-25 14:58:54 +01:00
Javi Martín
4c35df4812
Use double quotes inside string interpolation
2019-03-25 14:58:54 +01:00
Javi Martín
d894d24bff
Use double quotes in config/locales
2019-03-25 14:58:54 +01:00
Javi Martín
2b4e1cf358
Add missing double quotes
...
We overlooked a few single quotes while we changed thousands of them.
2019-03-25 13:22:35 +01:00
Julian Nicolas Herrero
1b76a34074
Merge pull request #3402 from consul/include_default_custom_pages_in_dev_seeds
...
Include default custom pages in developers seed
2019-03-22 17:38:42 +01:00
Julian Nicolas Herrero
9cfd3c70be
Merge pull request #3385 from consul/welcome_page_not_logged_in_user
...
Require logged in user if navigate to /welcome
2019-03-22 17:35:29 +01:00
Alberto
ecd4a8a7b7
Merge pull request #3399 from consul/min-age-to-participate
...
Use min age to participate setting on verification residence form
2019-03-22 17:09:30 +01:00
decabeza
21c6da3767
Use min age to participate setting on verification residence form
2019-03-22 16:15:48 +01:00
Javier Martín
6593bc056a
Merge pull request #3401 from consul/backport-remove_obsolete_rake_tasks
...
Remove obsolete rake tasks
2019-03-22 14:08:42 +01:00
Javi Martín
9d6bd7e788
Remove obsolete rake tasks
...
These tasks dealt with data migrations or stats generations which were
done only once, so we don't need them anymore.
New CONSUL installations don't need these tasks, and existing CONSUL
installations will execute them when upgrading one release at a time.
2019-03-22 13:07:09 +01:00
Julian Herrero
8e5e757b00
Include default custom pages in developers seed
2019-03-22 12:29:42 +01:00
Javier Martín
7d472b747e
Merge pull request #3400 from consul/fix_processes_order
...
Fix legislation process feed order
2019-03-22 11:14:26 +01:00
Javi Martín
58816aef5f
Fix legislation process feed order
...
We need to add an ORDER BY clause; not doing so was causing different
processes to show up sometimes. As mentioned in the PostgreSQL manual:
> Because the order of the rows in the database table is unpredictable,
> when you use the LIMIT clause, you should always use the ORDER BY
> clause to control the order of rows. If you don’t do so, you will get
> an unpredictable result set.
2019-03-21 17:12:03 +01:00
Alberto
b36e102d01
Merge pull request #3396 from consul/proposals-rake
...
Add rake to move external_url to description
2019-03-21 16:04:37 +01:00
decabeza
ab8f04a71e
Add updated_at to proposals rake
2019-03-21 14:15:07 +01:00
decabeza
832f0c40a8
Add rake to move external_url to description
...
This rake move this field for Proposals and Legislation proposals.
2019-03-21 14:14:50 +01:00
Javier Martín
1fb110259e
Merge pull request #3380 from consul/backport-rubocop_files
...
Enable rubocop rules in config and seed files
2019-03-20 15:36:26 +01:00
Javier Martín
3347776a65
Merge pull request #3379 from consul/backport-erb_lint
...
Add ERB Lint configuration file
2019-03-20 15:36:00 +01:00
Javi Martín
f30afab9e3
Add ERB Lint configuration file
...
The rubocop linter cannot use the `rubocop_config` option because it's
not compatible with Ruby 2.3. So we're setting the rubocop rules
manually.
2019-03-20 14:35:40 +01:00
Javi Martín
002599231f
Enable rubocop rules in config and seed files
...
We were unintentionally ignoring them while trying to ignore just the
schema file, migration files, and initializers generated with `rails
generate`
2019-03-20 14:34:04 +01:00
Javier Martín
0fd9570ea8
Merge pull request #3384 from consul/backport-simplify_poll_factories
...
Simplify poll factories
2019-03-20 14:32:47 +01:00
Julian Nicolas Herrero
f4de8fd42a
Merge pull request #3387 from consul/admin_settings_improvement
...
Improve Admin settings section
2019-03-20 11:10:02 +01:00