consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
19,715 Commits 1 Branch 0 Tags
d3a039040cdfa6b4dc1bafbdbadd97f2fa5229b4
Commit Graph

19715 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sebastia
d3a039040c Merge pull request #5722 from consuldemocracy/dependabot/bundler/rubocop-rails-2.26.2 
Bump rubocop-rails from 2.25.1 to 2.26.2
 2024-10-10 15:03:08 +02:00
Sebastia
c529fec80f Merge pull request #5705 from consuldemocracy/dependabot/bundler/rubocop-1.66.1 
Bump rubocop from 1.64.1 to 1.66.1
 2024-10-10 15:01:56 +02:00
Sebastia
a51bf2fa48 Merge pull request #5716 from consuldemocracy/dependabot/bundler/exiftool_vendored-12.97.0 
Bump exiftool_vendored from 12.80.0 to 12.97.0
 2024-10-10 15:01:14 +02:00
Sebastia
7015e9e070 Merge pull request #5735 from consuldemocracy/dependabot/bundler/groupdate-6.5.1 
Bump groupdate from 6.4.0 to 6.5.1
 2024-10-10 15:00:53 +02:00
taitus
29df39b2fa Add an apply Rails/CompactBlank rubocop rule 
In rubocop-rails 2.26.0, the Rails/CompactBlank rule was modified to handle
cases where select(&:present?) is used. After identifying three occurrences
in our code, we've decided to apply this rule as it encourages the use of the
more efficient and clearer method, compact_blank.

By using compact_blank, we improve code clarity and performance, as this method performs the same operation but in a more optimized way.
 2024-10-10 10:02:22 +02:00
taitus
c50452aec6 Add and apply Rails/EnumHash rubocop rule 
In rubocop-rails 2.26.0, support was added for Rails 7 syntax in the
Rails/EnumHash rule. We took this opportunity to ensure consistency
by converting all enums to hash with integer values. This format minimizes
the risk of data consistency issues in the database when adding new values.
 2024-10-10 09:56:44 +02:00
taitus
3d4f78a424 Add an apply Rails/EnumSyntax rubocop rule 
This rule was added in rubocop-rails 2.26.0. Applying it allows
us to anticipate the deprecation of the current enum syntax
using keyword arguments, which is set to be removed in Rails
8.0, as mentioned in the rule's own documentation:

https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsenumsyntax
 2024-10-10 09:55:48 +02:00
dependabot[bot]
9283b8b422 Bump rubocop-rails from 2.25.1 to 2.26.2 
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.25.1 to 2.26.2.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.25.1...v2.26.2)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-10 09:55:44 +02:00
taitus
4dcac5bed5 Add and apply Naming/RescuedExceptionsVariableName rubocop rule 
This rule was introduced in RuboCop 0.67.2, but now after seeing a fix in version 1.65.1,
we have decided to add it. The reason for adding it is to ensure consistency in how we
reference exceptions throughout the project, by following a standard naming convention
for exception variables.
 2024-10-10 09:47:47 +02:00
taitus
6b15a073a2 Add and apply Style/RedundantRegexpArgument RuboCop rule 
This rule was introduced in RuboCop 1.53.0. After adding the
Style/RedundantRegexpCharacterClass rule in the previous commit,
RuboCop started detecting redundant regular expression arguments.
Therefore, we apply this rule to remove them and prevent future
occurrences.
 2024-10-10 09:47:47 +02:00
Sebastia
4382861cd5 Merge pull request #5717 from consuldemocracy/dependabot/bundler/rubocop-rspec-3.1.0 
Bump rubocop-rspec from 3.0.3 to 3.1.0
 2024-10-10 09:23:41 +02:00
dependabot[bot]
edee2afc1e Bump exiftool_vendored from 12.80.0 to 12.97.0 
Bumps [exiftool_vendored](https://github.com/exiftool-rb/exiftool_vendored.rb) from 12.80.0 to 12.97.0.
- [Commits](https://github.com/exiftool-rb/exiftool_vendored.rb/compare/v12.80.0...v12.97.0)

---
updated-dependencies:
- dependency-name: exiftool_vendored
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-09 13:15:39 +00:00
dependabot[bot]
c8eda160d4 Bump groupdate from 6.4.0 to 6.5.1 
Bumps [groupdate](https://github.com/ankane/groupdate) from 6.4.0 to 6.5.1.
- [Changelog](https://github.com/ankane/groupdate/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/groupdate/compare/v6.4.0...v6.5.1)

---
updated-dependencies:
- dependency-name: groupdate
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-09 10:25:44 +00:00
taitus
d94eed8628 Add and apply Style/RedundantRegexpCharacterClass rubocop rule 
This rule was introduced in RuboCop 0.93.0, but now after seeing a fix in version 1.65,
we have decided to add it. The reason for adding it is to simplify our regular
expressions. This enforcement will help us maintain better regular expression
practices across the project.
 2024-10-09 09:33:35 +02:00
taitus
9300fe5a58 Add an apply RSpec/StringAsInstanceDoubleConstant rubocop rule 
This rule was added in 3.1.0. Applying it allows you to start defining a way of doing
this in the project, helping to maintain consistency.
 2024-10-08 18:43:07 +02:00
dependabot[bot]
0b9aeedbcc Bump rubocop from 1.64.1 to 1.66.1 
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.64.1 to 1.66.1.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.64.1...v1.66.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-08 16:29:52 +00:00
Sebastia
2158644ca7 Merge pull request #5719 from consuldemocracy/dependabot/bundler/rubocop-performance-1.22.1 
Bump rubocop-performance from 1.21.1 to 1.22.1
 2024-10-08 18:28:40 +02:00
dependabot[bot]
a679bb8bf3 Bump rubocop-performance from 1.21.1 to 1.22.1 
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.21.1 to 1.22.1.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.21.1...v1.22.1)

---
updated-dependencies:
- dependency-name: rubocop-performance
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-08 17:54:04 +02:00
Javi Martín
349cdbfebe Merge pull request #5731 from consuldemocracy/video_url_warning 
Fix warning in hidden proposals spec
 2024-10-07 16:51:12 +02:00
Javi Martín
af0911a8d2 Fix warning in hidden proposals spec 
We were checking the proposal video URL, but its value was `nil` since
commit bedcb5bca2. This resulted in a warning:

```
Checking for expected text of nil is confusing and/or pointless since it
will always match. Please specify a string or regexp instead.
spec/system/admin/hidden_proposals_spec.rb:14
```
 2024-10-07 16:37:13 +02:00
Javi Martín
aa5c244414 Merge pull request #5530 from consuldemocracy/unify_database_config_files 
Unify database configuration files
 2024-10-07 15:44:45 +02:00
Javi Martín
170530e52e Unify database configuration files 
We had three files that were almost identical, and we can use
environment variables to specify the differences.

Note we're using the `PGUSER` and `PGPASSWORD` variables, since these
variables will automatically be used by the PostgreSQL client when we
have a blank `username` and `password` keys in the `database.yml` file
(which we did until now). The difference between these variables and the
`POSTGRES_USER` and `POSTGRES_PASSWORD` variables is that the `PG`
variables are used by the client connecting to the database, while the
`POSTGRES_` variables are used by the Docker postgresql image when
creating the database superuser.

For consistency with the code in our github workflows (and everywhere
else in the postgres world), we're respecting this double standard. The
fact that there are two different names for what's basically the same
thing makes the code confusing, though, particularly when running the
docker-compose commands, since we get the password from an environment
variable but we have to assign two different environment variables with
it.

So we're accepting both `PGPASSWORD` and `POSTGRES_PASSWORD` variables
in the database configuration file. This way, developers using
docker-compose can use `POSTGRES_PASSWORD` for everything and it'll work
fine. We're also making `PGPASSWORD` default to `POSTGRES_PASSWORD` so
we don't get a warning if we only set `POSTGRES_PASSWORD`:

```
WARN[0000] The "PGPASSWORD" variable is not set. Defaulting to a blank
string.
```

Also note we're using `DB_HOST` instead of `PGHOST` because that's the
variable Rails currently uses by default for new applications [1].

Finally, note we're using `.presence` in the `ENV` calls in the
database.yml file. The `PGPASSWORD` variable was set to an empty string
when running docker-compose, so using `ENV["PGPASSWORD"] ||` wouldn't
work.

[1] https://github.com/rails/rails/blob/c90a8701e5/railties/lib/rails/generators/rails/app/templates/config/databases/postgresql.yml.tt#L22
 2024-10-07 15:23:40 +02:00
Javi Martín
58bdd8b31c Merge pull request #5657 from consuldemocracy/dependabot/bundler/paranoia-3.0.0 
Bump paranoia from 2.6.3 to 3.0.0
 2024-10-06 03:18:51 +02:00
Javi Martín
1781b9bee2 Merge pull request #5520 from consuldemocracy/dependabot/npm_and_yarn/jquery-ui-1.13.3 
Bump jquery-ui from 1.13.2 to 1.13.3
 2024-10-06 03:05:18 +02:00
dependabot[bot]
8c217e8158 Bump paranoia from 2.6.3 to 3.0.0 
Bumps [paranoia](https://github.com/rubysherpas/paranoia) from 2.6.3 to 3.0.0.
- [Release notes](https://github.com/rubysherpas/paranoia/releases)
- [Changelog](https://github.com/rubysherpas/paranoia/blob/core/CHANGELOG.md)
- [Commits](https://github.com/rubysherpas/paranoia/compare/v2.6.3...v3.0.0)

---
updated-dependencies:
- dependency-name: paranoia
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-06 00:56:57 +00:00
dependabot[bot]
b9ba50e95b Bump jquery-ui from 1.13.2 to 1.13.3 
Bumps [jquery-ui](https://github.com/jquery/jquery-ui) from 1.13.2 to 1.13.3.
- [Release notes](https://github.com/jquery/jquery-ui/releases)
- [Commits](https://github.com/jquery/jquery-ui/compare/1.13.2...1.13.3)

---
updated-dependencies:
- dependency-name: jquery-ui
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-06 02:49:38 +02:00
Javi Martín
c3e011cd2e Merge pull request #5663 from consuldemocracy/dependabot/bundler/audited-5.7.0 
Bump audited from 5.4.3 to 5.7.0
 2024-10-06 02:46:54 +02:00
Javi Martín
24dc3b14e1 Merge pull request #5561 from consuldemocracy/dependabot/bundler/cancancan-3.6.1 
Bump cancancan from 3.5.0 to 3.6.1
 2024-10-06 02:39:23 +02:00
dependabot[bot]
192db916bd Bump audited from 5.4.3 to 5.7.0 
Bumps [audited](https://github.com/collectiveidea/audited) from 5.4.3 to 5.7.0.
- [Changelog](https://github.com/collectiveidea/audited/blob/main/CHANGELOG.md)
- [Commits](https://github.com/collectiveidea/audited/compare/v5.4.3...v5.7.0)

---
updated-dependencies:
- dependency-name: audited
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-06 00:25:59 +00:00
dependabot[bot]
3892584c31 Bump cancancan from 3.5.0 to 3.6.1 
Bumps [cancancan](https://github.com/CanCanCommunity/cancancan) from 3.5.0 to 3.6.1.
- [Release notes](https://github.com/CanCanCommunity/cancancan/releases)
- [Changelog](https://github.com/CanCanCommunity/cancancan/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/CanCanCommunity/cancancan/commits)

---
updated-dependencies:
- dependency-name: cancancan
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-06 00:14:44 +00:00
Javi Martín
27e1af1bb8 Merge pull request #5720 from consuldemocracy/dependabot/bundler/rspec-rails-7.0.1 
Bump rspec-rails from 6.1.3 to 7.0.1
 2024-10-06 01:56:04 +02:00
dependabot[bot]
6fe222148c Bump rspec-rails from 6.1.3 to 7.0.1 
Bumps [rspec-rails](https://github.com/rspec/rspec-rails) from 6.1.3 to 7.0.1.
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md)
- [Commits](https://github.com/rspec/rspec-rails/compare/v6.1.3...v7.0.1)

---
updated-dependencies:
- dependency-name: rspec-rails
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-06 01:41:30 +02:00
Javi Martín
0d85d7a1b9 Merge pull request #5726 from consuldemocracy/dependabot/npm_and_yarn/stylelint-scss-6.7.0 
Bump stylelint-scss from 6.3.2 to 6.7.0
 2024-10-05 22:03:54 +02:00
dependabot[bot]
116e3e12d3 Bump stylelint-scss from 6.3.2 to 6.7.0 
This version includes a new rule `load-partial-extension` which replaces
the now-deprecated `at-import-partial-extension` rule.

Bumps [stylelint-scss](https://github.com/stylelint-scss/stylelint-scss) from 6.3.2 to 6.7.0.
- [Release notes](https://github.com/stylelint-scss/stylelint-scss/releases)
- [Changelog](https://github.com/stylelint-scss/stylelint-scss/blob/master/CHANGELOG.md)
- [Commits](https://github.com/stylelint-scss/stylelint-scss/compare/v6.3.2...v6.7.0)

---
updated-dependencies:
- dependency-name: stylelint-scss
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-05 21:33:22 +02:00
Javi Martín
c02323f043 Merge pull request #5714 from consuldemocracy/dependabot/bundler/uglifier-4.2.1 
Bump uglifier from 4.2.0 to 4.2.1
 2024-10-05 21:27:33 +02:00
dependabot[bot]
cd53afb3d0 Bump uglifier from 4.2.0 to 4.2.1 
Bumps [uglifier](https://github.com/lautis/uglifier) from 4.2.0 to 4.2.1.
- [Changelog](https://github.com/lautis/uglifier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/lautis/uglifier/compare/v4.2.0...v4.2.1)

---
updated-dependencies:
- dependency-name: uglifier
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-05 19:06:26 +00:00
Javi Martín
8b0a2518c7 Merge pull request #5715 from consuldemocracy/dependabot/bundler/pg-1.5.8 
Bump pg from 1.5.6 to 1.5.8
 2024-10-05 21:04:20 +02:00
dependabot[bot]
d7f7569ac6 Bump pg from 1.5.6 to 1.5.8 
Bumps [pg](https://github.com/ged/ruby-pg) from 1.5.6 to 1.5.8.
- [Changelog](https://github.com/ged/ruby-pg/blob/master/History.md)
- [Commits](https://github.com/ged/ruby-pg/compare/v1.5.6...v1.5.8)

---
updated-dependencies:
- dependency-name: pg
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-05 18:41:52 +00:00
Javi Martín
c00cdb0be0 Merge pull request #5672 from consuldemocracy/dependabot/bundler/pg_search-2.3.7 
Bump pg_search from 2.3.6 to 2.3.7
 2024-10-05 20:40:34 +02:00
Javi Martín
d2aa96341d Merge pull request #5702 from consuldemocracy/dependabot/bundler/selenium-webdriver-4.25.0 
Bump selenium-webdriver from 4.22.0 to 4.25.0
 2024-10-05 20:24:54 +02:00
dependabot[bot]
64e1e78865 Bump pg_search from 2.3.6 to 2.3.7 
Bumps [pg_search](https://github.com/Casecommons/pg_search) from 2.3.6 to 2.3.7.
- [Changelog](https://github.com/Casecommons/pg_search/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Casecommons/pg_search/compare/v2.3.6...v2.3.7)

---
updated-dependencies:
- dependency-name: pg_search
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-05 18:18:45 +00:00
Javi Martín
eb5ec1722d Merge pull request #5677 from consuldemocracy/dependabot/bundler/acts-as-taggable-on-11.0.0 
Bump acts-as-taggable-on from 10.0.0 to 11.0.0
 2024-10-05 20:17:41 +02:00
dependabot[bot]
dc94708ef7 Bump selenium-webdriver from 4.22.0 to 4.25.0 
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.22.0 to 4.25.0.
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES)
- [Commits](https://github.com/SeleniumHQ/selenium/compare/selenium-4.22.0...selenium-4.25.0)

---
updated-dependencies:
- dependency-name: selenium-webdriver
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-05 18:03:10 +00:00
dependabot[bot]
2f7a80b099 Bump acts-as-taggable-on from 10.0.0 to 11.0.0 
Bumps [acts-as-taggable-on](https://github.com/mbleigh/acts-as-taggable-on) from 10.0.0 to 11.0.0.
- [Release notes](https://github.com/mbleigh/acts-as-taggable-on/releases)
- [Changelog](https://github.com/mbleigh/acts-as-taggable-on/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mbleigh/acts-as-taggable-on/compare/v10.0.0...v11.0.0)

---
updated-dependencies:
- dependency-name: acts-as-taggable-on
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-05 17:55:09 +00:00
Javi Martín
688640c96d Merge pull request #5675 from consuldemocracy/dependabot/bundler/wkhtmltopdf-binary-0.12.6.8 
Bump wkhtmltopdf-binary from 0.12.6.6 to 0.12.6.8
 2024-10-05 19:54:09 +02:00
Javi Martín
e29d27a54c Merge pull request #5674 from consuldemocracy/dependabot/bundler/capistrano-bundler-2.1.1 
Bump capistrano-bundler from 2.1.0 to 2.1.1
 2024-10-05 19:48:43 +02:00
dependabot[bot]
211cb85469 Bump wkhtmltopdf-binary from 0.12.6.6 to 0.12.6.8 
Bumps [wkhtmltopdf-binary](https://github.com/zakird/wkhtmltopdf_binary_gem) from 0.12.6.6 to 0.12.6.8.
- [Release notes](https://github.com/zakird/wkhtmltopdf_binary_gem/releases)
- [Changelog](https://github.com/zakird/wkhtmltopdf_binary_gem/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zakird/wkhtmltopdf_binary_gem/commits)

---
updated-dependencies:
- dependency-name: wkhtmltopdf-binary
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-05 17:30:37 +00:00
dependabot[bot]
89b634f7ed Bump capistrano-bundler from 2.1.0 to 2.1.1 
Bumps [capistrano-bundler](https://github.com/capistrano/bundler) from 2.1.0 to 2.1.1.
- [Release notes](https://github.com/capistrano/bundler/releases)
- [Commits](https://github.com/capistrano/bundler/compare/v2.1.0...v2.1.1)

---
updated-dependencies:
- dependency-name: capistrano-bundler
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-05 17:25:18 +00:00
Javi Martín
0544a3791f Merge pull request #5668 from consuldemocracy/dependabot/bundler/delayed_job_active_record-4.1.10 
Bump delayed_job_active_record from 4.1.8 to 4.1.10
 2024-10-05 19:23:32 +02:00
dependabot[bot]
08a110a106 Bump delayed_job_active_record from 4.1.8 to 4.1.10 
Bumps [delayed_job_active_record](https://github.com/collectiveidea/delayed_job_active_record) from 4.1.8 to 4.1.10.
- [Release notes](https://github.com/collectiveidea/delayed_job_active_record/releases)
- [Commits](https://github.com/collectiveidea/delayed_job_active_record/compare/v4.1.8...v4.1.10)

---
updated-dependencies:
- dependency-name: delayed_job_active_record
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-10-05 17:00:24 +00:00