Commit Graph

5295 Commits

Author SHA1 Message Date
María Checa
bc363289ad Added translations to link text 2018-01-10 12:19:48 +01:00
María Checa
a06abf7650 Removed unnecessary code 2018-01-10 11:57:23 +01:00
María Checa
eda673a85d Restored missing code 2018-01-10 11:57:13 +01:00
decabeza
27c4abf552 improve i18n for budgets notices 2018-01-10 11:37:05 +01:00
Bertocq
334091710c Refactor price & explanation showing logic at Investment model 2018-01-10 11:26:16 +01:00
Bertocq
21d6ce57c5 Add published_prices? helper method and phases constant at Budget model 2018-01-10 01:15:07 +01:00
Bertocq
f3a7de55ea Rename should_show_price_info? to should_show_price_explanation? at Budget::Investment & usage 2018-01-10 01:13:34 +01:00
Bertocq
922318b978 Add publishing prices phase to budget model, plus translation texts 2018-01-10 01:10:57 +01:00
Bertocq
d8ceff1a53 Refactor Budget's on hold phases to constant, plus alignments 2018-01-10 01:09:13 +01:00
decabeza
13ea6bdd6b add i18n and fix layout for download current selection 2018-01-09 19:39:51 +01:00
decabeza
65d682901b fixes vertical align on support/price on index list 2018-01-09 19:32:40 +01:00
decabeza
952869b5b6 fixes typo 2018-01-09 19:32:40 +01:00
decabeza
271c6869cd hide budget investment table heading if no results 2018-01-09 19:32:40 +01:00
decabeza
3c8ec4169f improves messages on header 2018-01-09 19:29:36 +01:00
decabeza
5fb49c7adf reorders elements like proposals/show 2018-01-09 19:29:36 +01:00
decabeza
c44a1c57af shows supports number on bold 2018-01-09 19:29:36 +01:00
decabeza
47194205bf fixes author actions on sidebar 2018-01-09 19:29:36 +01:00
decabeza
979d9d071b adds help text for population field on admin budgets groups 2018-01-09 19:29:36 +01:00
decabeza
bba19d1fd5 fixes label name of group on admin budgets groups 2018-01-09 19:29:36 +01:00
Raúl Fuentes
29018e3062 changes made at the request of voodoorai2000 2018-01-09 13:08:03 +01:00
Raúl Fuentes
b3461b2051 final details 2018-01-09 12:45:30 +01:00
Raúl Fuentes
56f4c3c3b9 added test to csv download and style corrections 2018-01-09 12:45:30 +01:00
Raúl Fuentes
95c1aa43e8 added csv download link to budget_investments (issue 1625) 2018-01-09 12:45:30 +01:00
María Checa
c27e6ab1d1 Merge pull request #2223 from wairbut-m2c/iagirre-prevent-edition-if-budget-final-phase
Prevent edition of investments if budget is in the final phase
2018-01-09 12:18:23 +01:00
María Checa
96859190be Merge pull request #2280 from consul/2277-budgets_new_form
Budgets new form
2018-01-09 11:55:10 +01:00
BertoCQ
6e96c8c057 Merge branch 'master' into feature/2275#destroy_budgets 2018-01-09 11:03:51 +01:00
BertoCQ
01c41c7cca Merge pull request #2284 from consul/feature/2276#admin_budget_edit_redirect
Redirect admin to budget lists after edit
2018-01-09 10:50:54 +01:00
María Checa
385db76a24 Changed location attribute label text 2018-01-08 23:23:02 +01:00
María Checa
5161988844 Removed external_url input 2018-01-08 23:22:46 +01:00
Bertocq
4916f9a3c3 Avoid listing non-published Budgets to the public
Why:

Non-admins shouldn't be aware of non-published Budgets

How:

Using the budget_published? helper method
2018-01-08 23:02:18 +01:00
Bertocq
76e05d58b1 Return 404 status for non-published Budget access
Why:

Non-admin users shouldn't be able to access, or know of the existence
of a non-published Budget.

How:

Raising an ActionController::RoutingError (404 error) to simulate the
same behaviour as accesing a non-existing Budget.

We could have used CanCanCan abilities for this but then an user could
be aware of existing but not published Budgets by trying different urls
2018-01-08 22:59:20 +01:00
Bertocq
03f4fce2dd Add budget_published? helper method to BudgetHelper
We need to check if the budget is in drafting phase to avoid showing
it to the users, unless the current user is an administrator.
2018-01-08 22:56:47 +01:00
Bertocq
f9803ce9ca Add drafting phase to budget model & translations 2018-01-08 22:56:11 +01:00
Bertocq
03e1481fb1 Redirect admin to budget lists after editing a budget 2018-01-08 18:47:09 +01:00
Raimond Garcia
05031dffa1 Merge pull request #2202 from wairbut-m2c/aperez-social-metatags
Use 'image_url' properties to improve SEO for proposals & investments
2018-01-08 18:33:07 +01:00
Bertocq
799b96cc40 Add destroy action to admin budget controller 2018-01-08 18:21:45 +01:00
Bertocq
dd3a0add2a Add destroy budget button to admin budget edit view 2018-01-08 17:48:46 +01:00
Raimond Garcia
bce0729a61 Merge pull request #1899 from xarlybovi/legislation-process-html-fixes
Legislation process minor html fixes
2018-01-08 16:00:26 +01:00
Bertocq
18236e8827 Fix random order seed value cleanup to allow negative values and always be numeric 2018-01-06 18:21:24 +01:00
Bertocq
327817ff36 Update version on install controller (late) 2018-01-03 21:07:19 +01:00
Bertocq
d3719f0b42 Merge branch 'fix/documentable_multiple_docs' 2018-01-03 18:03:20 +01:00
Bertocq
b990384b0a Fix multiple attachment upload by setting the id, style and updated at date on hash 2018-01-03 17:38:44 +01:00
Bertocq
ce9d5ec022 Cleanup bad indentation on direct upload model 2018-01-03 17:38:44 +01:00
Bertocq
d7d1a85fbb Refactor documents and document view partials 2018-01-02 13:32:42 +01:00
Bertocq
46dc559301 Filter out nil related contents while listing them 2017-12-31 20:30:45 +01:00
iagirre
64aaa97d86 Add feature specs to check that edit links and "Selected" buttons are not displayed/enabled.
"Selected" button appears as text instead of dissapearing completely.
2017-12-27 16:23:21 +01:00
iagirre
ec8715efd3 Budget investments cannot be edited when budget is finished. Only milestones can be managed. 2017-12-27 12:15:38 +01:00
rgarcia
96066aee44 Validates map presence only on create
As we are using an attr_accessor to make sure a user accepts that the
proposal “has no map”, the validation was being run in every save.

Making other things break, for example the updating of the counter
cache `cached_votes_up`, when someone voted for the proposal, as the
attr_accessor `skip_map` was not present
2017-12-26 12:39:29 +01:00
decabeza
f95d5d4639 improves generic error message 2017-12-22 12:32:34 +01:00
BertoCQ
d534b02b3c Merge pull request #2206 from consul/related-contents-score
Related contents score
2017-12-20 15:13:12 +01:00