consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
17,600 Commits 1 Branch 0 Tags
ae6e0a4ddb567b6380f76790e18aa6b51adf54f4
Commit Graph

17600 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Javi Martín
ae6e0a4ddb Fix Gemfile.lock 
We accidentally introduced a dependency incompatibility in commit
342a0fd97. For some reason, Bundler didn't detect it immediately on
either my machine or our CI.
 2022-08-26 15:17:34 +02:00
Javi Martín
c5b20e03ce Merge pull request #4958 from consul/dependabot/bundler/master/rspec-rails-5.1.2 
Bump rspec-rails from 5.0.1 to 5.1.2
 2022-08-26 15:04:36 +02:00
Javi Martín
afd20493cf Merge pull request #4941 from consul/reversible_migration_cop 
Fix Rails/ReversibleMigration rule offenses
 2022-08-26 14:58:45 +02:00
Javi Martín
b756a2173f Merge pull request #4956 from consul/dependabot/bundler/master/i18n-tasks-1.0.11 
Bump i18n-tasks from 0.9.34 to 0.9.37
 2022-08-26 14:53:33 +02:00
dependabot[bot]
bf3fdf151e Bump rspec-rails from 5.0.1 to 5.1.2 
Bumps [rspec-rails](https://github.com/rspec/rspec-rails) from 5.0.1 to 5.1.2.
- [Release notes](https://github.com/rspec/rspec-rails/releases)
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md)
- [Commits](https://github.com/rspec/rspec-rails/compare/v5.0.1...v5.1.2)

---
updated-dependencies:
- dependency-name: rspec-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-26 14:43:26 +02:00
dependabot[bot]
342a0fd97e Bump i18n-tasks from 0.9.34 to 0.9.37 
Bumps [i18n-tasks](https://github.com/glebm/i18n-tasks) from 0.9.34 to 0.9.37.
- [Release notes](https://github.com/glebm/i18n-tasks/releases)
- [Changelog](https://github.com/glebm/i18n-tasks/blob/main/CHANGES.md)
- [Commits](https://github.com/glebm/i18n-tasks/compare/v0.9.34...v0.9.37)

---
updated-dependencies:
- dependency-name: i18n-tasks
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-26 14:26:15 +02:00
Sebastia
7f29582faa Merge pull request #4963 from consul/remove-unused-translations 
Remove unused translations
 2022-08-26 13:50:03 +02:00
Javi Martín
567c2ed34f Merge pull request #4960 from consul/dependabot/bundler/master/webdrivers-4.7.0 
Bump webdrivers from 4.6.0 to 4.7.0
 2022-08-26 13:32:48 +02:00
Javi Martín
013fca1e31 Merge pull request #4959 from consul/dependabot/bundler/master/jquery-rails-4.5.0 
Bump jquery-rails from 4.4.0 to 4.5.0
 2022-08-26 13:32:31 +02:00
taitus
8b6d7bfa44 Remove unused translations 2022-08-26 13:29:17 +02:00
dependabot[bot]
ca8ccef27d Bump jquery-rails from 4.4.0 to 4.5.0 
Bumps [jquery-rails](https://github.com/rails/jquery-rails) from 4.4.0 to 4.5.0.
- [Release notes](https://github.com/rails/jquery-rails/releases)
- [Changelog](https://github.com/rails/jquery-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rails/jquery-rails/compare/v4.4.0...v4.5.0)

---
updated-dependencies:
- dependency-name: jquery-rails
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-26 13:10:59 +02:00
dependabot[bot]
6038af9216 Bump webdrivers from 4.6.0 to 4.7.0 
Bumps [webdrivers](https://github.com/titusfortner/webdrivers) from 4.6.0 to 4.7.0.
- [Release notes](https://github.com/titusfortner/webdrivers/releases)
- [Changelog](https://github.com/titusfortner/webdrivers/blob/main/CHANGELOG.md)
- [Commits](https://github.com/titusfortner/webdrivers/compare/v4.6.0...v4.7.0)

---
updated-dependencies:
- dependency-name: webdrivers
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-26 13:06:01 +02:00
Javi Martín
7fbb6daf3c Merge pull request #4947 from consul/dependabot/bundler/master/audited-5.0.2 
Bump audited from 5.0.1 to 5.0.2
 2022-08-26 13:05:12 +02:00
dependabot[bot]
7c8581d74e Bump audited from 5.0.1 to 5.0.2 
Bumps [audited](https://github.com/collectiveidea/audited) from 5.0.1 to 5.0.2.
- [Release notes](https://github.com/collectiveidea/audited/releases)
- [Changelog](https://github.com/collectiveidea/audited/blob/master/CHANGELOG.md)
- [Commits](https://github.com/collectiveidea/audited/compare/v5.0.1...v5.0.2)

---
updated-dependencies:
- dependency-name: audited
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-26 12:47:12 +02:00
Javi Martín
163fd101e5 Merge pull request #4940 from consul/dependabot/bundler/master/view_component-2.69.0 
Bump view_component from 2.49.1 to 2.69.0
 2022-08-25 23:49:23 +02:00
dependabot[bot]
8fc8ac4c26 Bump view_component from 2.49.1 to 2.69.0 
Bumps [view_component](https://viewcomponent.org) from 2.49.1 to 2.69.0.

---
updated-dependencies:
- dependency-name: view_component
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 23:19:11 +02:00
Javi Martín
5b7a969964 Fix Rails/ReversibleMigration rule offenses 
We forgot to do so in commit fc757428e, when we upgraded rubocop-rails.
In this upgrade, this rule was changed to include the `change_column`
method.

Just like we did in commit df959b74f, I'm raising an
`ActiveRecord::IrreversibleMigration` exception in migrations done
before version 1.0.0, since making all of them reversible would be too
much work for little benefit.
 2022-08-25 21:36:31 +02:00
Javi Martín
9961a252a8 Merge pull request #4933 from consul/dependabot/bundler/master/acts-as-taggable-on-9.0.1 
Bump acts-as-taggable-on from 8.1.0 to 9.0.1
 2022-08-25 20:46:07 +02:00
dependabot[bot]
23848dded7 Bump acts-as-taggable-on from 8.1.0 to 9.0.1 
Bumps [acts-as-taggable-on](https://github.com/mbleigh/acts-as-taggable-on) from 8.1.0 to 9.0.1.
- [Release notes](https://github.com/mbleigh/acts-as-taggable-on/releases)
- [Changelog](https://github.com/mbleigh/acts-as-taggable-on/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mbleigh/acts-as-taggable-on/compare/v8.1.0...v9.0.1)

---
updated-dependencies:
- dependency-name: acts-as-taggable-on
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 20:30:42 +02:00
Javi Martín
333c51b546 Merge pull request #4939 from consul/dependabot/bundler/master/groupdate-6.1.0 
Bump groupdate from 5.2.2 to 6.1.0
 2022-08-25 20:29:05 +02:00
Javi Martín
367a3921a4 Merge pull request #4925 from consul/dependabot/bundler/master/ancestry-4.2.0 
Bump ancestry from 4.1.0 to 4.2.0
 2022-08-25 20:23:14 +02:00
dependabot[bot]
6e03791732 Bump groupdate from 5.2.2 to 6.1.0 
Bumps [groupdate](https://github.com/ankane/groupdate) from 5.2.2 to 6.1.0.
- [Release notes](https://github.com/ankane/groupdate/releases)
- [Changelog](https://github.com/ankane/groupdate/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/groupdate/compare/v5.2.2...v6.1.0)

---
updated-dependencies:
- dependency-name: groupdate
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 20:09:04 +02:00
Javi Martín
db7eb81be0 Merge pull request #4924 from consul/dependabot/bundler/master/pg_search-2.3.6 
Bump pg_search from 2.3.5 to 2.3.6
 2022-08-25 20:04:41 +02:00
dependabot[bot]
9937dd77bf Bump ancestry from 4.1.0 to 4.2.0 
Bumps [ancestry](https://github.com/stefankroes/ancestry) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/stefankroes/ancestry/releases)
- [Changelog](https://github.com/stefankroes/ancestry/blob/master/CHANGELOG.md)
- [Commits](https://github.com/stefankroes/ancestry/compare/v4.1.0...v4.2.0)

---
updated-dependencies:
- dependency-name: ancestry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 20:00:28 +02:00
Javi Martín
208e8f2783 Merge pull request #4927 from consul/dependabot/bundler/master/letter_opener_web-2.0.0 
Bump letter_opener_web from 1.4.0 to 2.0.0
 2022-08-25 19:56:45 +02:00
dependabot[bot]
0ceaf34c57 Bump pg_search from 2.3.5 to 2.3.6 
Bumps [pg_search](https://github.com/Casecommons/pg_search) from 2.3.5 to 2.3.6.
- [Release notes](https://github.com/Casecommons/pg_search/releases)
- [Changelog](https://github.com/Casecommons/pg_search/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Casecommons/pg_search/compare/v2.3.5...v2.3.6)

---
updated-dependencies:
- dependency-name: pg_search
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 19:46:55 +02:00
Javi Martín
7728a7fc53 Merge pull request #4934 from consul/dependabot/bundler/master/pg-1.4.3 
Bump pg from 1.2.3 to 1.4.3
 2022-08-25 19:45:15 +02:00
dependabot[bot]
be3b09d29e Bump letter_opener_web from 1.4.0 to 2.0.0 
Bumps [letter_opener_web](https://github.com/fgrehm/letter_opener_web) from 1.4.0 to 2.0.0.
- [Release notes](https://github.com/fgrehm/letter_opener_web/releases)
- [Changelog](https://github.com/fgrehm/letter_opener_web/blob/master/CHANGELOG.md)
- [Commits](https://github.com/fgrehm/letter_opener_web/compare/v1.4.0...v2.0.0)

---
updated-dependencies:
- dependency-name: letter_opener_web
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 19:36:54 +02:00
dependabot[bot]
69cba06044 Bump pg from 1.2.3 to 1.4.3 
Bumps [pg](https://github.com/ged/ruby-pg) from 1.2.3 to 1.4.3.
- [Release notes](https://github.com/ged/ruby-pg/releases)
- [Changelog](https://github.com/ged/ruby-pg/blob/master/History.rdoc)
- [Commits](https://github.com/ged/ruby-pg/compare/v1.2.3...v1.4.3)

---
updated-dependencies:
- dependency-name: pg
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 19:25:02 +02:00
Javi Martín
a5fe827530 Merge pull request #4926 from consul/dependabot/bundler/master/knapsack_pro-3.3.1 
Bump knapsack_pro from 3.0.0 to 3.3.1
 2022-08-25 19:23:52 +02:00
dependabot[bot]
5c306e37aa Bump knapsack_pro from 3.0.0 to 3.3.1 
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby) from 3.0.0 to 3.3.1.
- [Release notes](https://github.com/KnapsackPro/knapsack_pro-ruby/releases)
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.0.0...v3.3.1)

---
updated-dependencies:
- dependency-name: knapsack_pro
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 18:47:39 +02:00
Javi Martín
808e333144 Merge pull request #4923 from consul/dependabot/bundler/master/acts_as_votable-0.13.2 
Bump acts_as_votable from 0.13.1 to 0.13.2
 2022-08-25 18:46:48 +02:00
Javi Martín
de0a9979a4 Merge pull request #4928 from consul/dependabot/bundler/master/capistrano-3.17.1 
Bump capistrano from 3.16.0 to 3.17.1
 2022-08-25 18:45:30 +02:00
dependabot[bot]
0c6eee4eff Bump acts_as_votable from 0.13.1 to 0.13.2 
Bumps [acts_as_votable](https://github.com/ryanto/acts_as_votable) from 0.13.1 to 0.13.2.
- [Release notes](https://github.com/ryanto/acts_as_votable/releases)
- [Commits](https://github.com/ryanto/acts_as_votable/compare/v0.13.1...v0.13.2)

---
updated-dependencies:
- dependency-name: acts_as_votable
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 18:23:27 +02:00
Javi Martín
c8f9592b60 Bump capistrano from 3.16.0 to 3.17.1 
Bumps [capistrano](https://github.com/capistrano/capistrano) from 3.16.0 to 3.17.1.
- [Release notes](https://github.com/capistrano/capistrano/releases)
- [Commits](https://github.com/capistrano/capistrano/compare/v3.16.0...v3.17.1)

---
updated-dependencies:
- dependency-name: capistrano
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 18:17:28 +02:00
Javi Martín
7937cc0649 Merge pull request #4930 from consul/dependabot/bundler/master/kaminari-1.2.2 
Bump kaminari from 1.2.1 to 1.2.2
 2022-08-25 18:14:13 +02:00
dependabot[bot]
38bc78273d Bump kaminari from 1.2.1 to 1.2.2 
Bumps [kaminari](https://github.com/kaminari/kaminari) from 1.2.1 to 1.2.2.
- [Release notes](https://github.com/kaminari/kaminari/releases)
- [Changelog](https://github.com/kaminari/kaminari/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kaminari/kaminari/compare/v1.2.1...v1.2.2)

---
updated-dependencies:
- dependency-name: kaminari
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 17:54:36 +02:00
Javi Martín
4b6f3b22bb Merge pull request #4932 from consul/dependabot/bundler/master/foundation_rails_helper-4.0.1 
Bump foundation_rails_helper from 4.0.0 to 4.0.1
 2022-08-25 16:45:17 +02:00
dependabot[bot]
2ff8eac774 Bump foundation_rails_helper from 4.0.0 to 4.0.1 
Bumps [foundation_rails_helper](https://github.com/sgruhier/foundation_rails_helper) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/sgruhier/foundation_rails_helper/releases)
- [Changelog](https://github.com/sgruhier/foundation_rails_helper/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sgruhier/foundation_rails_helper/commits)

---
updated-dependencies:
- dependency-name: foundation_rails_helper
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 16:19:32 +02:00
Javi Martín
6f7c8ba00a Merge pull request #4935 from consul/dependabot/bundler/master/capybara-3.37.1 
Bump capybara from 3.35.3 to 3.37.1
 2022-08-25 16:14:16 +02:00
Javi Martín
ffb7d94c36 Merge pull request #4936 from consul/dependabot/bundler/master/capistrano-bundler-2.1.0 
Bump capistrano-bundler from 2.0.1 to 2.1.0
 2022-08-25 16:05:52 +02:00
dependabot[bot]
019bc52c3f Bump capybara from 3.35.3 to 3.37.1 
Bumps [capybara](https://github.com/teamcapybara/capybara) from 3.35.3 to 3.37.1.
- [Release notes](https://github.com/teamcapybara/capybara/releases)
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md)
- [Commits](https://github.com/teamcapybara/capybara/compare/3.35.3...3.37.1)

---
updated-dependencies:
- dependency-name: capybara
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 15:52:33 +02:00
dependabot[bot]
bbfebaccf9 Bump capistrano-bundler from 2.0.1 to 2.1.0 
Bumps [capistrano-bundler](https://github.com/capistrano/bundler) from 2.0.1 to 2.1.0.
- [Release notes](https://github.com/capistrano/bundler/releases)
- [Commits](https://github.com/capistrano/bundler/compare/v2.0.1...v2.1.0)

---
updated-dependencies:
- dependency-name: capistrano-bundler
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-08-25 15:48:34 +02:00
Javi Martín
3a7a5b2346 Merge pull request #4920 from consul/budget_results_tests 
Fix flaky budget results tests
 2022-08-25 15:32:39 +02:00
Javi Martín
610f378079 Merge pull request #4911 from consul/dependabot/bundler/master/rubocop-rails-2.15.2 
Bump rubocop-rails from 2.11.3 to 2.15.2
 2022-08-25 15:24:06 +02:00
Javi Martín
62b3521a0f Fix flaky budget results test 
We were checking that the price of the investment isn't present on the
page. However, the text "200" could be present in either the title of
the budget or the title of the heading ("Heading 200"), for instance. So
now we're making sure we look for the text on the relevant part of the
page.
 2022-08-25 15:17:19 +02:00
Javi Martín
dce8400775 Use investment titles in budget results tests 
We were getting some failures because sometimes the titles which are
generated automatically (like "Budget Investment 200 title") contained
the price of the investment, and so, when testing the presence of the
price (200, in this case), the test was failing.

So we're adding a custom title to the investments we create during the
tests.
 2022-08-25 14:31:51 +02:00
Javi Martín
969e0014e5 Move budget result test to the model 
We were testing that the `calculate_winners` method does not take the
price into account; we can do the same in a model test. We already have
a different system test to check that the price isn't displayed in the
view.
 2022-08-25 14:31:51 +02:00
Javi Martín
3778b50310 Fix typo in budget results test 2022-08-25 14:31:51 +02:00
Javi Martín
fd147f883a Add extra step in incompatible investments test 
The test was always passing because incompatible investments are only
shown after clicking on the "Show all" link. So now we're clicking the
link  before checking the "incompatibles" table isn't shown.

I don't think "incompatibles" is a valid English word; for now, I'm
leaving it like this until a native English speaker reviews it.
 2022-08-25 14:31:37 +02:00