decabeza
e1e80c3cc9
adds specs
2018-01-29 17:21:42 +01:00
Sergio Castellano Herrera
2905b24ee7
Error to access hide comments
2018-01-29 16:48:48 +01:00
Sergio Castellano Herrera
54753fece4
Error to access hide comments
2018-01-29 16:48:40 +01:00
Alberto García
1207b5ce51
Merge pull request #2279 from wairbut-m2c/aperez-missing-i18n-keys
...
I18n maintenance
2018-01-29 14:02:15 +01:00
BertoCQ
afb1c5da4b
Merge pull request #2393 from consul/paperclip_upgrade
...
Upgrade Paperclip to 5.2.1 for security reasons
2018-01-29 12:04:17 +01:00
Bertocq
4874090799
Update Security section of unreleased at Changelog.md
2018-01-29 11:36:22 +01:00
Bertocq
75a68e8439
Upgrade Paperclip to 5.2.1 for security reasons
2018-01-29 11:08:46 +01:00
Angel Perez
665a5b57ab
Empty instances of MapLocation won't result in a new DB record ( #2220 )
2018-01-26 09:26:48 -04:00
Angel Perez
88a5e8b1d2
Spec: Admins/users can destroy only their authored documentables/imageables ( #2375 )
2018-01-26 09:10:58 -04:00
Bertocq
6d3359dbbc
Fix bad line break
2018-01-26 12:01:22 +01:00
Vicente Mendoza
45a86d0db8
Added test to verify that the search of the tags is only from the current budget
2018-01-26 11:31:14 +01:00
Vicente Mendoza
ff5112f96b
Changed the budgets helper so just search for the current budget
2018-01-26 11:30:02 +01:00
Bertocq
5e583d2015
Increase notifiable access security on add notification method
2018-01-26 11:24:13 +01:00
Bertocq
f4ad0b2979
Improve add_notification logic to add notificable author
2018-01-26 00:33:07 +01:00
Bertocq
070c94494e
Fix linelenght over 100 on multiple files
2018-01-26 00:27:03 +01:00
Bertocq
34b2a27357
Cleanup indentation and line lenght aat order select partial
2018-01-25 18:06:36 +01:00
Bertocq
9b2aebc8c2
Remove closing </li>'s without opening <li>
2018-01-25 17:54:15 +01:00
iagirre
b3dec1897e
Feature spec to test that the budget_investment is not been deleted if the user dismisses the confirm dialog
2018-01-25 16:54:26 +01:00
iagirre
f2927c8eb2
Add alert to the delete button of 'My activity' section so that users don't delete their investmentes accidentally
2018-01-25 16:54:26 +01:00
Alberto García
6918bd699c
Merge pull request #2384 from consul/fix-texts
...
Fix i18n texts
2018-01-25 16:09:36 +01:00
decabeza
f06ef1ac91
updates spanish translations of budgets
2018-01-25 14:41:16 +01:00
decabeza
1d7352d21c
fixes textarea and label order on admin budgets phases form
2018-01-25 14:40:04 +01:00
decabeza
f607075c4a
replaces hardcoded text to votes_for_proposal_success setting
2018-01-25 14:39:13 +01:00
Angel Perez
716fd6a46e
Persist sorting when filtering/selecting investments
2018-01-25 08:18:04 -04:00
Angel Perez
e04dc5b8f2
Add sorting options for Admin::BudgetInvestments ( #2336 )
2018-01-25 08:18:04 -04:00
Angel Perez
d30d2b0dd8
Arrange Admin::BudgetInvestments I18n for buttons under same namespace
2018-01-25 08:18:04 -04:00
Angel Perez
680ca46ef1
Add search form for Admin::BudgetInvestments ( #2336 )
2018-01-25 08:16:32 -04:00
María Checa
c08edf044d
Updated changelog
2018-01-25 11:57:37 +01:00
María Checa
e875ba1f33
Merge pull request #2379 from consul/advanced-filters-design
...
Advanced filters design
2018-01-25 11:53:07 +01:00
decabeza
c2ff1f6cff
fixes scss lint warning
2018-01-25 11:14:06 +01:00
decabeza
12fbd50fc4
updates specs
2018-01-25 11:14:06 +01:00
decabeza
acfd49e5bd
improves styles for budget investments advanced filters
2018-01-25 11:14:06 +01:00
Bertocq
c01c08a3f4
Use current_budget directly instead of instance variable
2018-01-25 00:48:52 +01:00
Bertocq
8749b46ec4
Remove budget_published? usage on budget index, drafting budgets no longer listed
2018-01-25 00:48:52 +01:00
Bertocq
791f081a91
Rename @budget to @current budget at budget index
...
Clear instance variable names help understand what's going around when
you're deep 2 or 3 partials. In this case @budget is only used to carry
around the current_budget so @current_budget is more descriptive.
Using `current_budget` directly around would be an alternative, but
maybe not as maintainable in case we want to change which budget is
being shown (for example the drafting one if you're admin).
2018-01-25 00:48:52 +01:00
Bertocq
e62ca48a94
Show only finished budgets at budget's index
...
We only need finished budget's at budget's index "Finished budgets"
section. So we add the `finished` scope to @budgets variable, and rename
it so its clear what it contains.
Also avoid showing the "Finished budgets" section if there is none
2018-01-25 00:48:52 +01:00
Bertocq
e5cff2fb60
Make budget feature spec comply with 100 linelenght
2018-01-25 00:48:52 +01:00
Bertocq
bc3c92acb4
Remove no longer valid drafting budget scenarios
...
Drafting budgets will no longer be listed under any conditions at the
budget index... not even as "current" budget.
2018-01-25 00:48:52 +01:00
Bertocq
210032e1ce
Expect finished budget be listed at budget index
...
But only finished budgets should be listed here, not drafting ones,
neither current ones.
2018-01-25 00:48:31 +01:00
Bertocq
d692ff781a
Refactor Budget feature spec Index scenario
...
Budget's home page has changed, no longer we'll be showing a list of
active budgets, but only one current (open) budget and a list of
finished ones.
So no need to create 3 budgets in a row, but a finished budget (because
we already have a valid budget created)
2018-01-24 22:00:03 +01:00
Bertocq
62d7d08a10
Remove no longer valid scenarios: image&doc removal by admin
2018-01-24 21:50:13 +01:00
Bertocq
43c8506f84
Remove deprecated expecations about admin image&doc destroyal
2018-01-24 21:42:20 +01:00
Bertocq
6dcd01366c
Preven admins from destroying others images&docs
2018-01-24 17:07:13 +01:00
Bertocq
97ec551178
Correctly check if user can destroy a document
2018-01-24 17:07:05 +01:00
Bertocq
d6a6b99624
Fix rare flaky test, expect a price not just the number
2018-01-24 15:06:40 +01:00
Bertocq
e0abb86267
Update specs for new heading options naming rules
...
* Update budget heading order scenario to check new option name rules
* Update other scenarios that were expecting old heading naming convention
2018-01-24 14:15:10 +01:00
Bertocq
31956312bf
Make use of new single_heading_group? on existing similar logic
2018-01-24 12:17:46 +01:00
Bertocq
ce3bf20152
Add group name on heading options if more than one heading per group
2018-01-24 12:15:56 +01:00
Bertocq
9bb088a5c7
Add single_heading_group? helper at Budget::Group model
2018-01-24 12:15:43 +01:00
Bertocq
18a5bc6642
Make English the default locale
2018-01-24 11:37:43 +01:00
