consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
15,242 Commits 1 Branch 0 Tags
9694def11a94de68b1bed47e2dcee4fe14c65eb4
Commit Graph

7804 Commits

Author SHA1 Message Date
Javi Martín
d5d800f75c Simplify SORTING_OPTIONS usage 
Using a hash instead of an array of hashes makes accessing its keys and
values much easier.
 2019-01-10 16:11:51 +01:00
Javi Martín
68fb295db5 Use if blocks instead of two ternary operators 
Using a simple ternary operator is usually fine; however, code combining
two ternary operator is a bit hard to follow.
 2019-01-10 16:11:51 +01:00
Javi Martín
eb6bba52e3 Simplify code 
The string inside `params[:direction]` should already use lowercase
characters.
 2019-01-10 16:11:51 +01:00
Javi Martín
814579d58f Simplify interpolation 
It's OK ot use single quotes inside a string with double quotes in order
to avoid escape characters.
 2019-01-10 16:11:51 +01:00
Javi Martín
ee2f970e03 Fix sorting links for non-English languages 
We were assuming the translation and the column name were related.
 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
3fd7b3d216 Extract setting icon and direction to methods 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
0fe9ea08c3 Fix the direction assignment 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
e88acb8905 Make params handling case insensitive 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
e264490bca Styling and refactor sorting methods and helpers 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
3ab70ff0d8 Move validating params to model 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
37b2226432 Make the link_to helper more readable 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
cb761c56c2 Fix issue with app crashing when sort_by param was incorrect 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
101292d303 Rename allowed sort option variable 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
747b8295b1 Refactor link_to_investments_sorted method 2019-01-10 15:35:54 +01:00
Anna Anks Nowak
35cebe0eef Use symbols in sorting and set direction properly 2019-01-10 15:35:54 +01:00
Anna Anks Nowak
12484ed4fd Change SORTING_OPTIONS to has 2019-01-10 15:35:54 +01:00
Anna Anks Nowak
2523775d9f Make the conditional more readable temporarily 2019-01-10 15:35:54 +01:00
Anna Anks Nowak
9786b0bf7d Rewrite sorting to support direction param [#2931] 2019-01-10 15:34:33 +01:00
Anna Anks Nowak
2877229904 Move the link styling to th [#2931] 2019-01-10 15:28:55 +01:00
Anna Anks Nowak
5dd468092a Rewrite the method to not use budget_investments_sorting_options [#2931] 2019-01-10 15:28:55 +01:00
Anna Anks Nowak
22059379f5 Refactor by creating a helper method for generating sorting links [#2931] 2019-01-10 15:28:55 +01:00
Anna Anks Nowak
ea3319ae6f Add sorting links to table headers with proper styling [#2931] 2019-01-10 15:28:55 +01:00
Julian Nicolas Herrero
cc288fcedd Merge pull request #3167 from consul/backport-1793-cleanup_lines_controller 
[Backport] Remove before action not used
 2019-01-10 09:38:07 +01:00
Julian Nicolas Herrero
cd59f1b803 Merge pull request #3133 from consul/backport-1775-bug_management_create_investment_without_location 
[Backport] Bug Management Cannot create Budget Investment without a map location
 2019-01-09 18:02:53 +01:00
Julian Nicolas Herrero
702dc2bef5 Merge pull request #3154 from consul/backport-check_for_deleted_proposals 
[Backport] checks for deleted proposals
 2019-01-09 17:57:01 +01:00
Julian Herrero
0858f4c6f4 cleanup (remove unused code) 2019-01-09 17:49:46 +01:00
Julian Nicolas Herrero
7ccab504f0 Merge pull request #3160 from consul/backport-1784-consistency_remove_semicolon_from_controllers 
[Backport] Remove semicolons from controllers
 2019-01-09 17:46:32 +01:00
Julian Nicolas Herrero
08a692341a Merge pull request #3150 from consul/backport-1769-crud_budget_and_usa 
[Backport] new CRUD budgets, content blocks and heading map
 2019-01-09 17:35:46 +01:00
Javier Martín
90a66239a5 Merge pull request #3151 from consul/backport-fix_admin_investments_default_order 
Add default order for admin budget investments list
 2019-01-09 15:46:52 +01:00
Julian Herrero
9a60135d9f [Consistency] remove semicolons from controllers 2019-01-08 15:46:46 +01:00
Alberto
bbcb96027b Merge pull request #3137 from consul/key-dates-processes 
[Backport] Processes key dates
 2019-01-08 10:51:40 +01:00
João Lutz
47a33ea86c Enable options to show stats and results with any type of voter 2019-01-05 14:08:47 -02:00
rgarcia
e3eb87addb checks for deleted proposals 2019-01-04 15:25:13 +01:00
María Checa
650fe2553e Add default order for admin budget investments list 
When there's no sorting option selected, by default it orders the investment list by supports and, for those with the same number of supports, by ID.
 2019-01-02 12:52:28 +01:00
Julian Herrero
1ea18f0c89 refactor - correct place for block variable 2019-01-02 12:50:01 +01:00
Julian Herrero
c5a7492128 add some improvements on budget headings 
Show information about longitude and latitude in a budget heading
Show information about custom content in a budget heading
Fix render of map (zoom scrollable and points clickable)
Fix typo in app/models/map_location.rb
 2019-01-02 10:46:46 +01:00
Julian Herrero
2081269a67 fix Hound violations 2019-01-02 10:46:31 +01:00
Julian Herrero
d2b3943968 improve rendering of map in the sidebar 2019-01-02 10:41:03 +01:00
decabeza
5924a70385 Removes arrow icon on active process phase 2018-12-28 19:39:11 +01:00
decabeza
6b58a71f3f Shows tabs only on large screens 
Also moves ::after styles inside breakpoint(large down) to avoid use !important
 2018-12-28 18:23:15 +01:00
decabeza
6a580ede5b Improves layout of admin legislation homepage form 2018-12-28 18:23:12 +01:00
decabeza
dd8e2d6311 Shows participation phases only if there is a phase enabled 2018-12-28 18:23:08 +01:00
decabeza
db86f0e7ab Changes styles to tabs on processes key dates 2018-12-28 18:22:59 +01:00
decabeza
a982f97cbd Adds documents list on legislation process proposals phase 2018-12-28 17:22:03 +01:00
rgarcia
82a2dd622b hotfix to load categories on error 2018-12-28 09:43:08 +01:00
Julian Herrero
bf7112f090 make parameter 'skip_map' accessible on creating an investment 2018-12-27 18:39:27 +01:00
Javier Martín
f7022b36b4 Merge pull request #3132 from consul/release_0.18 
Release 0.18
 2018-12-27 14:37:52 +01:00
Alberto
db740df33d Merge pull request #3131 from consul/documents-title 
[Backport] Documents title
 2018-12-27 13:13:45 +01:00
Javi Martín
ee6ee3ca21 Update changelog for release 0.18 2018-12-27 12:29:21 +01:00
Javier Martín
d7e41fb556 Merge pull request #3127 from consul/fix_date_order_translations 
Bring back date order translations
 2018-12-26 16:40:03 +01:00