Bertocq
0f37239ac3
Enable Expect In Hook and Output rubocop rspec cops
2018-01-07 02:04:43 +01:00
Bertocq
f6aed3f9f1
Enable RSpec/ExpectActual cop and fix all issues
...
Always use a variable and not a literal as `expect` argument
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectActual
2018-01-07 01:55:38 +01:00
Bertocq
ed16a78f42
Enables RSpec/ExampleWording and fixes all issues
...
Both avoiding 'should' and repiting 'it' on the tests description
improves reading them and also makes all descriptions consistent.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
2018-01-07 01:03:45 +01:00
Bertocq
971f2e308a
Disables example length rubocop rspec cop, metrics always hard to meet
2018-01-07 00:53:08 +01:00
Bertocq
2253155a51
Enables RSpec/EmptyLineAfterSubject & fixes all issues
...
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterSubject
2018-01-07 00:50:50 +01:00
Bertocq
fa017b664f
Enables RSpec/EmptyLineAfterFinalLet cop & fixes all issues
...
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterFinalLet
2018-01-07 00:49:37 +01:00
Bertocq
265d4d0967
Enables RSpec/DescribedClass cop & fixes all issues
...
Autocorrection for existing issues, and stashing at .rubocop_todo.yml
the false positives
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribedClass
2018-01-07 00:38:19 +01:00
Bertocq
0c3dc56650
Enable both DescribeMethod and DescribeSymbol cops, without issues
2018-01-07 00:20:55 +01:00
Bertocq
6ec6f64675
Enable RSpec/DescribeClass rubocop rspec cop & fix issues
...
Manually fixes all issues & "stashed" false positives at .rubocop_todo.yml
Read about the cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribeClass
2018-01-07 00:20:55 +01:00
Bertocq
61be1015dd
Explicitly disable rubocop-rspec cops until we can debate about it
2018-01-07 00:20:55 +01:00
Bertocq
7f14544f71
Enable Capybara/CurrentPathExpectation cop & fix issues
...
Read cop description http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation to better understand reasons behind enforcing this rule
On some cases the `only_path: true` was needed as argument of `have_current_path` matcher to avoid comparing the url parameters and just checking the path.
2018-01-06 23:31:41 +01:00
Bertocq
4c7b2fcaa0
Update rubocop config with some rspec cops rules without issues
2018-01-06 21:19:03 +01:00
Bertocq
de2816a6a5
Enable RSpec/BeforeAfterAll rule and fix all issues
...
This cop tries to avoid state leaking between examples. The fixes done on the code don't follow the suggested path, since the usage of `before(:all)` was not really useful. By using RSpec's `let` method we achieve same goals but with much better and readable tests.
Check Cop description at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeforeAfterAll
2018-01-06 21:16:00 +01:00
Bertocq
6555d20a6a
Add rubocop-rspec gem and require it at rubocop config
2018-01-06 21:01:22 +01:00
Bertocq
ecab5875a8
Disable all rubocop cops by default
2018-01-06 20:43:41 +01:00
Bertocq
0516010aa3
Correct deprecated & renamed rubocop cops names
2018-01-06 20:43:41 +01:00
Bertocq
6aba5de801
Make rubocop display cop name and style guide link to improve output
2017-09-20 16:13:08 +02:00
Bertocq
4a5a164925
Ignore Style/SymbolProc rubocop cop, no strong preferences for it
2017-07-05 11:56:44 +02:00
Bertocq
c16b0cba4d
Disable Style/EmptyMethod rubocop rule after debate agreement
2017-06-28 14:12:51 +02:00
Bertocq
9504958a08
Disable Style/SymbolArray rubocop cop after core discussion about it
2017-06-26 11:10:30 +02:00
Bertocq
82d47458f7
Disable rubocop Rails/ApplicationRecord cop until rails 5 branch comes
2017-06-08 11:46:31 +02:00
Bertocq
ec49432039
Fix rubocop cop namespaces from Style to Layout for those that were moved on last version
2017-06-07 20:57:34 +02:00
kikito
a2fa65a5bc
adds .rubocop.yml + .rubocop_todo.yml
2016-11-25 13:39:59 +01:00
