consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
20,618 Commits 1 Branch 0 Tags
7f749bb9bb8eefa5113c0c44f9211bfb7f386a16
Commit Graph

323 Commits

Author SHA1 Message Date
Javi Martín
ad1e044e0a Add trailing newline rule to rubocop 
Just like we're suggesting when we do code reviews and like the rule
we've enabled in SCSS-Lint.
 2018-09-26 17:11:59 +02:00
Javi Martín
2545d49aed Don't allow trailing whitespaces in rubocop 
Luckily we don't have any trailing whitespaces around, but we might
accidentally introduce some.
 2018-09-26 17:11:59 +02:00
Bertocq
2bf019f08b Disable DynamicAttributeDefinedStatically cop 
rubocop-rspec includes a FactoryBot cop DynamicAttributeDefinedStatically
that enforces declaring dynamic attribute values in a block. It was
decided not to follow this convention. Explicitly disabling it gives
more insight about current rubocop rules.

http://www.rubydoc.info/gems/rubocop-rspec/1.24.0/RuboCop/Cop/RSpec/FactoryBot/DynamicAttributeDefinedStatically
 2018-04-04 19:28:15 +02:00
Bertocq
e2c42a3c63 Enable StaticAttributeDefinedDynamically cop & fix 
rubocop-rspec gem includes cops for FactoryBot like the new
 FactoryBot/StaticAttributeDefinedDynamically to enforce declaring
 static attribute values without a block.

* http://www.rubydoc.info/gems/rubocop-rspec/1.24.0/RuboCop/Cop/RSpec/FactoryBot/StaticAttributeDefinedDynamically
 2018-04-04 19:28:15 +02:00
Bertocq
d3d9573086 Enable new Rails/HttpStatus cop without issues 
rubocop-rspec 1.23.0 release introduced the cop RSpec/Rails/HttpStatus
to enforce consistent usage of the status format (numeric or symbolic).
* https://github.com/rubocop-rspec/rubocop-rspec/pull/553
* https://github.com/rubocop-rspec/rubocop-rspec/releases/tag/v1.23.0
 2018-04-04 19:28:15 +02:00
Bertocq
b0c0578cbe Remove deprecated Performance/HashEachMethods cop 
At release https://github.com/bbatsov/rubocop/releases/tag/v0.53.0 it
has been removed with https://github.com/bbatsov/rubocop/issues/5589
 2018-04-04 19:26:31 +02:00
Bertocq
43559981eb Enable rubocop Layout/EndOfLine cop with LF 2018-02-11 10:33:51 +01:00
Bertocq
664db2306c Enable rubocop Rails cops without issues 2018-02-10 21:29:21 +01:00
Bertocq
3f91e920f6 Enable rubocop Performance/RedundantMatch cop & fix issues 
Some cop offenses have been stashed into rubocop_todo.yml for now
 2018-02-10 21:26:02 +01:00
Bertocq
57743df197 Enable rubocop Performance/HashEachMethods cop & fix issues 2018-02-10 21:22:47 +01:00
Bertocq
307fe18c59 Enable rubocop Performance cops without issues 2018-02-10 21:17:56 +01:00
Bertocq
a419b36ff3 Enable rubocop Security cops without issues 2018-02-10 21:13:03 +01:00
Bertocq
537e6e175d Enable rubocop Gemspec cops without issues 2018-02-10 21:03:50 +01:00
Bertocq
fc88e1ef79 Enable rubocop Bundler cops without issues 2018-02-10 21:03:38 +01:00
Bertocq
5de51b5f3c Enable rubocop Performance/Caller cop without issues 2018-02-10 20:59:20 +01:00
Bertocq
9abbf874f2 Enable rubocop-rspec RSpec/InstanceVariable cop 2018-02-10 19:34:30 +01:00
Bertocq
4ca0a48df6 Reduce rubocop's Metrics/LineLength max to 100 chars by common agreement 2018-01-08 19:11:04 +01:00
Bertocq
4fc03fe395 Enable RSpec/VoidExpect cop without issues 2018-01-07 18:48:59 +01:00
Bertocq
830bb37189 Enable RSpec/VerifiedDoubles cop, fix issues & stash one 
Can't figureout solution for offense at spec/models/verification/management/email_spec.rb
 so its stashed at .rubocop_todo.yml

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/VerifiedDoubles
 2018-01-07 18:47:19 +01:00
Bertocq
95e86eafbb Enable RSpec/SubjectStub cop without issues 2018-01-07 18:46:58 +01:00
Bertocq
425404b890 Enable RSpec/SingleArgumentMessageChain cop without issues 2018-01-07 18:46:58 +01:00
Bertocq
dc1deee15a Enable RSpec/SharedContext cop without issues 2018-01-07 18:46:58 +01:00
Bertocq
3762fd347e Enable RSpec/ScatteredSetup & fix issue 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredSetup
 2018-01-07 18:46:58 +01:00
Bertocq
f8fb32db76 Enable RSpec/ScatteredLet cop & fix issue 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredLet
 2018-01-07 18:46:58 +01:00
Bertocq
33365479c9 Enable RSpec/ReturnFromStub cop without issues 2018-01-07 18:46:58 +01:00
Bertocq
16eae689f9 Enable RSpec/RepeatedExample cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedExample
 2018-01-07 18:46:32 +01:00
Bertocq
4f6597b200 Enable RSpec/RepeatedDescription cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedDescription
 2018-01-07 17:45:34 +01:00
Bertocq
e89d081a47 Enable RSpec/PredicateMatcher cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PredicateMatcher
 2018-01-07 17:42:59 +01:00
Bertocq
c6cac965dd Enable RSpec/OverwritingSetup cop without issues 2018-01-07 17:40:59 +01:00
Bertocq
34bb9d65b1 Enable RSpec/NotToNot cop and fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
 2018-01-07 17:39:48 +01:00
Bertocq
79a3b97c64 Enable RSpec/NestedGroups cop with a reasonable max value of 4 2018-01-07 17:38:55 +01:00
Bertocq
4c48027228 Explicitly disable RSpec/NamedSubject cop until debate is held 2018-01-07 17:36:46 +01:00
Bertocq
317247103e Enable RSpec/MultipleSubjects without issues 2018-01-07 17:07:34 +01:00
Bertocq
ce395217f8 Disable RSpec/MultipleExpectations cop with 1339 possible offenses, need to stablish a max amount after a debate 2018-01-07 17:06:43 +01:00
Bertocq
18d14dfe17 Enable RSpec/MultipleDescribes cop without issues 2018-01-07 17:04:38 +01:00
Bertocq
eb822c4a5e Enable RSpec/MessageSpies cop without issues 
EnforcedStyle: receive configuration was added to follow codebase conventions

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MessageSpies
 2018-01-07 16:51:11 +01:00
Bertocq
c4aa2d7093 Enable RSpec/MessageExpectation cop & fix issues 
There was 34 `allow` occurences and 17 `expect` occurences, so to be consistent `allow` form was chosen.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MessageExpectation
 2018-01-07 16:36:18 +01:00
Bertocq
987b31d618 Enable RSpec/MessageChain cop without issues 2018-01-07 16:28:37 +01:00
Bertocq
2d355ce938 Enable RSpec/LetSetup cop & fix issues 
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetSetup
 2018-01-07 16:23:49 +01:00
Bertocq
3e5b13ae4d Enable RSpec/LetBeforeExamples cop & fix issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetBeforeExamples
 2018-01-07 02:28:06 +01:00
Bertocq
4bb75c3a11 Enable RSpec/LeadingSubject cop without issues 2018-01-07 02:26:40 +01:00
Bertocq
eaf66e3ec1 Enable RSpec/IteratedExpectation cop and fix issues 
Suggested refactor is only available for `.to` and not for `.not_to` :(

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IteratedExpectation
 2018-01-07 02:24:24 +01:00
Bertocq
77e6e33d35 Enable RSpec/ItBehavesLike cop without issues 2018-01-07 02:20:34 +01:00
Bertocq
54cd57de9b Enable RSpec/InvalidPredicateMatcher without issues 2018-01-07 02:19:23 +01:00
Bertocq
473e3d6466 Disable RSpec/InstanceVariable as we have 868 offenses for it 2018-01-07 02:15:43 +01:00
Bertocq
bf75b50b2f Enable RSpec/InstanceSpy cop without issues 2018-01-07 02:14:04 +01:00
Bertocq
ae04a76221 Enable RSpec/ImplicitExpect cop with convention 
Used `EnforcedStyle: should` config as there is no `is_expected.to` usage on the codebase.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ImplicitExpect
 2018-01-07 02:11:51 +01:00
Bertocq
1441de5107 Enable RSpec/HookArgument cop and fix issues 
To be consistent about before/after arguments, as `:each` or `:example`
 are same and default scopes, best not to send an argument in those
 scenarios.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
 2018-01-07 02:07:19 +01:00
Bertocq
39b01b6342 Enable RSpec/Focus cop without issues 2018-01-07 02:07:02 +01:00
Bertocq
95733f52f2 Enable RSpec/FilePath cop and fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FilePath
 2018-01-07 02:05:10 +01:00