Bertocq
1441de5107
Enable RSpec/HookArgument cop and fix issues
...
To be consistent about before/after arguments, as `:each` or `:example`
are same and default scopes, best not to send an argument in those
scenarios.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
2018-01-07 02:07:19 +01:00
Bertocq
ed16a78f42
Enables RSpec/ExampleWording and fixes all issues
...
Both avoiding 'should' and repiting 'it' on the tests description
improves reading them and also makes all descriptions consistent.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
2018-01-07 01:03:45 +01:00
Bertocq
d3719f0b42
Merge branch 'fix/documentable_multiple_docs'
2018-01-03 18:03:20 +01:00
Bertocq
3bf8948b11
Fix typo, dowload to download
2018-01-03 17:38:44 +01:00
Bertocq
1246bd4e62
Fix poltergeist input focus issues
2018-01-03 17:38:44 +01:00
Bertocq
e71340bccb
Bring back max doc attachment scenario, using all pdf fixtures
2018-01-03 17:38:44 +01:00
Bertocq
5bf16eb1ac
Remove index param from attach new file helper test function
2018-01-03 17:38:44 +01:00
BertoCQ
4885acb7ac
Merge pull request #2225 from consul/chore/refactor_documents_document_partials
...
Refactor documents and document view partials
2018-01-03 17:38:16 +01:00
Bertocq
2f7e81e5ca
Remove unused documentable_factory_name argument from documentable_attach_new_file helper method
2018-01-02 13:59:58 +01:00
Bertocq
d7d1a85fbb
Refactor documents and document view partials
2018-01-02 13:32:42 +01:00
rgarcia
96066aee44
Validates map presence only on create
...
As we are using an attr_accessor to make sure a user accepts that the
proposal “has no map”, the validation was being run in every save.
Making other things break, for example the updating of the counter
cache `cached_votes_up`, when someone voted for the proposal, as the
attr_accessor `skip_map` was not present
2017-12-26 12:39:29 +01:00
Bertocq
f6d23df862
Avoid using eval when send can do the job
2017-12-25 23:47:55 +01:00
Bertocq
2283237d44
Avoid Looking up factories by class is deprecated and will be removed in FactoryGirl 5.0
2017-12-25 23:46:51 +01:00
Bertocq
93e6a7e6aa
Fix indentation & spaces on map validation files
2017-12-25 23:34:18 +01:00
BertoCQ
d534b02b3c
Merge pull request #2206 from consul/related-contents-score
...
Related contents score
2017-12-20 15:13:12 +01:00
María Checa
1e23281c28
Fixed related content tests
2017-12-20 13:43:56 +01:00
rgarcia
7889efd6ee
Fix map location update
...
When editing the map of a proposal or investment(the mappable) the
updated_at attribute of the mappable was not been updated and so the
map still displayed the old location after updating it
2017-12-20 12:43:49 +01:00
Bertocq
f190d9c626
Fix related content score classname on specs
2017-12-20 03:06:53 +01:00
Bertocq
f21f5ec05e
Refactor Related Content Controller score methods
2017-12-20 02:36:13 +01:00
María Checa
8e4a39a066
Updated schema and fixed tests
2017-12-19 20:45:23 +01:00
rgarcia
0152b6301c
adds specs
2017-12-19 20:36:10 +01:00
María Checa
b99a2eac6f
Fixed tests
2017-12-19 19:10:43 +01:00
María Checa
03aaa82d86
Improved tests
2017-12-19 17:01:35 +01:00
María Checa
4192860a73
Added and improved related content tests
2017-12-18 23:56:44 +01:00
Bertocq
70f2ee0cf5
Fix Time.now usage to Time.current to include zone
2017-12-16 17:59:16 +01:00
Raimond Garcia
9ba8ca7de3
Merge pull request #2187 from consul/notifications
...
Fix notifications' exceptions
2017-12-14 22:11:27 +01:00
rgarcia
2b52d26d82
refactors notifications into concerns and shared examples
2017-12-14 16:15:30 +01:00
Bertocq
f376707b2d
Fix style of method with parameters call using parenthesis
2017-12-13 14:11:52 +01:00
Bertocq
1c863d7d84
Use activerecord model name on followable specs
2017-12-13 14:11:22 +01:00
decabeza
1d6877b797
adds setting allow_images to specs
2017-12-06 20:59:34 +01:00
Bertocq
ce0a7f6fad
Rubocop autocorrections
2017-10-17 22:00:00 +02:00
rgarcia
23682fadd8
fixes document specs
2017-10-06 17:50:41 +02:00
decabeza
dd69401477
Merge branch 'master' into question-answer-documents
2017-10-06 15:18:42 +02:00
rgarcia
9a31c97a20
fixes image specs
2017-10-06 14:01:03 +02:00
decabeza
b4d494ce24
fixes documents specs
2017-10-06 12:57:21 +02:00
Raimond Garcia
3d100d1e93
Merge branch 'master' into iagirre-remove-documents-questions
2017-10-06 01:02:56 +02:00
rgarcia
6327bcb343
adds specs for answer's gallery
2017-10-05 19:15:17 +02:00
iagirre
b31abb64d7
Removed the methods not used from nested_documentable specs (the ones that were deleted in the questions specs) and removed also the document params from questions_params (not used anymore).
2017-10-05 17:28:24 +02:00
rgarcia
52b68aa0df
removes extra space
2017-10-04 23:58:36 +02:00
rgarcia
1cf9bc4ad1
adds images to anwers
2017-10-04 23:56:09 +02:00
María Checa
8dc05d399b
Fixed tests
2017-10-04 10:03:44 +02:00
taitus
a0603985ef
Refactor.
2017-09-27 14:51:35 +02:00
taitus
51c53b6f31
Add missing specs from Maps on New, Edit and Show.
2017-09-27 14:50:54 +02:00
Senén Rodero Rodríguez
2993ef8707
Remove documents single uploads
2017-09-27 11:04:56 +02:00
Senén Rodero Rodríguez
eef8ad1b73
Remove images single uploads
2017-09-27 10:41:48 +02:00
Senén Rodero Rodríguez
92f66a6db9
Fix rpspec styub deprecated syntax
2017-09-26 13:57:14 +02:00
Senén Rodero Rodríguez
1a8fda9352
Fix broken specs
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
ce29185b76
Fix documentable on admin poll questions. Adapt nested documentable shared specs to admin fetaure specs and include at admin poll questions specs.
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
f8d78ec4ab
Remove new_nested action from images controller. Use cocoon gem to manage new nested fields creation on images.
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
88a7a29d27
Remove new_nested action from documents controller. Use cocoon gem to manage new nested fields creation on documents.
2017-09-26 13:57:13 +02:00
