consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,168 Commits 1 Branch 0 Tags
77e6e33d358c1bad049c3a58f0cb15ac056a5b90
Commit Graph

8168 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bertocq
77e6e33d35 Enable RSpec/ItBehavesLike cop without issues 2018-01-07 02:20:34 +01:00
Bertocq
54cd57de9b Enable RSpec/InvalidPredicateMatcher without issues 2018-01-07 02:19:23 +01:00
Bertocq
473e3d6466 Disable RSpec/InstanceVariable as we have 868 offenses for it 2018-01-07 02:15:43 +01:00
Bertocq
bf75b50b2f Enable RSpec/InstanceSpy cop without issues 2018-01-07 02:14:04 +01:00
Bertocq
ae04a76221 Enable RSpec/ImplicitExpect cop with convention 
Used `EnforcedStyle: should` config as there is no `is_expected.to` usage on the codebase.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ImplicitExpect
 2018-01-07 02:11:51 +01:00
Bertocq
1441de5107 Enable RSpec/HookArgument cop and fix issues 
To be consistent about before/after arguments, as `:each` or `:example`
 are same and default scopes, best not to send an argument in those
 scenarios.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
 2018-01-07 02:07:19 +01:00
Bertocq
39b01b6342 Enable RSpec/Focus cop without issues 2018-01-07 02:07:02 +01:00
Bertocq
95733f52f2 Enable RSpec/FilePath cop and fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FilePath
 2018-01-07 02:05:10 +01:00
Bertocq
0f37239ac3 Enable Expect In Hook and Output rubocop rspec cops 2018-01-07 02:04:43 +01:00
Bertocq
97c5490995 Fix unnecesary spacing 2018-01-07 01:58:45 +01:00
Bertocq
f6aed3f9f1 Enable RSpec/ExpectActual cop and fix all issues 
Always use a variable and not a literal as `expect` argument

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectActual
 2018-01-07 01:55:38 +01:00
Bertocq
0698043340 Fix indentations 2018-01-07 01:06:07 +01:00
Bertocq
ed16a78f42 Enables RSpec/ExampleWording and fixes all issues 
Both avoiding 'should' and repiting 'it' on the tests description
improves reading them and also makes all descriptions consistent.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
 2018-01-07 01:03:45 +01:00
Bertocq
971f2e308a Disables example length rubocop rspec cop, metrics always hard to meet 2018-01-07 00:53:08 +01:00
Bertocq
2253155a51 Enables RSpec/EmptyLineAfterSubject & fixes all issues 
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterSubject
 2018-01-07 00:50:50 +01:00
Bertocq
fa017b664f Enables RSpec/EmptyLineAfterFinalLet cop & fixes all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterFinalLet
 2018-01-07 00:49:37 +01:00
Bertocq
265d4d0967 Enables RSpec/DescribedClass cop & fixes all issues 
Autocorrection for existing issues, and stashing at .rubocop_todo.yml
the false positives

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribedClass
 2018-01-07 00:38:19 +01:00
Bertocq
0c3dc56650 Enable both DescribeMethod and DescribeSymbol cops, without issues 2018-01-07 00:20:55 +01:00
Bertocq
6ec6f64675 Enable RSpec/DescribeClass rubocop rspec cop & fix issues 
Manually fixes all issues & "stashed" false positives at .rubocop_todo.yml

Read about the cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribeClass
 2018-01-07 00:20:55 +01:00
Bertocq
61be1015dd Explicitly disable rubocop-rspec cops until we can debate about it 2018-01-07 00:20:55 +01:00
BertoCQ
bb6209136c Merge pull request #2259 from consul/depfu/upgrade/whenever-0.10.0 
Upgrade whenever: 0.9.7 → 0.10.0 (minor)
 2018-01-07 00:00:28 +01:00
Bertocq
7f14544f71 Enable Capybara/CurrentPathExpectation cop & fix issues 
Read cop description http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation to better understand reasons behind enforcing this rule

On some cases the `only_path: true` was needed as argument of `have_current_path` matcher to avoid comparing the url parameters and just checking the path.
 2018-01-06 23:31:41 +01:00
depfu[bot]
9cae0eadda Upgrade whenever to version 0.10.0 2018-01-06 21:35:31 +00:00
BertoCQ
48c2df2463 Merge pull request #2260 from consul/depfu/update/rspec-rails-3.7.2 
Update rspec-rails: 3.6.1 → 3.7.2 (minor)
 2018-01-06 22:32:21 +01:00
BertoCQ
8256fc2641 Merge pull request #2258 from consul/depfu/upgrade/unicorn-5.4.0 
Upgrade unicorn: 5.3.0 → 5.4.0 (minor)
 2018-01-06 22:27:16 +01:00
depfu[bot]
242d028205 Update rspec-rails to version 3.7.2 2018-01-06 21:10:24 +00:00
Bertocq
4c7b2fcaa0 Update rubocop config with some rspec cops rules without issues 2018-01-06 21:19:03 +01:00
Bertocq
de2816a6a5 Enable RSpec/BeforeAfterAll rule and fix all issues 
This cop tries to avoid state leaking between examples. The fixes done on the code don't follow the suggested path, since the usage of `before(:all)` was not really useful. By using RSpec's `let` method we achieve same goals but with much better and readable tests.

Check Cop description at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeforeAfterAll
 2018-01-06 21:16:00 +01:00
Bertocq
6555d20a6a Add rubocop-rspec gem and require it at rubocop config 2018-01-06 21:01:22 +01:00
depfu[bot]
19de0e2e33 Upgrade unicorn to version 5.4.0 2018-01-06 19:55:39 +00:00
Bertocq
541026025f Update rubocop config with some rspec cops rules without issues 2018-01-06 20:44:15 +01:00
Bertocq
a79232ef01 Enable RSpec/BeforeAfterAll rule and fix all issues 2018-01-06 20:44:15 +01:00
Bertocq
ad65defda0 Add rubocop rspec cops to rubocop config 2018-01-06 20:44:15 +01:00
Bertocq
ecab5875a8 Disable all rubocop cops by default 2018-01-06 20:43:41 +01:00
Bertocq
824352c698 Update rubocop_todo.yml automatically 2018-01-06 20:43:41 +01:00
Bertocq
0516010aa3 Correct deprecated & renamed rubocop cops names 2018-01-06 20:43:41 +01:00
Bertocq
05baf8b8e2 Update rubocop version to latest 2018-01-06 20:43:40 +01:00
BertoCQ
96f81d3419 Merge pull request #2255 from consul/depfu/upgrade/invisible_captcha-0.10.0 
Upgrade invisible_captcha: 0.9.3 → 0.10.0 (minor)
 2018-01-06 20:41:30 +01:00
BertoCQ
bbcfa2d30f Merge pull request #2256 from consul/depfu/upgrade/rollbar-2.15.5 
Upgrade rollbar: 2.14.1 → 2.15.5 (minor)
 2018-01-06 20:37:15 +01:00
depfu[bot]
c9f1df936c Upgrade rollbar to version 2.15.5 2018-01-06 18:05:27 +00:00
depfu[bot]
a28cd5f8de Upgrade invisible_captcha to version 0.10.0 2018-01-06 17:30:32 +00:00
Bertocq
2105e985a8 Fix budget investment random order feature to generate just enough elements for pagination 2018-01-06 18:21:24 +01:00
Bertocq
18236e8827 Fix random order seed value cleanup to allow negative values and always be numeric 2018-01-06 18:21:24 +01:00
BertoCQ
a901d1de7c Merge pull request #2253 from consul/depfu/upgrade/paranoia-2.4.0 
Upgrade paranoia: 2.3.1 → 2.4.0 (minor)
 2018-01-06 17:59:50 +01:00
BertoCQ
727b6817fc Merge pull request #2250 from consul/depfu/upgrade/kaminari-1.1.1 
Upgrade kaminari: 1.0.1 → 1.1.1 (minor)
 2018-01-06 17:47:54 +01:00
depfu[bot]
bf0bc8d7d0 Upgrade kaminari to version 1.1.1 2018-01-06 16:16:51 +01:00
BertoCQ
cf2d5d4e3a Merge pull request #2245 from consul/depfu/upgrade/capistrano-rails-1.3.1 
Upgrade capistrano-rails: 1.2.3 → 1.3.1 (minor)
 2018-01-06 15:13:05 +01:00
BertoCQ
a16283c7c7 Merge pull request #2234 from consul/depfu/update/capistrano3-delayed-job-1.7.5 
Update capistrano3-delayed-job: 1.7.3 → 1.7.5 (patch)
 2018-01-06 14:56:37 +01:00
depfu[bot]
5677115fd9 Upgrade paranoia to version 2.4.0 2018-01-06 13:35:43 +00:00
BertoCQ
c5048220b3 Merge pull request #2252 from consul/depfu/upgrade/omniauth-1.8.1 
Upgrade omniauth: 1.6.1 → 1.8.1 (minor)
 2018-01-06 14:34:45 +01:00