Bertocq
1441de5107
Enable RSpec/HookArgument cop and fix issues
...
To be consistent about before/after arguments, as `:each` or `:example`
are same and default scopes, best not to send an argument in those
scenarios.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
2018-01-07 02:07:19 +01:00
Bertocq
95733f52f2
Enable RSpec/FilePath cop and fix all issues
...
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FilePath
2018-01-07 02:05:10 +01:00
Bertocq
0698043340
Fix indentations
2018-01-07 01:06:07 +01:00
Bertocq
ed16a78f42
Enables RSpec/ExampleWording and fixes all issues
...
Both avoiding 'should' and repiting 'it' on the tests description
improves reading them and also makes all descriptions consistent.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
2018-01-07 01:03:45 +01:00
Bertocq
2253155a51
Enables RSpec/EmptyLineAfterSubject & fixes all issues
...
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterSubject
2018-01-07 00:50:50 +01:00
Bertocq
fa017b664f
Enables RSpec/EmptyLineAfterFinalLet cop & fixes all issues
...
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterFinalLet
2018-01-07 00:49:37 +01:00
Bertocq
265d4d0967
Enables RSpec/DescribedClass cop & fixes all issues
...
Autocorrection for existing issues, and stashing at .rubocop_todo.yml
the false positives
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribedClass
2018-01-07 00:38:19 +01:00
Bertocq
6ec6f64675
Enable RSpec/DescribeClass rubocop rspec cop & fix issues
...
Manually fixes all issues & "stashed" false positives at .rubocop_todo.yml
Read about the cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribeClass
2018-01-07 00:20:55 +01:00
Bertocq
de2816a6a5
Enable RSpec/BeforeAfterAll rule and fix all issues
...
This cop tries to avoid state leaking between examples. The fixes done on the code don't follow the suggested path, since the usage of `before(:all)` was not really useful. By using RSpec's `let` method we achieve same goals but with much better and readable tests.
Check Cop description at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeforeAfterAll
2018-01-06 21:16:00 +01:00
BertoCQ
d534b02b3c
Merge pull request #2206 from consul/related-contents-score
...
Related contents score
2017-12-20 15:13:12 +01:00
María Checa
1e23281c28
Fixed related content tests
2017-12-20 13:43:56 +01:00
rgarcia
0152b6301c
adds specs
2017-12-19 20:36:10 +01:00
María Checa
44f8494079
Fixed tests
2017-12-19 19:40:09 +01:00
María Checa
4192860a73
Added and improved related content tests
2017-12-18 23:56:44 +01:00
María Checa
97f74ac531
Renamed related content times_reported column to flags_count
2017-12-18 18:21:46 +01:00
BertoCQ
0bd025962b
Merge pull request #2200 from wairbut-m2c/aperez-proposal-recommendations
...
New scopes for proposal recommendations
2017-12-16 19:58:46 +01:00
Bertocq
70f2ee0cf5
Fix Time.now usage to Time.current to include zone
2017-12-16 17:59:16 +01:00
Bertocq
c2b5083d4f
Fix missing and extra spacing
2017-12-16 17:59:16 +01:00
Angel Perez
63317714c3
Proposal recommendations won't include archived or already supported proposals
2017-12-15 22:40:24 -04:00
Bertocq
900d8a00b1
Make milestone's description a required attribute
2017-12-15 16:38:21 +01:00
rgarcia
2b52d26d82
refactors notifications into concerns and shared examples
2017-12-14 16:15:30 +01:00
rgarcia
abaf6ab785
adds model validations for legislation proposals
2017-12-13 12:52:25 +01:00
rgarcia
8c85611ec9
Adds missing specs for notification titles
2017-12-11 13:23:30 +01:00
Bertocq
cd021aee4b
Add relationed_contents helper function on Relationable concern with spec
2017-11-29 19:02:25 +01:00
Bertocq
0482eb4098
Add report_related_content helper funcion on Relationable concern with spec
2017-11-29 19:02:25 +01:00
Bertocq
04dfc98c3f
Create RelatedContent model spec to check relationable destroy
2017-11-29 19:01:50 +01:00
Bertocq
03f0534b2f
Add scenario to RelatedContent model spec to check opposite related content creation
2017-11-29 19:01:12 +01:00
Bertocq
f0dca7147b
Add basic RelatedContent model spec to check multiple models can be related
2017-11-29 19:01:04 +01:00
María Checa
3984d6a947
Merge pull request #2115 from wairbut-m2c/iagirre-heading-population-restriction-validation
...
Iagirre heading population restriction validation
2017-11-28 20:06:53 +01:00
Raimond Garcia
9e12d67f3f
Merge pull request #2114 from wairbut-m2c/iagirre-booth-assignment-removal
...
Iagirre booth assignment removal
2017-11-28 19:59:20 +01:00
Bertocq
cd66ba5d54
Rubocop autocorrections
2017-11-13 02:22:00 +01:00
iagirre
aed0013e79
Spec fixed
2017-10-31 15:54:17 +01:00
iagirre
bfcbb6c0ad
Validation in model and in form added. When users makes the on focus on population field an explanation appears. Some specs added to test the model validations
2017-10-31 13:04:30 +01:00
iagirre
4b8a471d38
Specs added to test the functionality and some UI modified to make test pass
2017-10-30 16:50:25 +01:00
David Rodríguez
97331cb1c9
Fix direct_messages_max_per_day set to nil
...
When set to nil, it should mean not zero, but "infinite".
2017-10-23 12:15:31 +02:00
Alberto García
91b8ed67f6
Merge pull request #2075 from wairbut-m2c/iagirre-poll-stats
...
Iagirre poll stats
2017-10-18 17:25:02 +02:00
iagirre
f7bb3ec8b7
Merge remote-tracking branch 'consul/master' into iagirre-poll-stats
2017-10-18 09:48:02 +02:00
iagirre
73365ad9d2
Added spects to check de stats model and view
2017-10-18 09:34:17 +02:00
Bertocq
36610f0c1a
Use poll question trait with_answers to generate yes/no answers
2017-10-18 02:06:34 +02:00
Bertocq
fbcf8678c3
Remove no longer needed question model tests for valid_answers
2017-10-18 01:28:59 +02:00
Bertocq
39f23d3b7b
Switch from valid_answers to question_answers on specs
2017-10-18 01:28:38 +02:00
Bertocq
7b40c84166
Rubocop fixes and rubocop todo update for those that can't be done right now
2017-10-17 22:23:53 +02:00
Bertocq
ce0a7f6fad
Rubocop autocorrections
2017-10-17 22:00:00 +02:00
BertoCQ
d1c67212b0
Merge pull request #1964 from consul/chore/remove_results
...
Remove deprecated Poll results models
2017-10-17 14:39:42 +02:00
Bertocq
9146d68c53
Add current_or_recounting_or_incoming method to Poll model
2017-10-13 16:53:03 +02:00
Bertocq
ca2d9a1d68
Add recounting Poll scope with trait and spec
2017-10-13 16:51:58 +02:00
María Checa
84e35edca7
Added new tests for vote token
2017-10-07 16:16:39 +02:00
Bertocq
9a396fe634
Fix record_voter_participation and usage on specs
2017-10-07 10:48:24 +02:00
rgarcia
007bcb7ec7
fixes specs
2017-10-04 17:46:25 +02:00
Bertocq
85087b0bea
Check officer value for Poll Voter created from officing panel
2017-10-04 01:09:51 +02:00
