Commit Graph

1651 Commits

Author SHA1 Message Date
Bertocq
1441de5107 Enable RSpec/HookArgument cop and fix issues
To be consistent about before/after arguments, as `:each` or `:example`
 are same and default scopes, best not to send an argument in those
 scenarios.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
2018-01-07 02:07:19 +01:00
Bertocq
97c5490995 Fix unnecesary spacing 2018-01-07 01:58:45 +01:00
Bertocq
f6aed3f9f1 Enable RSpec/ExpectActual cop and fix all issues
Always use a variable and not a literal as `expect` argument

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectActual
2018-01-07 01:55:38 +01:00
Bertocq
fa017b664f Enables RSpec/EmptyLineAfterFinalLet cop & fixes all issues
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterFinalLet
2018-01-07 00:49:37 +01:00
Bertocq
7f14544f71 Enable Capybara/CurrentPathExpectation cop & fix issues
Read cop description http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation to better understand reasons behind enforcing this rule

On some cases the `only_path: true` was needed as argument of `have_current_path` matcher to avoid comparing the url parameters and just checking the path.
2018-01-06 23:31:41 +01:00
Bertocq
2105e985a8 Fix budget investment random order feature to generate just enough elements for pagination 2018-01-06 18:21:24 +01:00
Bertocq
e8570ed7bb Fix spec link upcase to downcase for archived proposals 2018-01-03 18:03:05 +01:00
Bertocq
bf9ea64088 Fix spec link upcase to downcase for archived proposals 2018-01-03 17:37:55 +01:00
María Checa
4192860a73 Added and improved related content tests 2017-12-18 23:56:44 +01:00
María Checa
0fd2b869ce Added tests 2017-12-18 18:22:01 +01:00
Bertocq
c2b5083d4f Fix missing and extra spacing 2017-12-16 17:59:16 +01:00
Alberto García
cec48c72ef Merge pull request #2195 from consul/milestones_improvements
Make Milestones description required, hide title usage
2017-12-15 18:47:30 +01:00
Bertocq
91e14f22e8 Update milestone feature specs to reflect default title value changes 2017-12-15 18:22:05 +01:00
María Checa
5f4b179f3e Added tests 2017-12-15 17:32:18 +01:00
Raimond Garcia
d0b407d4e5 Merge pull request #2183 from consul/related-content
Related contents functionalities
2017-12-15 10:00:43 +01:00
Raimond Garcia
9ba8ca7de3 Merge pull request #2187 from consul/notifications
Fix notifications' exceptions
2017-12-14 22:11:27 +01:00
María Checa
784e576f42 Added new tests 2017-12-14 21:03:23 +01:00
Alberto García
1737f85398 Merge branch 'master' into aperez-dates-for-milestones 2017-12-14 20:50:55 +01:00
Alberto García
09b544774d Merge pull request #2191 from wairbut-m2c/iagirre-add-documents-to-milestones
Add documents to milestones
2017-12-14 20:49:19 +01:00
rgarcia
2b52d26d82 refactors notifications into concerns and shared examples 2017-12-14 16:15:30 +01:00
BertoCQ
50b4f50eac Merge branch 'master' into aperez-dates-for-milestones 2017-12-14 15:42:35 +01:00
María Checa
7629fd2499 Added specs for related content form 2017-12-14 14:50:47 +01:00
Alberto García
45de7efd7a Merge pull request #1904 from consul/community-design
Community design
2017-12-14 14:44:03 +01:00
iagirre
ff50dc1a00 Add feature specs to test new admin features and documents' show in users view 2017-12-14 13:53:03 +01:00
Bertocq
a71ad644c5 Fix community topics specs 2017-12-14 13:51:10 +01:00
Alberto García
19925de06b Merge pull request #2170 from consul/design
Design improvements
2017-12-14 11:31:31 +01:00
Angel Perez
1e1028dcb4 Adapt existing milestone-related specs to fit the new requirement 2017-12-13 20:17:54 -04:00
iagirre
59a4b93a00 Add I18n texts for milestone images.
Add specs to test admin image uploader and milestones' show.
Modify the UI to fit the mockups provided in the issue.
2017-12-13 14:03:46 +01:00
María Checa
d6fd83915d Added tests for related contents list 2017-12-13 13:32:18 +01:00
Raimond Garcia
d49a1dc208 Merge pull request #2172 from consul/notifications
Notifications for hidden resources
2017-12-12 16:26:37 +01:00
rgarcia
e3c8dece8f Makes the code aware of notifications for hidden commentables 2017-12-11 13:22:10 +01:00
Raimond Garcia
11e80fbc92 Merge pull request #1903 from wairbut-m2c/aperez-enable-disable-proposals
Add enable/disable option for 'Proposals' feature
2017-12-08 11:41:13 +01:00
decabeza
377a1d9f01 improves following view and updates specs 2017-12-07 16:31:05 +01:00
Raimond Garcia
22a8157165 Merge branch 'master' into aperez-email-specs-for-commentables 2017-12-07 13:05:25 +01:00
decabeza
1d6877b797 adds setting allow_images to specs 2017-12-06 20:59:34 +01:00
decabeza
83c23c35c4 changes title text for public interests list 2017-12-06 15:40:50 +01:00
María Checa
f9e65b0f80 Merge pull request #2102 from wairbut-m2c/iagirre-admin-poll-stats
Iagirre admin poll stats
2017-11-29 20:07:53 +01:00
BertoCQ
e7226dfca1 Merge pull request #2153 from consul/social-meta-tags
Social meta tags
2017-11-29 10:54:05 +01:00
Raimond Garcia
9e12d67f3f Merge pull request #2114 from wairbut-m2c/iagirre-booth-assignment-removal
Iagirre booth assignment removal
2017-11-28 19:59:20 +01:00
Raimond Garcia
778ddbee0f Merge pull request #2131 from wairbut-m2c/iagirre-budget-pagination-bug
Iagirre budget pagination bug
2017-11-27 16:49:27 +01:00
Bertocq
33f47e7a63 Increase social media meta tags spec 2017-11-27 13:28:37 +01:00
decabeza
1534e6fc42 unifies social media meta tags specs 2017-11-24 21:36:38 +01:00
decabeza
80d99b71a9 adds specs 2017-11-24 14:14:41 +01:00
decabeza
81392ae8f2 Merge branch 'master' into community-design 2017-11-21 20:52:05 +01:00
BertoCQ
104a26db35 Merge pull request #2110 from wairbut-m2c/aperez-remove-valuator-role
Add option to unassign Valuator role
2017-11-21 16:34:16 +01:00
BertoCQ
ae71f4960b Merge pull request #2068 from ortegacmanuel/add-investment-user-tags-admin-interface
Add investment user tags admin interface
2017-11-19 14:42:01 +01:00
Bertocq
554188f8d0 Expect pagination url links to contain full path including domain 2017-11-18 10:43:54 +01:00
Angel Perez
2bdc2c27d7 Add email specs for Poll 2017-11-17 13:14:03 -04:00
Angel Perez
4c110e8100 Add email specs for Topic 2017-11-17 13:14:03 -04:00
Angel Perez
3605a43947 Add email specs for Budget::Investment 2017-11-17 13:14:03 -04:00