consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
13,635 Commits 1 Branch 0 Tags
72c6b05c646f49d56341d40b7ed2c931c1f4059c
Commit Graph

13635 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Julian Herrero
ab1e9a9310 Fix typo 2019-01-14 18:48:31 +01:00
Julian Herrero
2331cd048e Add pending specs for proposal notifications limits 2019-01-14 18:48:16 +01:00
Julian Nicolas Herrero
3c95bc1d8c Merge pull request #3175 from consul/backport-1814-enable_double_quotes_rubocop_rule 
Enable double quotes rubocop rule
 2019-01-14 13:50:41 +01:00
Julian Herrero
4af0de2d1d Enable double quotes rubocop rule 2019-01-14 13:13:37 +01:00
Julian Herrero
d77183ee09 Improvement - CRUD budgets and content blocks 2019-01-14 12:59:48 +01:00
rogelio-o
ea76179002 Solves #3153. It refactors images attributes. 2019-01-12 17:42:55 +01:00
Javi Martín
f8e9566699 Simplify return statement 
Just the way is usually done in the rest of the code.
 2019-01-10 16:11:51 +01:00
Javi Martín
d5d800f75c Simplify SORTING_OPTIONS usage 
Using a hash instead of an array of hashes makes accessing its keys and
values much easier.
 2019-01-10 16:11:51 +01:00
Javi Martín
68fb295db5 Use if blocks instead of two ternary operators 
Using a simple ternary operator is usually fine; however, code combining
two ternary operator is a bit hard to follow.
 2019-01-10 16:11:51 +01:00
Javi Martín
eb6bba52e3 Simplify code 
The string inside `params[:direction]` should already use lowercase
characters.
 2019-01-10 16:11:51 +01:00
Javi Martín
814579d58f Simplify interpolation 
It's OK ot use single quotes inside a string with double quotes in order
to avoid escape characters.
 2019-01-10 16:11:51 +01:00
Javi Martín
ee2f970e03 Fix sorting links for non-English languages 
We were assuming the translation and the column name were related.
 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
3fd7b3d216 Extract setting icon and direction to methods 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
0fe9ea08c3 Fix the direction assignment 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
e88acb8905 Make params handling case insensitive 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
e264490bca Styling and refactor sorting methods and helpers 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
3ab70ff0d8 Move validating params to model 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
37b2226432 Make the link_to helper more readable 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
cb761c56c2 Fix issue with app crashing when sort_by param was incorrect 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
101292d303 Rename allowed sort option variable 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
39cc997ef4 Add check for arrow icons 2019-01-10 16:11:51 +01:00
Anna Anks Nowak
0affaaee7e Refactor sorting specs to work with direction 2019-01-10 16:11:46 +01:00
Anna Anks Nowak
747b8295b1 Refactor link_to_investments_sorted method 2019-01-10 15:35:54 +01:00
Anna Anks Nowak
35cebe0eef Use symbols in sorting and set direction properly 2019-01-10 15:35:54 +01:00
Anna Anks Nowak
12484ed4fd Change SORTING_OPTIONS to has 2019-01-10 15:35:54 +01:00
Anna Anks Nowak
2523775d9f Make the conditional more readable temporarily 2019-01-10 15:35:54 +01:00
Anna Anks Nowak
9786b0bf7d Rewrite sorting to support direction param [#2931] 2019-01-10 15:34:33 +01:00
Anna Anks Nowak
2877229904 Move the link styling to th [#2931] 2019-01-10 15:28:55 +01:00
Anna Anks Nowak
5dd468092a Rewrite the method to not use budget_investments_sorting_options [#2931] 2019-01-10 15:28:55 +01:00
Anna Anks Nowak
22059379f5 Refactor by creating a helper method for generating sorting links [#2931] 2019-01-10 15:28:55 +01:00
Anna Anks Nowak
ea3319ae6f Add sorting links to table headers with proper styling [#2931] 2019-01-10 15:28:55 +01:00
Julian Nicolas Herrero
cc288fcedd Merge pull request #3167 from consul/backport-1793-cleanup_lines_controller 
[Backport] Remove before action not used
 2019-01-10 09:38:07 +01:00
Julian Nicolas Herrero
cd59f1b803 Merge pull request #3133 from consul/backport-1775-bug_management_create_investment_without_location 
[Backport] Bug Management Cannot create Budget Investment without a map location
 2019-01-09 18:02:53 +01:00
Julian Nicolas Herrero
702dc2bef5 Merge pull request #3154 from consul/backport-check_for_deleted_proposals 
[Backport] checks for deleted proposals
 2019-01-09 17:57:01 +01:00
Julian Herrero
0858f4c6f4 cleanup (remove unused code) 2019-01-09 17:49:46 +01:00
Julian Nicolas Herrero
7ccab504f0 Merge pull request #3160 from consul/backport-1784-consistency_remove_semicolon_from_controllers 
[Backport] Remove semicolons from controllers
 2019-01-09 17:46:32 +01:00
Julian Nicolas Herrero
08a692341a Merge pull request #3150 from consul/backport-1769-crud_budget_and_usa 
[Backport] new CRUD budgets, content blocks and heading map
 2019-01-09 17:35:46 +01:00
Javier Martín
90a66239a5 Merge pull request #3151 from consul/backport-fix_admin_investments_default_order 
Add default order for admin budget investments list
 2019-01-09 15:46:52 +01:00
Alberto
3733dc7ae1 Merge pull request #3165 from consul/linelength-rubocop 
[Backport] Enable line length rubocop rule
 2019-01-09 14:43:24 +01:00
decabeza
15dbfdf6e8 Enable line length rubocop rule 2019-01-09 13:45:42 +01:00
Javi Martín
7c06320f39 Fix typo 2019-01-09 12:55:27 +01:00
Javi Martín
be864ee92f Make sure selected investment is visibile in spec 
After changing the order for budget investments, the selected investment
didn't appear on the first page anymore, and so it couldn't be clicked
on during the test.
 2019-01-09 12:55:22 +01:00
Julian Herrero
9a60135d9f [Consistency] remove semicolons from controllers 2019-01-08 15:46:46 +01:00
taitus
573495d208 BugFixes: generate new schema according to migrations. 2019-01-08 13:20:28 +01:00
Alberto
bbcb96027b Merge pull request #3137 from consul/key-dates-processes 
[Backport] Processes key dates
 2019-01-08 10:51:40 +01:00
Alberto
c63ff52905 Merge pull request #3136 from consul/processes-custom-docs 
[Backport] Show documents on processes proposals phase
 2019-01-08 10:50:33 +01:00
João Lutz
47a33ea86c Enable options to show stats and results with any type of voter 2019-01-05 14:08:47 -02:00
rgarcia
e3eb87addb checks for deleted proposals 2019-01-04 15:25:13 +01:00
María Checa
650fe2553e Add default order for admin budget investments list 
When there's no sorting option selected, by default it orders the investment list by supports and, for those with the same number of supports, by ID.
 2019-01-02 12:52:28 +01:00
Julian Herrero
1ea18f0c89 refactor - correct place for block variable 2019-01-02 12:50:01 +01:00