Javi Martín
928312e218
Use sanitize in translations with links
...
Sometimes we're interpolating a link inside a translation, and marking
the whole translations as HTML safe.
However, some translations added by admins to the database or through
crowdin are not entirely under our control.
Although AFAIK crowdin checks for potential cross-site scripting
attacks, it's a good practice to sanitize parts of a string potentially
out of our control before marking the string as HTML safe.
2019-10-08 18:46:21 +02:00
Javi Martín
6fa67b5e53
Use active record translations for labels
...
This way we can simplify the way we generate form fields. In some cases,
we also use the human attribute in table headers, which IMHO makes
sense.
I haven't moved all of them: for example, sometimes a label is
different depending on whether it's shown to administrators, valuators,
or users. And I haven't touched the ones related to devise, since I
wasn't sure about possible side effects.
Note I've also removed placeholders when they had the same text as their
labels, since they weren't helpful. On the contrary, the added redundant
text to the form, potentially distracting users.
2019-10-07 01:56:23 +02:00
Javi Martín
3ea9f3cecf
Simplify generating form fields with labels
...
Instead of generating the label and then a field without a label, we can
directly generate a field with a label.
2019-10-05 16:01:58 +02:00
Javi Martín
f8bd3d4f39
Extract links to signin and signup to methods
2019-10-05 14:07:24 +02:00
Javi Martín
f5d8badeb6
Extract partial to show "login to comment" message
2019-10-05 14:07:24 +02:00
Javi Martín
78c6f6f7e9
Use the same key for "signin" and "signup" texts
...
We were using the same texts in several places
2019-10-05 14:07:23 +02:00
Javi Martín
ae64458fce
Use the same I18n key for "login to comment" text
...
We were using several different keys, all of them having the same
translations.
2019-10-05 14:07:23 +02:00
Javi Martín
f9ed186909
Add rubocop spacing rules
...
We were following these rules in most places; we just didn't define them
anywhere.
2019-09-10 21:04:56 +02:00
Javi Martín
c62da726b8
Apply SpaceAroundErbTag ERB Lint rule
2019-09-10 20:02:15 +02:00
Javi Martín
488461b8ac
Remove consecutive blank lines
2019-09-10 20:02:15 +02:00
Javi Martín
347fc21cf0
Fix trailing whitespace
2019-09-10 19:21:03 +02:00
Julian Herrero
f6489bc604
Use double quotes in app/views
2019-03-19 12:33:07 +01:00
decabeza
abf0fe992e
Removes tablist and tab roles
2018-07-04 17:14:24 +02:00
decabeza
6a812659c3
Adds missing tablist and tab roles
2018-06-06 12:01:17 +02:00
Bertocq
8bfaee7267
Fix missing parenthesis on i18n.l method call
2017-12-13 14:21:20 +01:00
decabeza
0fa59401e4
improves i18n for community
2017-09-21 17:39:32 +02:00
decabeza
c887cb7366
improves html markup on communities and topics views
2017-09-21 17:35:21 +02:00
taitus
f0667937fb
Refactor and extract code to partials.
2017-09-06 14:48:41 +02:00
taitus
64774b0d2d
Refactor topics controller. Add Common abilities. Add destroy action.
2017-09-06 13:30:12 +02:00
taitus
62003b3000
Add back link on community show. Add styles on login to create topic.
2017-09-05 12:55:12 +02:00
taitus
47f897840a
Refactor translates and indent.
2017-09-05 12:55:12 +02:00
Alessandro Cuoghi
f67f4c85c7
If there is no theme, add text and link.
2017-09-05 12:55:12 +02:00
Alessandro Cuoghi
634d782c2c
Fixed error label.
2017-09-05 12:54:32 +02:00
taitus
8f7356f7a4
Add missing spec. Improve readability on topics files
2017-09-05 12:54:32 +02:00
taitus
54cf210b07
Fix rebase with master.
2017-09-05 12:53:37 +02:00
taitus
895c942a39
Add community to investments
2017-09-05 12:52:45 +02:00
taitus
4539c5fa00
Refactor and tests.
2017-09-05 12:52:14 +02:00
Alessandro Cuoghi
555c47e012
Clean code.
2017-09-05 12:51:08 +02:00
Alessandro Cuoghi
1e60bc5cc2
Remove some css. Pass scss-lint
2017-09-05 12:51:08 +02:00
Alessandro Cuoghi
35f6ce4b86
Translate button editar. Activated translations into wide_order_selector.
2017-09-05 12:51:08 +02:00
Alessandro Cuoghi
322ecf4fd5
Changed some translations.
2017-09-05 12:51:08 +02:00
Alessandro Cuoghi
e5fb90f954
Renaming class. Topic show: Added author_info.
2017-09-05 12:51:08 +02:00
Alessandro Cuoghi
11f6515e84
Style topic show. Fix tabs-panel.
2017-09-05 12:51:08 +02:00
Alessandro Cuoghi
83683eb53f
Changed community.yml buttons.
2017-09-05 12:51:08 +02:00
taitus
a1d37fa6c4
Add order on topic index.
2017-09-05 12:51:08 +02:00
Alessandro Cuoghi
b4cdca215d
Added style show community.
2017-09-05 12:51:08 +02:00
taitus
08f58b845d
Add participants to community
2017-09-05 12:51:08 +02:00
taitus
bc95b6f28d
Add description as comment on topic.
2017-09-05 12:51:08 +02:00
taitus
d8b4323555
Add comments tab to topic show
2017-09-05 12:51:08 +02:00
taitus
bea393bcde
Add comments to topics
2017-09-05 12:51:08 +02:00
Alessandro Cuoghi
7cf932490d
remove tag.
2017-09-05 12:51:08 +02:00
taitus
c6e48946bd
Add timestamps to Topic. Add fields on topic list.
2017-09-05 12:51:08 +02:00
taitus
43c17c3fc7
Add communities and topics
2017-09-05 12:51:08 +02:00
