consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
20,024 Commits 1 Branch 0 Tags
202ba3a5f87c57aa6aa926fe5648d4c04dffbb33
Commit Graph

20024 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
taitus
202ba3a5f8 Enable new rule from RuboCop 1.71 2025-03-05 11:43:46 +01:00
taitus
ba22d7fdf7 Enable new rules from RuboCop 1.70 2025-03-05 11:43:46 +01:00
taitus
f4ffee3700 Add and apply Lint/RedundantSafeNavigation RuboCop rule 
We've tested the updated behavior in RuboCop 1.69, found a new offense, and corrected it.
 2025-03-05 11:43:44 +01:00
taitus
4c7fe8a5d9 Enable new rules from RuboCop 1.69 2025-03-05 11:42:47 +01:00
taitus
9081174dd7 Add and apply Style/KeywordArgumentsMerging rubocop rule 
This rule was introduced in RuboCop 1.68 to encourage passing
additional keyword arguments directly instead of using merge.
 2025-03-05 11:42:47 +01:00
taitus
ada35f51f2 Remove unnecessary EnforcedShorthandSyntax definition 
Rubocop 1.67.0 sets EnforcedShorthandSyntax to "either" by default,
so explicitly defining it is no longer necessary.
 2025-03-05 11:42:47 +01:00
dependabot[bot]
204704da06 Bump rubocop from 1.66.1 to 1.71.2 
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.66.1 to 1.71.2.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.66.1...v1.71.2)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Note:
Fix SafeNavigation offense detected by RuboCop 1.67.0
Remove redundant condition that became unnecessary
after updating RuboCop.
 2025-03-05 11:42:44 +01:00
Javi Martín
aeb3655541 Merge pull request #5851 from consuldemocracy/dependabot/bundler/rubocop-rspec-3.4.0 
Bump rubocop-rspec from 3.1.0 to 3.4.0
 2025-03-04 18:03:20 +01:00
dependabot[bot]
203b659de8 Bump rubocop-rspec from 3.1.0 to 3.4.0 
Note we're renaming the RSpec/StringAsInstanceDoubleConstant rule to
RSpec/VerifiedDoubleReference because its name changed in version 3.4.0

Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 3.1.0 to 3.4.0.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rspec/compare/v3.1.0...v3.4.0)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-03-04 17:38:40 +01:00
Javi Martín
e438ec03c0 Merge pull request #5898 from consuldemocracy/fix_pronto_stylelint 
Use pronto.yml to configure pronto-stylelint
 2025-03-04 17:37:24 +01:00
Javi Martín
2a9321d988 Merge pull request #5852 from consuldemocracy/dependabot/bundler/rubocop-rails-2.29.1 
Bump rubocop-rails from 2.26.2 to 2.29.1
 2025-03-02 15:38:02 +01:00
dependabot[bot]
18a7167d2a Bump rubocop-rails from 2.26.2 to 2.29.1 
Note we aren't updating concurrent-ruby (which Dependabot would have
updated) due to an incompatibility with Rails 7.0.

Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.26.2 to 2.29.1.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.26.2...v2.29.1)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-03-02 15:19:12 +01:00
Javi Martín
fb69923f47 Merge pull request #5866 from consuldemocracy/dependabot/bundler/rubocop-performance-1.23.1 
Bump rubocop-performance from 1.22.1 to 1.23.1
 2025-03-02 01:07:09 +01:00
dependabot[bot]
a3265b3f5b Bump rubocop-performance from 1.22.1 to 1.23.1 
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.22.1 to 1.23.1.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.22.1...v1.23.1)

---
updated-dependencies:
- dependency-name: rubocop-performance
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-03-01 23:51:41 +00:00
Javi Martín
3d9325f2fa Merge pull request #5882 from consuldemocracy/dependabot/bundler/pdf-reader-2.14.1 
Bump pdf-reader from 2.12.0 to 2.14.1
 2025-03-02 00:46:56 +01:00
dependabot[bot]
194a8dae59 Bump pdf-reader from 2.12.0 to 2.14.1 
Bumps [pdf-reader](https://github.com/yob/pdf-reader) from 2.12.0 to 2.14.1.
- [Changelog](https://github.com/yob/pdf-reader/blob/main/CHANGELOG)
- [Commits](https://github.com/yob/pdf-reader/compare/v2.12.0...v2.14.1)

---
updated-dependencies:
- dependency-name: pdf-reader
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-03-01 23:30:47 +00:00
Javi Martín
19ed29258e Merge pull request #5835 from consuldemocracy/dependabot/bundler/capistrano-rails-1.7.0 
Bump capistrano-rails from 1.6.3 to 1.7.0
 2025-03-02 00:25:42 +01:00
dependabot[bot]
b71bf4a1ef Bump capistrano-rails from 1.6.3 to 1.7.0 
Note we aren't updating concurrent-ruby (which Dependabot would have
updated) due to an incompatibility with Rails 7.0.

Bumps [capistrano-rails](https://github.com/capistrano/rails) from 1.6.3 to 1.7.0.
- [Release notes](https://github.com/capistrano/rails/releases)
- [Commits](https://github.com/capistrano/rails/compare/v1.6.3...v1.7.0)

---
updated-dependencies:
- dependency-name: capistrano-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-03-02 00:07:06 +01:00
Javi Martín
a94ba293c5 Merge pull request #5809 from consuldemocracy/dependabot/bundler/capistrano-3.19.2 
Bump capistrano from 3.19.1 to 3.19.2
 2025-03-01 23:51:46 +01:00
dependabot[bot]
f4ea8137e5 Bump capistrano from 3.19.1 to 3.19.2 
Note we aren't updating concurrent-ruby (which Dependabot would have
updated) due to an incompatibility with Rails 7.0.

Bumps [capistrano](https://github.com/capistrano/capistrano) from 3.19.1 to 3.19.2.
- [Release notes](https://github.com/capistrano/capistrano/releases)
- [Commits](https://github.com/capistrano/capistrano/compare/v3.19.1...v3.19.2)

---
updated-dependencies:
- dependency-name: capistrano
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-03-01 23:10:56 +01:00
Javi Martín
8e4c61fbb1 Merge pull request #5879 from consuldemocracy/dependabot/bundler/net-imap-0.5.6 
Bump net-imap from 0.5.4 to 0.5.6
 2025-03-01 23:04:30 +01:00
dependabot[bot]
2d6e39063c Bump net-imap from 0.5.4 to 0.5.6 
Bumps [net-imap](https://github.com/ruby/net-imap) from 0.5.4 to 0.5.6.
- [Release notes](https://github.com/ruby/net-imap/releases)
- [Commits](https://github.com/ruby/net-imap/compare/v0.5.4...v0.5.6)

---
updated-dependencies:
- dependency-name: net-imap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-03-01 21:48:24 +00:00
Javi Martín
b751955241 Merge pull request #5773 from consuldemocracy/dependabot/bundler/faker-3.5.1 
Bump faker from 3.4.2 to 3.5.1
 2025-03-01 22:41:33 +01:00
dependabot[bot]
06f0aa0c61 Bump faker from 3.4.2 to 3.5.1 
Note we aren't updating concurrent-ruby (which Dependabot would have
updated) due to an incompatibility with Rails 7.0.

Bumps [faker](https://github.com/faker-ruby/faker) from 3.4.2 to 3.5.1.
- [Release notes](https://github.com/faker-ruby/faker/releases)
- [Changelog](https://github.com/faker-ruby/faker/blob/main/CHANGELOG.md)
- [Commits](https://github.com/faker-ruby/faker/compare/v3.4.2...v3.5.1)

---
updated-dependencies:
- dependency-name: faker
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-03-01 22:24:49 +01:00
Javi Martín
005e4bcfb3 Merge pull request #5778 from consuldemocracy/dependabot/bundler/factory_bot_rails-6.4.4 
Bump factory_bot_rails from 6.4.3 to 6.4.4
 2025-03-01 22:22:07 +01:00
dependabot[bot]
bdc2fb0fbc Bump factory_bot_rails from 6.4.3 to 6.4.4 
Note we aren't updating concurrent-ruby (which Dependabot would have
updated) due to an incompatibility with Rails 7.0.

Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 6.4.3 to 6.4.4.
- [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases)
- [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/main/NEWS.md)
- [Commits](https://github.com/thoughtbot/factory_bot_rails/compare/v6.4.3...v6.4.4)

---
updated-dependencies:
- dependency-name: factory_bot_rails
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-03-01 22:08:52 +01:00
Javi Martín
03d8d9e96d Merge pull request #5859 from DominikPeters/chromium-driver-dockerfile 
Add chromium-driver to Dockerfile
 2025-03-01 19:16:09 +01:00
Dominik Peters
bbcdb6f086 Add chromium-driver to Dockerfile 
In the documentation about using docker, it says:

> System tests also work out of the box, although they might fail the
> first time while the tool running the tests downloads the right
> version of Chromedriver (which is needed to run them), and only
> "headless" mode (with a browser running in the background) is
> supported, which is the mode you'd probably use more than 95% of the
> time anyway.  For example, to run the tests for the homepage:
>
> POSTGRES_PASSWORD=password docker-compose run app bundle exec \
> rspec spec/system/welcome_spec.rb

For me, as predicted, the tests fail the first time, but they continue
to fail after. The errors are of form:

```
Failure/Error: example.run
Selenium::WebDriver::Error::WebDriverError:
  unable to connect to /home/consul/.cache/selenium/chromedriver/linux64
  /132.0.6834.110/chromedriver 127.0.0.1:9515
  # /usr/local/bundle/gems/selenium-webdriver-4.25.0/lib/selenium
  # /webdriver/common/service_manager.rb:132:in `connect_until_stable'
  # ... omitted ...
  # ./spec/spec_helper.rb:41:in `block (3 levels) in <top (required)>'
  # /usr/local/bundle/gems/i18n-1.14.6/lib/i18n.rb:353:in `with_locale'
  # ./spec/spec_helper.rb:40:in `block (2 levels) in <top (required)>'
```

Installing chromium-driver in the Dockerfile fixed it for me.
 2025-03-01 18:57:38 +01:00
Javi Martín
7696d9e5cd Use pronto.yml to configure pronto-stylelint 
This is necessary since pronto-stylelint 0.11.0, which we started using
in commit 2768263fa. We were getting an error when runnin Pronto in pull
requests that changed CSS code:

```
bundler: failed to load command: pronto (~/.rbenv/versions/3.2.7/bin/pronto)
~/.rbenv/versions/3.2.7/lib/ruby/3.2.0/open3.rb:222:in `spawn': No such
file or directory - stylelint (Errno::ENOENT)
```
 2025-02-28 11:43:28 +01:00
Sebastia
2c7e44dda1 Merge pull request #5885 from consuldemocracy/erb_lint_deprecations 
Fix ERB Lint deprecations
 2025-02-19 15:01:06 +00:00
Javi Martín
b557c1d9fc Merge pull request #5887 from consuldemocracy/dependabot/bundler/nokogiri-1.18.3 
Bump nokogiri from 1.18.2 to 1.18.3
 2025-02-19 15:28:53 +01:00
dependabot[bot]
b9724cd180 Bump nokogiri from 1.18.2 to 1.18.3 
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.18.2 to 1.18.3.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/v1.18.3/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.18.2...v1.18.3)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-02-19 13:49:31 +00:00
taitus
94e70e9073 Rename executable deprecated erblint to erb_lint 
Now executable `erblint` is deprecated, then we will use `erb_lint` instead.
 2025-02-14 15:54:28 +01:00
taitus
bec5506c4c Rename config file from .erb-lint.yml to .erb_lint.yml 
The config file has been renamed to `.erb_lint.yml` and `.erb-lint.yml` is
deprecated. Please rename your config file to `.erb_lint.yml`.
 2025-02-14 15:32:58 +01:00
Sebastia
5809948124 Merge pull request #5884 from consuldemocracy/ruby3.2.7 
Upgrade Ruby to version 3.2.7
 2025-02-14 14:23:00 +00:00
taitus
352f702947 Upgrade Ruby to version 3.2.7 2025-02-14 14:50:57 +01:00
Sebastia
3c06997b08 Merge pull request #5868 from consuldemocracy/dependabot/bundler/erb_lint-0.9.0 
Bump erb_lint from 0.6.0 to 0.9.0
 2025-02-14 12:10:00 +00:00
dependabot[bot]
9bfc365a76 Bump erb_lint from 0.6.0 to 0.9.0 
Note we aren't bumping the concurrent-ruby gem (which Dependabot
automatically did) because it causes that our workflows/db_schema.yml
fails.

Bumps [erb_lint](https://github.com/Shopify/erb-lint) from 0.6.0 to 0.9.0.
- [Release notes](https://github.com/Shopify/erb-lint/releases)
- [Commits](https://github.com/Shopify/erb-lint/compare/v0.6.0...v0.9.0)

---
updated-dependencies:
- dependency-name: erb_lint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-02-14 12:43:57 +01:00
Sebastia
accd26fb3b Merge pull request #5872 from consuldemocracy/dependabot/bundler/pronto-stylelint-0.11.0 
Bump pronto-stylelint from 0.10.3 to 0.11.0
 2025-02-14 09:06:57 +00:00
dependabot[bot]
2768263faf Bump pronto-stylelint from 0.10.3 to 0.11.0 
Note we aren't bumping the rugged gem (which Dependabot automatically
did) because it causes Pronto to stop working with GitHub Actions.

Bumps [pronto-stylelint](https://github.com/kevinjalbert/pronto-stylelint) from 0.10.3 to 0.11.0.
- [Commits](https://github.com/kevinjalbert/pronto-stylelint/compare/v0.10.3...v0.11.0)

---
updated-dependencies:
- dependency-name: pronto-stylelint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-02-14 09:48:26 +01:00
Sebastia
ff8d413d0b Merge pull request #5875 from consuldemocracy/dependabot/npm_and_yarn/stylelint-16.14.1 
Bump stylelint from 16.9.0 to 16.14.1
 2025-02-12 16:51:11 +00:00
taitus
c52fed64ad Add new stylelint rules 
These rules were added in stylelint 16.13.0 and IMHO can be usefull check
this rules.

Note that we are add a new rule value in override section because we are
receiving an error for font-url like:
> Unexpected unknown value "font-url("icons.eot")"
 2025-02-12 16:34:57 +01:00
dependabot[bot]
eb53358300 Bump stylelint from 16.9.0 to 16.14.1 
Bumps [stylelint](https://github.com/stylelint/stylelint) from 16.9.0 to 16.14.1.
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/stylelint/stylelint/compare/16.9.0...16.14.1)

---
updated-dependencies:
- dependency-name: stylelint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-02-12 16:34:57 +01:00
Sebastia
9c980d06ff Merge pull request #5874 from consuldemocracy/dependabot/bundler/launchy-3.1.0 
Bump launchy from 2.5.2 to 3.1.0
 2025-02-12 15:34:22 +00:00
Sebastia
a94b5b8ba4 Merge pull request #5876 from consuldemocracy/dependabot/npm_and_yarn/stylelint-scss-6.11.0 
Bump stylelint-scss from 6.7.0 to 6.11.0
 2025-02-12 15:03:00 +00:00
dependabot[bot]
41544bfc59 Bump stylelint-scss from 6.7.0 to 6.11.0 
Bumps [stylelint-scss](https://github.com/stylelint-scss/stylelint-scss) from 6.7.0 to 6.11.0.
- [Release notes](https://github.com/stylelint-scss/stylelint-scss/releases)
- [Changelog](https://github.com/stylelint-scss/stylelint-scss/blob/master/CHANGELOG.md)
- [Commits](https://github.com/stylelint-scss/stylelint-scss/compare/v6.7.0...v6.11.0)

---
updated-dependencies:
- dependency-name: stylelint-scss
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-02-11 18:01:32 +01:00
taitus
c9449190bf Remove unnecessary override rule 
Since commit 761f7777, this rule overwrite that was added in commit
444b8c3 is no longer needed.
 2025-02-11 18:01:32 +01:00
dependabot[bot]
686055da27 Bump launchy from 2.5.2 to 3.1.0 
Bumps [launchy](https://github.com/copiousfreetime/launchy) from 2.5.2 to 3.1.0.
- [Changelog](https://github.com/copiousfreetime/launchy/blob/main/HISTORY.md)
- [Commits](https://github.com/copiousfreetime/launchy/compare/v2.5.2...v3.1.0)

---
updated-dependencies:
- dependency-name: launchy
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2025-02-01 22:39:10 +00:00
Sebastia
be53ce40e9 Merge pull request #5860 from consuldemocracy/set_version_number 
Set release 2.3.0 version number
 2025-01-29 13:58:50 +01:00
taitus
f67dfcc858 Set version number 2025-01-29 13:51:15 +01:00