consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make the translation button condition more readable

Browse Source 
I was finding this part hard to follow, but after changing the name of
the condition suddenly I understood what was going on.
This commit is contained in:
Javi Martín
2023-01-29 17:54:17 +01:00
parent 2f0327acf8
commit fe3c9d47fa
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/components/layout/remote_translations_button_component.html.erb
View File

@@ -1,11 +1,11 @@
<div class="remote-translations-button">
<% if display_remote_translation_button? %>
<% if translations_in_progress? %>
<%= t("remote_translations.all_remote_translations_enqueued_text") %>
<% else %>
<%= form_tag remote_translations_path do %>
<%= hidden_field_tag :remote_translations, remote_translations.to_json %>
<%= t("remote_translations.text") %>
<%= submit_tag t("remote_translations.button") %>
<% end %>
<% else %>
<%= t("remote_translations.all_remote_translations_enqueued_text") %>
<% end %>
</div>

4
app/components/layout/remote_translations_button_component.rb
View File

@@ -12,7 +12,7 @@ class Layout::RemoteTranslationsButtonComponent < ApplicationComponent
private
def display_remote_translation_button?
remote_translations.none?(&:enqueued?)
def translations_in_progress?
remote_translations.any?(&:enqueued?)
end
end