consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use consistent names in poll question answer tests

Browse Source 
We were using three different variable names for the same thing, in
consecutite tests.
This commit is contained in:
Javi Martín
2024-05-13 19:15:52 +02:00
parent 2117720c6c
commit fd04860032
1 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
spec/models/poll/question/answer_spec.rb
View File

@@ -17,15 +17,15 @@ describe Poll::Question::Answer do
end
it "returns answers with documents and no description" do
question = create(:poll_question_answer, :with_document, description: "")
answer = create(:poll_question_answer, :with_document, description: "")
expect(Poll::Question::Answer.with_content).to eq [question]
expect(Poll::Question::Answer.with_content).to eq [answer]
end
it "returns answers with videos and no description" do
question = create(:poll_question_answer, :with_video, description: "")
answer = create(:poll_question_answer, :with_video, description: "")
expect(Poll::Question::Answer.with_content).to eq [question]
expect(Poll::Question::Answer.with_content).to eq [answer]
end
it "does not return answers with no description and no images, documents nor videos" do
@@ -37,27 +37,27 @@ describe Poll::Question::Answer do
describe "#with_read_more?" do
it "returns false when the answer does not have description, images, videos nor documents" do
poll_question_answer = build(:poll_question_answer, description: nil)
answer = build(:poll_question_answer, description: nil)
expect(poll_question_answer.with_read_more?).to be_falsy
expect(answer.with_read_more?).to be_falsy
end
it "returns true when the answer has description, images, videos or documents" do
poll_question_answer = build(:poll_question_answer, description: "Answer description")
answer = build(:poll_question_answer, description: "Answer description")
expect(poll_question_answer.with_read_more?).to be_truthy
expect(answer.with_read_more?).to be_truthy
poll_question_answer = build(:poll_question_answer, :with_image)
answer = build(:poll_question_answer, :with_image)
expect(poll_question_answer.with_read_more?).to be_truthy
expect(answer.with_read_more?).to be_truthy
poll_question_answer = build(:poll_question_answer, :with_document)
answer = build(:poll_question_answer, :with_document)
expect(poll_question_answer.with_read_more?).to be_truthy
expect(answer.with_read_more?).to be_truthy
poll_question_answer = build(:poll_question_answer, :with_video)
answer = build(:poll_question_answer, :with_video)
expect(poll_question_answer.with_read_more?).to be_truthy
expect(answer.with_read_more?).to be_truthy
end
end
end