consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #4023 from consul/homepage_confirm_dialog

Browse Source 
Don't use confirm dialog in admin homepage form
This commit is contained in:
Javier Martín
2020-05-26 18:14:58 +02:00
committed by GitHub
parent a3ed4e380e 5bf968d2b2
commit f929108870
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/views/admin/homepage/_setting.html.erb
View File

@@ -5,7 +5,6 @@
value: (setting.enabled? ? "" : "active") %>
<%= f.submit(t("admin.settings.index.features.#{setting.enabled? ? "disable" : "enable"}"),
class: "button #{setting.enabled? ? "hollow alert" : "success"}",
data: { confirm: t("admin.actions.confirm") }) %>
class: "button #{setting.enabled? ? "hollow alert" : "success"}") %>
<% end %>
</div>

10
spec/system/admin/homepage/homepage_spec.rb
View File

@@ -36,7 +36,7 @@ describe "Homepage" do
within("#widget_feed_#{proposals_feed.id}") do
select "1", from: "widget_feed_limit"
accept_confirm { click_button "Enable" }
click_button "Enable"
end
visit root_path
@@ -55,7 +55,7 @@ describe "Homepage" do
visit admin_homepage_path
within("#widget_feed_#{debates_feed.id}") do
select "2", from: "widget_feed_limit"
accept_confirm { click_button "Enable" }
click_button "Enable"
end
visit root_path
@@ -76,12 +76,12 @@ describe "Homepage" do
within("#widget_feed_#{proposals_feed.id}") do
select "3", from: "widget_feed_limit"
accept_confirm { click_button "Enable" }
click_button "Enable"
end
within("#widget_feed_#{debates_feed.id}") do
select "3", from: "widget_feed_limit"
accept_confirm { click_button "Enable" }
click_button "Enable"
end
visit root_path
@@ -106,7 +106,7 @@ describe "Homepage" do
visit admin_homepage_path
within("#widget_feed_#{processes_feed.id}") do
select "3", from: "widget_feed_limit"
accept_confirm { click_button "Enable" }
click_button "Enable"
end
visit root_path