Merge pull request #3274 from consul/backport_send_newsletter_emails_in_order

[Backport] Send newsletter emails in order

lib/user_segments.rb

@@ -50,7 +50,7 @@ class UserSegments
   end
 
   def self.user_segment_emails(users_segment)
-    UserSegments.send(users_segment).newsletter.pluck(:email).compact
+    UserSegments.send(users_segment).newsletter.order(:created_at).pluck(:email).compact
   end
 
   private

spec/lib/user_segments_spec.rb

@@ -190,4 +190,15 @@ describe UserSegments do
     end
   end
 
+  describe "#user_segment_emails" do
+    it "returns list of emails sorted by user creation date" do
+      create(:user, email: "first@email.com", created_at: 1.day.ago)
+      create(:user, email: "last@email.com")
+
+      emails = described_class.user_segment_emails(:all_users)
+      expect(emails.first).to eq "first@email.com"
+      expect(emails.last).to eq "last@email.com"
+    end
+  end
+
 end