Merge pull request #3112 from consul/rubocop_not_to

Add not_to Rubocop rule

.rubocop.yml

@@ -336,9 +336,6 @@ RSpec/NestedGroups:
   Enabled: true
   Max: 4
 
-RSpec/NotToNot:
-  Enabled: true
-
 RSpec/OverwritingSetup:
   Enabled: true
 

.rubocop_basic.yml

@@ -26,3 +26,6 @@ Layout/TrailingBlankLines:
 
 Layout/TrailingWhitespace:
   Enabled: true
+
+RSpec/NotToNot:
+  Enabled: true

spec/features/admin/poll/questions/answers/images/images_spec.rb

@@ -14,7 +14,7 @@ feature 'Images' do
 
       visit admin_answer_images_path(answer)
 
-      expect(page).to_not have_css("img[title='']")
+      expect(page).not_to have_css("img[title='']")
     end
 
     scenario 'Answer with images' do
@@ -35,8 +35,8 @@ feature 'Images' do
     image = create(:image)
 
     visit admin_answer_images_path(answer)
-    expect(page).to_not have_css("img[title='clippy.jpg']")
-    expect(page).to_not have_content('clippy.jpg')
+    expect(page).not_to have_css("img[title='clippy.jpg']")
+    expect(page).not_to have_content('clippy.jpg')
 
     visit new_admin_answer_image_path(answer)
     imageable_attach_new_file(image, Rails.root.join('spec/fixtures/files/clippy.jpg'))
@@ -59,8 +59,8 @@ feature 'Images' do
       click_link 'Remove image'
     end
 
-    expect(page).to_not have_css("img[title='#{image.title}']")
-    expect(page).to_not have_content(image.title)
+    expect(page).not_to have_css("img[title='#{image.title}']")
+    expect(page).not_to have_content(image.title)
   end
 
 end

spec/features/admin/valuator_groups_spec.rb

@@ -118,9 +118,9 @@ feature "Valuator groups" do
       click_button "Update valuator"
 
       expect(page).to have_content "Valuator updated successfully"
-      expect(page).to_not have_content "Health"
+      expect(page).not_to have_content "Health"
     end
 
   end
 
-end
+end

spec/features/budgets/budgets_spec.rb

@@ -404,8 +404,8 @@ feature 'Budgets' do
       expect(page).to have_css("#budget_heading_#{heading1.id}")
       expect(page).to have_css("#budget_heading_#{heading2.id}")
 
-      expect(page).to_not have_css("#budget_heading_#{heading3.id}")
-      expect(page).to_not have_css("#budget_heading_#{heading4.id}")
+      expect(page).not_to have_css("#budget_heading_#{heading3.id}")
+      expect(page).not_to have_css("#budget_heading_#{heading4.id}")
     end
 
     scenario "See results button is showed if the budget has finished for all users" do

spec/features/budgets/investments_spec.rb

@@ -62,7 +62,7 @@ feature 'Budget Investments' do
     investments.each do |investment|
       within('#budget-investments') do
         expect(page).to     have_link investment.title
-        expect(page).to_not have_content(investment.description)
+        expect(page).not_to have_content(investment.description)
       end
     end
 

spec/features/debates_spec.rb

@@ -59,7 +59,7 @@ feature 'Debates' do
     debates.each do |debate|
       within('#debates') do
         expect(page).to     have_link debate.title
-        expect(page).to_not have_content debate.description
+        expect(page).not_to have_content debate.description
       end
     end
 

spec/features/legislation/processes_spec.rb

@@ -156,7 +156,7 @@ feature 'Legislation' do
 
         visit legislation_process_path(process)
 
-        expect(page).to_not have_content("Additional information")
+        expect(page).not_to have_content("Additional information")
       end
 
       scenario "Shows another translation when the default locale isn't available" do
@@ -201,7 +201,7 @@ feature 'Legislation' do
         visit legislation_process_path(process)
 
         expect(page).to     have_content("This phase is not open yet")
-        expect(page).to_not have_content("Participate in the debate")
+        expect(page).not_to have_content("Participate in the debate")
       end
 
       scenario 'open without questions' do
@@ -209,8 +209,8 @@ feature 'Legislation' do
 
         visit legislation_process_path(process)
 
-        expect(page).to_not have_content("Participate in the debate")
-        expect(page).to_not have_content("This phase is not open yet")
+        expect(page).not_to have_content("Participate in the debate")
+        expect(page).not_to have_content("This phase is not open yet")
       end
 
       scenario 'open with questions' do
@@ -223,7 +223,7 @@ feature 'Legislation' do
         expect(page).to     have_content("Question 1")
         expect(page).to     have_content("Question 2")
         expect(page).to     have_content("Participate in the debate")
-        expect(page).to_not have_content("This phase is not open yet")
+        expect(page).not_to have_content("This phase is not open yet")
       end
 
       include_examples "not published permissions", :debate_legislation_process_path

spec/features/notifications_spec.rb

@@ -20,7 +20,7 @@ feature "Notifications" do
     expect(page).to have_css(".notification", count: 2)
     expect(page).to have_content(read1.notifiable_title)
     expect(page).to have_content(read2.notifiable_title)
-    expect(page).to_not have_content(unread.notifiable_title)
+    expect(page).not_to have_content(unread.notifiable_title)
   end
 
   scenario "View unread" do
@@ -34,7 +34,7 @@ feature "Notifications" do
     expect(page).to have_css(".notification", count: 2)
     expect(page).to have_content(unread1.notifiable_title)
     expect(page).to have_content(unread2.notifiable_title)
-    expect(page).to_not have_content(read.notifiable_title)
+    expect(page).not_to have_content(read.notifiable_title)
   end
 
   scenario "View single notification" do
@@ -65,7 +65,7 @@ feature "Notifications" do
 
     expect(page).to have_css(".notification", count: 1)
     expect(page).to have_content(notification2.notifiable_title)
-    expect(page).to_not have_content(notification1.notifiable_title)
+    expect(page).not_to have_content(notification1.notifiable_title)
   end
 
   scenario "Mark all as read" do
@@ -112,7 +112,7 @@ feature "Notifications" do
     first(".notification a").click
 
     within("#notifications") do
-      expect(page).to_not have_css(".icon-circle")
+      expect(page).not_to have_css(".icon-circle")
     end
   end
 
@@ -125,7 +125,7 @@ feature "Notifications" do
     logout
     visit root_path
 
-    expect(page).to_not have_css("#notifications")
+    expect(page).not_to have_css("#notifications")
   end
 
   scenario "Notification's notifiable model no longer includes Notifiable module" do

spec/features/proposals_spec.rb

@@ -67,7 +67,7 @@ feature 'Proposals' do
       proposals.each do |proposal|
         within('#proposals') do
           expect(page).to     have_link proposal.title
-          expect(page).to_not have_content proposal.summary
+          expect(page).not_to have_content proposal.summary
         end
       end
 

spec/features/users_auth_spec.rb

@@ -202,7 +202,7 @@ feature 'Users' do
         click_link 'Cancel login'
 
         visit '/'
-        expect_to_not_be_signed_in
+        expect_not_to_be_signed_in
       end
 
       scenario 'Sign in, user was already signed up with OAuth' do

spec/models/budget/investment_spec.rb

@@ -328,7 +328,7 @@ describe Budget::Investment do
 
        expect(investments_by_budget).to include investment1
        expect(investments_by_budget).to include investment2
-       expect(investments_by_budget).to_not include investment3
+       expect(investments_by_budget).not_to include investment3
     end
   end
 
@@ -811,11 +811,11 @@ describe Budget::Investment do
 
       expect(another_investment.headings_voted_by_user(user1)).to include(new_york.id)
       expect(another_investment.headings_voted_by_user(user1)).to include(san_franciso.id)
-      expect(another_investment.headings_voted_by_user(user1)).to_not include(another_heading.id)
+      expect(another_investment.headings_voted_by_user(user1)).not_to include(another_heading.id)
 
-      expect(another_investment.headings_voted_by_user(user2)).to_not include(new_york.id)
-      expect(another_investment.headings_voted_by_user(user2)).to_not include(san_franciso.id)
-      expect(another_investment.headings_voted_by_user(user2)).to_not include(another_heading.id)
+      expect(another_investment.headings_voted_by_user(user2)).not_to include(new_york.id)
+      expect(another_investment.headings_voted_by_user(user2)).not_to include(san_franciso.id)
+      expect(another_investment.headings_voted_by_user(user2)).not_to include(another_heading.id)
     end
   end
 

spec/models/notification_spec.rb

@@ -12,7 +12,7 @@ describe Notification do
 
     it "should not be valid without a user" do
       notification.user = nil
-      expect(notification).to_not be_valid
+      expect(notification).not_to be_valid
     end
 
   end

spec/models/valuator_spec.rb

@@ -30,7 +30,7 @@ describe Valuator do
       assigned_investment_ids = valuator.assigned_investment_ids
       expect(assigned_investment_ids).to include investment1.id
       expect(assigned_investment_ids).to include investment2.id
-      expect(assigned_investment_ids).to_not include investment3.id
+      expect(assigned_investment_ids).not_to include investment3.id
     end
 
     it "returns investments assigned to a valuator group" do
@@ -47,7 +47,7 @@ describe Valuator do
       assigned_investment_ids = valuator.assigned_investment_ids
       expect(assigned_investment_ids).to include investment1.id
       expect(assigned_investment_ids).to include investment2.id
-      expect(assigned_investment_ids).to_not include investment3.id
+      expect(assigned_investment_ids).not_to include investment3.id
     end
   end
 end

spec/support/common_actions/users.rb

@@ -79,7 +79,7 @@ module Users
     expect(find('.top-bar-right')).to have_content 'My account'
   end
 
-  def expect_to_not_be_signed_in
+  def expect_not_to_be_signed_in
     expect(find('.top-bar-right')).not_to have_content 'My account'
   end
 end