consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Indicate that links inside labels open in a new window

Browse Source 
Most screen readers don't notify when a link is about to open in a new
window [1], so we're indicating it, like we were already doing in most
places with similar links.

We could also add a visual indicator, but since links inside labels
already have accessibility issues, giving more attention to these links
might make matters worse.

[1] https://www.powermapper.com/tests/screen-readers/navigation/a-target-blank/
This commit is contained in:
Javi Martín
2023-10-15 16:37:37 +02:00
parent cc25dbe437
commit e19c16d4e2
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/components/shared/agree_with_terms_of_service_field_component.rb
View File

@@ -9,7 +9,8 @@ class Shared::AgreeWithTermsOfServiceFieldComponent < ApplicationComponent
def label
t("form.accept_terms",
policy: link_to(t("form.policy"), "/privacy", target: "_blank"),
conditions: link_to(t("form.conditions"), "/conditions", target: "_blank"))
policy: link_to(t("form.policy"), "/privacy", target: "_blank", title: t("shared.target_blank")),
conditions: link_to(t("form.conditions"), "/conditions", target: "_blank",
title: t("shared.target_blank")))
end
end

9
spec/components/shared/agree_with_terms_of_service_field_component_spec.rb
View File

@@ -18,4 +18,13 @@ describe Shared::AgreeWithTermsOfServiceFieldComponent do
expect(page).to have_css "a[target=_blank]", count: 2
end
it "contains links indicating they open in a new window" do
render_inline component
expect(page).to have_link count: 2
expect(page).to have_link "Privacy Policy"
expect(page).to have_link "Terms and conditions of use"
expect(page).to have_link " (link opens in new window)", count: 2
end
end