Merge pull request #3103 from consul/backport-update_legislation_milestone_form

Edit only existing languages in milestones summary

app/views/admin/legislation/milestones/_summary_form.html.erb

@@ -1,4 +1,6 @@
-<%= render "admin/shared/globalize_locales", resource: @process %>
+<%= render "admin/shared/globalize_tabs",
+           resource: @process,
+           display_style: lambda { |locale| enable_translation_style(@process, locale) } %>
 
 <%= translatable_form_for [:admin, @process] do |f| %>
   <%= f.translatable_fields do |translations_form| %>

app/views/admin/shared/_common_globalize_locales.html.erb

@@ -8,17 +8,7 @@
   </div>
 <% end %>
 
-<ul class="tabs" data-tabs id="globalize_locale">
+<%= render "admin/shared/globalize_tabs", resource: resource, display_style: display_style %>
-  <% I18n.available_locales.each do |locale| %>
-    <li class="tabs-title">
-      <%= link_to name_for_locale(locale), "#",
-                  style: display_style.call(locale),
-                  class: "js-globalize-locale-link #{highlight_class(resource, locale)}",
-                  data: { locale: locale },
-                  remote: true %>
-    </li>
-  <% end %>
-</ul>
 
 <div class="small-12 medium-6">
   <%= select_tag :translation_locale,

app/views/admin/shared/_globalize_tabs.html.erb

@@ -0,0 +1,11 @@
+<ul class="tabs" data-tabs id="globalize_locale">
+  <% I18n.available_locales.each do |locale| %>
+    <li class="tabs-title">
+      <%= link_to name_for_locale(locale), "#",
+                  style: display_style.call(locale),
+                  class: "js-globalize-locale-link #{highlight_class(resource, locale)}",
+                  data: { locale: locale },
+                  remote: true %>
+    </li>
+  <% end %>
+</ul>

spec/features/admin/legislation/processes_spec.rb

@@ -192,6 +192,9 @@ feature 'Admin legislation processes' do
     scenario "Edit milestones summary", :js do
       visit admin_legislation_process_milestones_path(process)
 
+      expect(page).not_to have_link "Remove language"
+      expect(page).not_to have_field "translation_locale"
+
       within(".translatable-fields[data-locale='en']") do
         fill_in_ckeditor find("textarea", visible: false)[:id],
                          with: "There is still a long journey ahead of us"