Fix found Hound violations

This commit is contained in:
taitus
2019-04-23 16:56:18 +02:00
committed by voodoorai2000
parent abb81fccf4
commit d2506358ef
6 changed files with 73 additions and 67 deletions

View File

@@ -11,9 +11,9 @@ module RemotelyTranslatable
end
def remote_translation_for(resource)
{ 'remote_translatable_id' => resource.id.to_s,
'remote_translatable_type' => resource.class.to_s,
'locale' => I18n.locale }
{ "remote_translatable_id" => resource.id.to_s,
"remote_translatable_type" => resource.class.to_s,
"locale" => I18n.locale }
end
def translation_empty?(resource)

View File

@@ -8,25 +8,27 @@ class RemoteTranslationsController < ApplicationController
@remote_translations.each do |remote_translation|
RemoteTranslation.create(remote_translation) unless translations_enqueued?(remote_translation)
end
redirect_to request.referer, notice: t('remote_translations.create.enqueue_remote_translation')
redirect_to request.referer, notice: t("remote_translations.create.enqueue_remote_translation")
end
private
def remote_translations_params
params.permit(:remote_translations)
end
def remote_translations_params
params.permit(:remote_translations)
end
def set_remote_translations
decoded_remote_translations = ActiveSupport::JSON.decode(remote_translations_params["remote_translations"])
@remote_translations = decoded_remote_translations.map{ |remote_translation|
remote_translation.slice("remote_translatable_id","remote_translatable_type","locale")
}
end
def set_remote_translations
remote_translations = remote_translations_params["remote_translations"]
decoded_remote_translations = ActiveSupport::JSON.decode(remote_translations)
@remote_translations = decoded_remote_translations.map{ |remote_translation|
remote_translation.slice("remote_translatable_id",
"remote_translatable_type",
"locale")
}
end
def translations_enqueued?(remote_translation)
RemoteTranslation.remote_translation_enqueued?(remote_translation)
end
def translations_enqueued?(remote_translation)
RemoteTranslation.remote_translation_enqueued?(remote_translation)
end
end