changes unselected scope to include undecided feasibility

This commit is contained in:
Juanjo Bazán
2017-05-17 15:13:29 +02:00
parent 4787ee5716
commit d08af6193e
3 changed files with 45 additions and 1 deletions

View File

@@ -47,7 +47,7 @@ class Budget
scope :undecided, -> { where(feasibility: "undecided") }
scope :with_supports, -> { where('cached_votes_up > 0') }
scope :selected, -> { feasible.where(selected: true) }
scope :unselected, -> { feasible.where(selected: false) }
scope :unselected, -> { not_unfeasible.where(selected: false) }
scope :last_week, -> { where("created_at >= ?", 7.days.ago)}
scope :by_group, -> (group_id) { where(group_id: group_id) }

View File

@@ -275,6 +275,10 @@ FactoryGirl.define do
unfeasibility_explanation "set to unfeasible on creation"
end
trait :undecided do
feasibility "undecided"
end
trait :finished do
valuation_finished true
end

View File

@@ -342,6 +342,46 @@ describe Budget::Investment do
expect(Budget::Investment.unfeasible).to eq [unfeasible_investment]
end
end
describe "not_unfeasible" do
it "should return all feasible and undecided investments" do
unfeasible_investment = create(:budget_investment, :unfeasible)
undecided_investment = create(:budget_investment, :undecided)
feasible_investment = create(:budget_investment, :feasible)
expect(Budget::Investment.not_unfeasible.sort).to eq [undecided_investment, feasible_investment].sort
end
end
describe "undecided" do
it "should return all undecided investments" do
unfeasible_investment = create(:budget_investment, :unfeasible)
undecided_investment = create(:budget_investment, :undecided)
feasible_investment = create(:budget_investment, :feasible)
expect(Budget::Investment.undecided).to eq [undecided_investment]
end
end
describe "selected" do
it "should return all selected investments" do
selected_investment = create(:budget_investment, :selected)
unselected_investment = create(:budget_investment, :unselected)
expect(Budget::Investment.selected).to eq [selected_investment]
end
end
describe "unselected" do
it "should return all unselected not_unfeasible investments" do
selected_investment = create(:budget_investment, :selected)
unselected_unfeasible_investment = create(:budget_investment, :unselected, :unfeasible)
unselected_undecided_investment = create(:budget_investment, :unselected, :undecided)
unselected_feasible_investment = create(:budget_investment, :unselected, :feasible)
expect(Budget::Investment.unselected.sort).to eq [unselected_undecided_investment, unselected_feasible_investment].sort
end
end
end
describe "apply_filters_and_search" do