consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #5766 from consuldemocracy/graphql-refactor

Browse Source 
Reduce code duplication in Graphql
This commit is contained in:
Sebastia
2024-11-06 14:10:50 +01:00
committed by GitHub
parent 04356accb9 2938ced41c
commit c91501a056
8 changed files with 39 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/graphql/types/base_object.rb
View File

@@ -24,5 +24,15 @@ module Types
define_method(field_name) { object.send(field_name).public_for_api }
end
end
def self.object_by_id_field(field_name, type, description, null:)
field field_name, type, description, null: null do
argument :id, ID, required: true, default_value: false
end
end
def self.collection_field(field_name, type, ...)
field(field_name, type.connection_type, ...)
end
end
end

4
app/graphql/types/budget_investment_type.rb
View File

@@ -7,8 +7,8 @@ module Types
field :title, String, null: true
field :description, String, null: true
field :location, String, null: true
field :comments, Types::CommentType.connection_type, null: true
collection_field :comments, Types::CommentType, null: true
field :comments_count, Integer, null: true
field :milestones, Types::MilestoneType.connection_type, null: true
collection_field :milestones, Types::MilestoneType, null: true
end
end

6
app/graphql/types/budget_type.rb
View File

@@ -3,10 +3,8 @@ module Types
field :id, ID, null: false
field :name, String, null: true
field :phase, String, null: true
field :investments, Types::BudgetInvestmentType.connection_type, "Returns all investments", null: false
field :investment, Types::BudgetInvestmentType, null: false do
argument :id, ID, required: true, default_value: false
end
collection_field :investments, Types::BudgetInvestmentType, "Returns all investments", null: false
object_by_id_field :investment, Types::BudgetInvestmentType, "Returns investment for ID", null: false
def investments
Budget::Investment.public_for_api

2
app/graphql/types/comment_type.rb
View File

@@ -11,6 +11,6 @@ module Types
field :id, ID, null: false
field :public_author, Types::UserType, null: true
field :public_created_at, String, null: true
field :votes_for, Types::VoteType.connection_type, null: true
collection_field :votes_for, Types::VoteType, null: true
end
end

6
app/graphql/types/debate_type.rb
View File

@@ -3,7 +3,7 @@ module Types
field :cached_votes_down, Integer, null: true
field :cached_votes_total, Integer, null: true
field :cached_votes_up, Integer, null: true
field :comments, Types::CommentType.connection_type, null: true
collection_field :comments, Types::CommentType, null: true
field :comments_count, Integer, null: true
field :confidence_score, Integer, null: true
field :description, String, null: true
@@ -11,9 +11,9 @@ module Types
field :id, ID, null: false
field :public_author, Types::UserType, null: true
field :public_created_at, String, null: true
field :tags, Types::TagType.connection_type, null: true
collection_field :tags, Types::TagType, null: true
field :title, String, null: true
field :votes_for, Types::VoteType.connection_type, null: true
collection_field :votes_for, Types::VoteType, null: true
def tags
object.tags.public_for_api

10
app/graphql/types/proposal_type.rb
View File

@@ -1,7 +1,7 @@
module Types
class ProposalType < Types::BaseObject
field :cached_votes_up, Integer, null: true
field :comments, Types::CommentType.connection_type, null: true
collection_field :comments, Types::CommentType, null: true
field :comments_count, Integer, null: true
field :confidence_score, Integer, null: true
field :description, String, null: true
@@ -9,18 +9,18 @@ module Types
field :geozone_id, Integer, null: true
field :hot_score, Integer, null: true
field :id, ID, null: false
field :proposal_notifications, Types::ProposalNotificationType.connection_type, null: true
collection_field :proposal_notifications, Types::ProposalNotificationType, null: true
field :public_author, Types::UserType, null: true
field :public_created_at, String, null: true
field :retired_at, GraphQL::Types::ISO8601DateTime, null: true
field :retired_explanation, String, null: true
field :retired_reason, String, null: true
field :summary, String, null: true
field :tags, Types::TagType.connection_type, null: true
collection_field :tags, Types::TagType, null: true
field :title, String, null: true
field :video_url, String, null: true
field :votes_for, Types::VoteType.connection_type, null: true
field :milestones, Types::MilestoneType.connection_type, null: true
collection_field :votes_for, Types::VoteType, null: true
collection_field :milestones, Types::MilestoneType, null: true
def tags
object.tags.public_for_api

67
app/graphql/types/query_type.rb
View File

@@ -1,61 +1,20 @@
module Types
class QueryType < Types::BaseObject
field :budgets, Types::BudgetType.connection_type, "Returns all budgets", null: false
field :budget, Types::BudgetType, "Returns budget for ID", null: false do
argument :id, ID, required: true, default_value: false
def self.collection_and_object_by_id_fields(name, type)
collection_field name.to_s.pluralize.to_sym, type, "Returns all #{name.to_s.pluralize}", null: false
object_by_id_field name, type, "Returns #{name} for ID", null: false
end
field :comments, Types::CommentType.connection_type, "Returns all comments", null: false
field :comment, Types::CommentType, "Returns comment for ID", null: false do
argument :id, ID, required: true, default_value: false
end
field :debates, Types::DebateType.connection_type, "Returns all debates", null: false
field :debate, Types::DebateType, "Returns debate for ID", null: false do
argument :id, ID, required: true, default_value: false
end
field :geozones, Types::GeozoneType.connection_type, "Returns all geozones", null: false
field :geozone, Types::GeozoneType, "Returns geozone for ID", null: false do
argument :id, ID, required: true, default_value: false
end
field :milestones, Types::MilestoneType.connection_type, "Returns all milestones", null: false
field :milestone, Types::MilestoneType, "Returns milestone for ID", null: false do
argument :id, ID, required: true, default_value: false
end
field :proposals, Types::ProposalType.connection_type, "Returns all proposals", null: false
field :proposal, Types::ProposalType, "Returns proposal for ID", null: false do
argument :id, ID, required: true, default_value: false
end
field :proposal_notifications,
Types::ProposalNotificationType.connection_type,
"Returns all proposal notifications",
null: false
field :proposal_notification,
Types::ProposalNotificationType,
"Returns proposal notification for ID",
null: false do
argument :id, ID, required: true, default_value: false
end
field :tags, Types::TagType.connection_type, "Returns all tags", null: false
field :tag, Types::TagType, "Returns tag for ID", null: false do
argument :id, ID, required: true, default_value: false
end
field :users, Types::UserType.connection_type, "Returns all users", null: false
field :user, Types::UserType, "Returns user for ID", null: false do
argument :id, ID, required: true, default_value: false
end
field :votes, Types::VoteType.connection_type, "Returns all votes", null: false
field :vote, Types::VoteType, "Returns vote for ID", null: false do
argument :id, ID, required: true, default_value: false
end
collection_and_object_by_id_fields :budget, Types::BudgetType
collection_and_object_by_id_fields :comment, Types::CommentType
collection_and_object_by_id_fields :debate, Types::DebateType
collection_and_object_by_id_fields :geozone, Types::GeozoneType
collection_and_object_by_id_fields :milestone, Types::MilestoneType
collection_and_object_by_id_fields :proposal, Types::ProposalType
collection_and_object_by_id_fields :proposal_notification, Types::ProposalNotificationType
collection_and_object_by_id_fields :tag, Types::TagType
collection_and_object_by_id_fields :user, Types::UserType
collection_and_object_by_id_fields :vote, Types::VoteType
def budgets
Budget.public_for_api

6
app/graphql/types/user_type.rb
View File

@@ -1,9 +1,9 @@
module Types
class UserType < Types::BaseObject
field :id, ID, null: false
field :public_comments, Types::CommentType.connection_type, null: true
field :public_debates, Types::DebateType.connection_type, null: true
field :public_proposals, Types::ProposalType.connection_type, null: true
collection_field :public_comments, Types::CommentType, null: true
collection_field :public_debates, Types::DebateType, null: true
collection_field :public_proposals, Types::ProposalType, null: true
field :username, String, null: true
end
end