Apply (but don't add) ChangeByZero rubocop rule

This rule was added in rubocop-rspec 2.11.0. We aren't adding it
because, out of 3 offenses, this cop can only correct 2 automatically.
Not sure how to correct the other one since it uses `.and change`.
This commit is contained in:
Javi Martín
2023-08-29 19:22:49 +02:00
parent f79a21f071
commit c2010f9756

View File

@@ -250,7 +250,7 @@ describe Proposal do
describe "from anonymous users" do
it "does not register vote" do
user = create(:user)
expect { proposal.register_vote(user, "yes") }.to change { proposal.reload.votes_for.size }.by(0)
expect { proposal.register_vote(user, "yes") }.not_to change { proposal.reload.votes_for.size }
end
end
@@ -258,9 +258,7 @@ describe Proposal do
user = create(:user, verified_at: Time.current)
archived_proposal = create(:proposal, :archived)
expect do
archived_proposal.register_vote(user, "yes")
end.to change { proposal.reload.votes_for.size }.by(0)
expect { archived_proposal.register_vote(user, "yes") }.not_to change { proposal.reload.votes_for.size }
end
end