From c2010f9756aa82b518ffd041f7e25df8d0bd47f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 29 Aug 2023 19:22:49 +0200 Subject: [PATCH] Apply (but don't add) ChangeByZero rubocop rule This rule was added in rubocop-rspec 2.11.0. We aren't adding it because, out of 3 offenses, this cop can only correct 2 automatically. Not sure how to correct the other one since it uses `.and change`. --- spec/models/proposal_spec.rb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/spec/models/proposal_spec.rb b/spec/models/proposal_spec.rb index d30329213..9a4449a54 100644 --- a/spec/models/proposal_spec.rb +++ b/spec/models/proposal_spec.rb @@ -250,7 +250,7 @@ describe Proposal do describe "from anonymous users" do it "does not register vote" do user = create(:user) - expect { proposal.register_vote(user, "yes") }.to change { proposal.reload.votes_for.size }.by(0) + expect { proposal.register_vote(user, "yes") }.not_to change { proposal.reload.votes_for.size } end end @@ -258,9 +258,7 @@ describe Proposal do user = create(:user, verified_at: Time.current) archived_proposal = create(:proposal, :archived) - expect do - archived_proposal.register_vote(user, "yes") - end.to change { proposal.reload.votes_for.size }.by(0) + expect { archived_proposal.register_vote(user, "yes") }.not_to change { proposal.reload.votes_for.size } end end