Merge pull request #5122 from consul/strip-metadata

Remove metadata from images

app/models/image.rb

@@ -41,9 +41,9 @@ class Image < ApplicationRecord
 
   def variant(style)
     if style
-      attachment.variant(self.class.styles[style])
+      attachment.variant(self.class.styles[style].merge(strip: true))
     else
-      attachment
+      attachment.variant(strip: true)
     end
   end
 

spec/system/images_spec.rb

@@ -0,0 +1,25 @@
+require "rails_helper"
+
+describe "Images" do
+  before { Setting["uploads.images.min_height"] = 0 }
+
+  describe "Metadata" do
+    let(:image) { create(:image, attachment: fixture_file_upload("logo_header_with_metadata.jpg")) }
+
+    scenario "download original images without metadata" do
+      visit polymorphic_path(image.variant(nil))
+
+      file = MiniMagick::Image.open(page.find("img")["src"])
+
+      expect(file.exif).to be_empty
+    end
+
+    scenario "download transformed images without metadata" do
+      visit polymorphic_path(image.variant(:large))
+
+      file = MiniMagick::Image.open(page.find("img")["src"])
+
+      expect(file.exif).to be_empty
+    end
+  end
+end