consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move main <h1> tag inside main header

Browse Source 
A <header> tag is the natural place to have headings.

Since we already had the logo there, IMHO it makes sense to merge both
the <h1> tag and the logo together. We were already doing so in the
devise layout.

From the sceen reader users' point of view, having a link with the text
"CONSUL logo" is a bit confusing, since it seems to imply the link will
get us to the CONSUL logo. Using the organization name as the text of
the link makes more sense.

One thing changes, though. Before this commit, the first thing on the
page a screen reader user would hear about would be the organization
name. Now the language selector and the top links are announced before
the organization name is read. That's fine, since the actual first thing
these users will hear is the content of the <title> tag, which contains
the organization name as well.
This commit is contained in:
Javi Martín
2020-11-08 15:59:34 +01:00
parent 18813c8f2a
commit bb2e2fa0a3
5 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/views/layouts/_header.html.erb
View File

@@ -20,11 +20,11 @@
<%= t("application.menu") %>
</span>
<div class="top-bar-title">
<h1 class="top-bar-title">
<%= link_to root_path, accesskey: "0" do %>
<%= image_tag(image_path_for("logo_header.png"), class: "float-left", alt: t("layouts.header.logo")) %>
<%= image_tag(image_path_for("logo_header.png"), class: "float-left", alt: setting["org_name"]) %>
<% end %>
</div>
</h1>
<div id="responsive-menu">
<div class="top-bar-right">

2
app/views/layouts/application.html.erb
View File

@@ -16,8 +16,6 @@
<body class="<%= yield (:body_class) %>">
<%= raw setting["html.per_page_code_body"] %>
<h1 class="show-for-sr"><%= setting["org_name"] %></h1>
<div class="wrapper <%= yield (:wrapper_class) %>">
<%= render "layouts/header", with_subnavigation: true %>

2
app/views/layouts/devise.html.erb
View File

@@ -12,7 +12,7 @@
<div class="auth-image small-12 medium-3 column">
<h1 class="logo margin">
<%= link_to root_path do %>
<%= image_tag(image_path_for("logo_header.png"), class: "float-left", alt: t("layouts.header.logo")) %>
<%= image_tag(image_path_for("logo_header.png"), class: "float-left", alt: setting["org_name"]) %>
<% end %>
</h1>
</div>

1
config/locales/en/general.yml
View File

@@ -233,7 +233,6 @@ en:
collaborative_legislation: Collaborative legislation
debates: Debates
locale: "Language:"
logo: CONSUL logo
management: Management
moderation: Moderation
valuation: Valuation

1
config/locales/es/general.yml
View File

@@ -233,7 +233,6 @@ es:
collaborative_legislation: Legislación colaborativa
debates: Debates
locale: "Idioma:"
logo: Logo de CONSUL
management: Gestión
moderation: Moderar
valuation: Evaluación