Use milestoneable to find/create a milestone

This way we simplify the code and avoid strange cases like `params[:id]`
having an ID which doesn't belong to the current milestoneable.
This commit is contained in:
Javi Martín
2018-11-13 11:13:59 +01:00
parent c4448faf70
commit ae22cd247a

View File

@@ -14,8 +14,7 @@ class Admin::MilestonesController < Admin::BaseController
end
def create
@milestone = Milestone.new(milestone_params)
@milestone.milestoneable = @milestoneable
@milestone = @milestoneable.milestones.new(milestone_params)
if @milestone.save
redirect_to milestoneable_path, notice: t('admin.milestones.create.notice')
else
@@ -64,7 +63,7 @@ class Admin::MilestonesController < Admin::BaseController
end
def get_milestone
Milestone.find(params[:id])
@milestoneable.milestones.find(params[:id])
end
def load_statuses