From ae22cd247a5c3bf62fa53839722fa397a4df53b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 13 Nov 2018 11:13:59 +0100 Subject: [PATCH] Use milestoneable to find/create a milestone This way we simplify the code and avoid strange cases like `params[:id]` having an ID which doesn't belong to the current milestoneable. --- app/controllers/admin/milestones_controller.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/controllers/admin/milestones_controller.rb b/app/controllers/admin/milestones_controller.rb index dde88512b..9a29f6015 100644 --- a/app/controllers/admin/milestones_controller.rb +++ b/app/controllers/admin/milestones_controller.rb @@ -14,8 +14,7 @@ class Admin::MilestonesController < Admin::BaseController end def create - @milestone = Milestone.new(milestone_params) - @milestone.milestoneable = @milestoneable + @milestone = @milestoneable.milestones.new(milestone_params) if @milestone.save redirect_to milestoneable_path, notice: t('admin.milestones.create.notice') else @@ -64,7 +63,7 @@ class Admin::MilestonesController < Admin::BaseController end def get_milestone - Milestone.find(params[:id]) + @milestoneable.milestones.find(params[:id]) end def load_statuses